Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #13658

Merged
merged 12 commits into from
May 6, 2021
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-05-01 #13658

merged 12 commits into from
May 6, 2021

Conversation

karthikku-2020
Copy link
Contributor

@karthikku-2020 karthikku-2020 commented Mar 26, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@karthikku-2020 karthikku-2020 requested a review from kjeur as a code owner March 26, 2021 01:07
@openapi-workflow-bot
Copy link

Hi, @karthikku-2020 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 26, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventsModel'. Consider using the plural form of 'Events' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1655
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LotsModel'. Consider using the plural form of 'Lots' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1752


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedCost'
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1557
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'Microsoft.Consumption, Microsoft.Billing' doesn't match the namespace.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L36
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L424
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1477
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Charges_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L480
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventsModel'. Consider using the plural form of 'Events' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1604
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LotsModel'. Consider using the plural form of 'Lots' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1707
    ⚠️ R3017 - GuidUsage Guid used in model definition 'LegacyUsageDetailProperties' for property 'meterId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2031
    ⚠️ R3017 - GuidUsage Guid used in model definition 'ModernUsageDetailProperties' for property 'meterId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2259
    ⚠️ R3017 - GuidUsage Guid used in model definition 'MarketplaceProperties' for property 'meterId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Consumption/stable/2021-05-01/consumption.json#L2675
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross Version BreakingChange (Base on preview version): 40 Errors, 1 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Consumption/usageDetails/download' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L154:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/reservationRecommendations' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L876:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' removed or restructured?
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1194:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed?
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1842:3
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1237:3
    1008 - ModifiedOperationId The operation id has been changed from 'Charges_ListByScope' to 'Charges_List'. This will impact generated code.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L480:7
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L533:7
    1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L467:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L131:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L119:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L218:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L275:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1319:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L958:11
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1385:11
    Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1023:11
    ️❌Cross Version BreakingChange (Base on stable version): 5 Errors, 0 Warnings failed [Detail]
    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'Events_List' to 'Events_ListByBillingProfile'. This will impact generated code.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1600:7
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1600:7
    1008 - ModifiedOperationId The operation id has been changed from 'Lots_List' to 'Lots_ListByBillingProfile'. This will impact generated code.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1703:7
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1651:7
    1015 - ParameterInHasChanged How the parameter is passed has changed -- it used to be 'query', now it is 'path'.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1146:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L1146:9
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1146:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'enum' value than the previous one.
    New: Microsoft.Consumption/stable/2021-05-01/consumption.json#L5052:9
    Old: Microsoft.Consumption/stable/2019-11-01/consumption.json#L4928:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Schema 'ReservationRecommendationDetailsModel' has a property 'etag' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ReservationRecommendationDetailsModel"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Schema 'ReservationRecommendationDetailsModel' has a property 'etag' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ReservationRecommendationDetailsModel"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction"
    ⚠️ Modeler "readme":"consumption/resource-manager/readme.md",
    "tag":"package-preview-2018-11",
    "details":"Integer schema 'schemas:49' with unknown format: 'date-time' is not valid. Treating it as 'int32'."
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-05",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 26, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️consumption/mgmt/2019-10-01/consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New field `ClosedBalanceInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `BillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `CreditExpiredInBillingCurrency` in struct `EventProperties`
      info	[Changelog] - New field `SkuName` in struct `ModernReservationRecommendationProperties`
      info	[Changelog] - New field `SubscriptionID` in struct `ModernReservationRecommendationProperties`
      info	[Changelog] - New field `ResourceType` in struct `ModernReservationRecommendationProperties`
      info	[Changelog] - New field `Location` in struct `ModernReservationRecommendationProperties`
      info	[Changelog] - New field `Etag` in struct `ModernUsageDetail`
      info	[Changelog]
      info	[Changelog] Total 19 breaking change(s), 76 additive change(s).
      info	[Changelog]
    • ️✔️consumption/mgmt/2019-01-01/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-10-01/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-08-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-06-30/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-05-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-03-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-01-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2017-11-30/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter lot_id
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_display_name
      info	[Changelog]   - Model EventSummary has a new parameter lot_source
      info	[Changelog]   - Model EventSummary has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter billing_profile_id
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter purchase_date
      info	[Changelog]   - Model LotSummary has a new parameter status
      info	[Changelog]   - Model CreditSummary has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model UsageDetail has a new parameter etag
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_account
      info	[Changelog]   - Added operation EventsOperations.list_by_billing_profile
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_account
      info	[Changelog]   - Added operation LotsOperations.list_by_billing_profile
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation EventsOperations.list
      info	[Changelog]   - Removed operation LotsOperations.list
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
      cmderr	[npmPack] created ./dist/arm-consumption.js in 557ms
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ReservationSummary has a new parameter kind
      info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
      info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model Notification has a new parameter threshold_type
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model Budget has a new parameter filter
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
      info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
      info	[Changelog]   - Model ReservationDetail has a new parameter kind
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Added operation ReservationsDetailsOperations.list
      info	[Changelog]   - Added operation ReservationsSummariesOperations.list
      info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
      info	[Changelog]   - Added operation ChargesOperations.list
      info	[Changelog]   - Added operation group LotsOperations
      info	[Changelog]   - Added operation group ReservationTransactionsOperations
      info	[Changelog]   - Added operation group EventsOperations
      info	[Changelog]   - Added operation group CreditsOperations
      info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model Budget no longer has parameter filters
      info	[Changelog]   - Model ReservationRecommendation has a new signature
      info	[Changelog]   - Model ChargeSummary has a new signature
      info	[Changelog]   - Model UsageDetail has a new signature
      info	[Changelog]   - Removed operation UsageDetailsOperations.download
      info	[Changelog]   - Removed operation ChargesOperations.list_by_scope
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b7199f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-06 02:36:50 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-consumption;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-06 02:36:50 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-06 02:36:50 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Skip] pom already has module sdk/consumption
      cmderr	[generate.py] 2021-05-06 02:37:31 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-06 02:40:09 DEBUG Got artifact_id: azure-resourcemanager-consumption
      cmderr	[Inst] 2021-05-06 02:40:09 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-06 02:40:09 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-05-06 02:40:09 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-05-06 02:40:09 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13658/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.2.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4b7199f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2553) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-03-31/Microsoft.Consumption.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2553) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2553) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️consumption [View full logs]  [Release Schema Changes]
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @karthikku-2020, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @karthikku-2020
    Copy link
    Contributor Author

    The SystemData properties being metadata for a resource does not fit into the consumption RP APIs. The reason being the most of Consumption RP APIs dont really create any actual resources. The data that's being surfaced is only consumption data and the metadata we are talking about here will not be of any use for the customer. Also, the API aggregates the data from multiple sources and will be almost impossible to provide the SystemData properties for the operations in discussion here.

    @PhoenixHe-NV
    Copy link
    Contributor

    @karthikku-2020
    Copy link
    Contributor Author

    @karthikku-2020 Please submit for lint suppression https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

    @PhoenixHe-msft - Can please review suppression updates?

    @PhoenixHe-NV PhoenixHe-NV merged commit 4b7199f into Azure:master May 6, 2021
    This was referenced May 6, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …on stable/2021-05-01 (Azure#13658)
    
    * Adds base for updating Microsoft.Consumption from version stable/2019-11-01 to version 2021-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Updates to Lots/Events
    
    * Lot source updated
    
    * Lot status updated
    
    * Lot source updated
    
    * prettier update
    
    * Events example file reference updated
    
    * Adding Lint Suppression
    
    * Update readme.md
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants