-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubernetesConfiguration Add package-preview-2021-03 #13374
KubernetesConfiguration Add package-preview-2021-03 #13374
Conversation
Hi, @jonathan-innis Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ConfigurationSettings' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ExtensionProtectedSettings' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ConfigurationIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ExtensionInstance' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ExtensionInstancesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"The schema 'ExtensionInstanceUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"kubernetesconfiguration/resource-manager/readme.md", "tag":"package-preview-2020-07-extensions", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
@ArcturusZhang @qiaozha @jsntcy @msyyc @lirenhe Can you please look over this? We need to get our SDK generation out quickly to make deadlines for public preview. Thanks! |
@jonathan-innis Are you trying to resolve this issue? https://github.com/Azure/sdk-release-request/issues/1348 But from the file changes, it's not change it into multi-packages. |
We are trying to have a solution where we release SDKs for the version we just updated 2020-07-01-preview. We aren't necessarily interested in breaking into packages |
Ultimately we just need to be able to release these SDKs with the updated swagger spec with this version |
specification/kubernetesconfiguration/resource-manager/readme.ruby.md
Outdated
Show resolved
Hide resolved
specification/kubernetesconfiguration/resource-manager/readme.md
Outdated
Show resolved
Hide resolved
e81846c
to
e6da682
Compare
Hi @jonathan-innis, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @jonathan-innis, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
c4fb19e
to
12472fe
Compare
|
||
```yaml $(tag) == 'package-preview-2020-07-extensions' | ||
input-file: | ||
- Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you only set Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json
as input file, once we release a new SDK, it will only contain features in Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json
, but no features in kubernetesconfiguration.json
, is it what you expected?
From users' perspective, if they use the new SDK, they will be broken as features in kubernetesconfiguration.json
are missing in new SDK.
@jonathan-innis Hey Jonathan, when looking at your PR, it seems you guys removed an existing stable tag "tag: package-2021-03 Please be aware that this is not allowed, the suggested approach is to create a new tag that takes the same input files, for example, your latest API is "2021-04", you should create a "2021-04-preview" |
cc @josefree |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.