Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesConfiguration Add package-preview-2021-03 #13374

Conversation

jonathan-innis
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jonathan-innis Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 10, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 9 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ConfigurationSettings' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ExtensionProtectedSettings' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ConfigurationIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ExtensionInstance' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ExtensionInstancesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"The schema 'ExtensionInstanceUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"kubernetesconfiguration/resource-manager/readme.md",
    "tag":"package-preview-2020-07-extensions",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 10, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
    • ️✔️@azure/arm-kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
      cmderr	[npmPack] created ./dist/arm-kubernetesconfiguration.js in 159ms
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-03-16 05:54:18 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration"
      cmderr	[generate.py] 2021-03-16 05:54:18 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-03-16 05:54:18 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration --java.namespace=com.azure.resourcemanager.kubernetesconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [POM][Skip] pom already has module azure-resourcemanager-kubernetesconfiguration
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-03-16 05:54:45 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-03-16 05:57:07 DEBUG Got artifact_id: azure-resourcemanager-kubernetesconfiguration
      cmderr	[Inst] 2021-03-16 05:57:07 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-03-16 05:57:07 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-16 05:57:07 DEBUG Match jar package: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-16 05:57:07 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13374/azure-sdk-for-java/azure-resourcemanager-kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\" -o azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-kubernetesconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-python failed [Detail]
    • Failed [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!Error happened during package
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️kubernetesconfiguration/mgmt/2021-03-01/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/kubernetesconfiguration/mgmt/2020-10-01-preview/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/kubernetesconfiguration/mgmt/2020-07-01-preview/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/kubernetesconfiguration/mgmt/2020-07-01-extensions/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview/kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
    • ️✔️kubernetesconfiguration [View full logs]  [Preview Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN [email protected] No repository field.
      cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from b6d2236abd7e8a518980c9b7510254efcfc89733. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.SourceControlConfiguration [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @jonathan-innis
    Copy link
    Contributor Author

    @ArcturusZhang @qiaozha @jsntcy @msyyc @lirenhe Can you please look over this? We need to get our SDK generation out quickly to make deadlines for public preview. Thanks!

    @qiaozha
    Copy link
    Member

    qiaozha commented Mar 12, 2021

    @jonathan-innis Are you trying to resolve this issue? https://github.com/Azure/sdk-release-request/issues/1348 But from the file changes, it's not change it into multi-packages.

    @jsntcy jsntcy requested a review from 00Kai0 March 12, 2021 03:38
    @jonathan-innis
    Copy link
    Contributor Author

    jonathan-innis commented Mar 12, 2021

    @jonathan-innis Are you trying to resolve this issue? https://github.com/Azure/sdk-release-request/issues/1348 But from the file changes, it's not change it into multi-packages.

    We are trying to have a solution where we release SDKs for the version we just updated 2020-07-01-preview. We aren't necessarily interested in breaking into packages

    @jonathan-innis
    Copy link
    Contributor Author

    Ultimately we just need to be able to release these SDKs with the updated swagger spec with this version

    @jonathan-innis
    Copy link
    Contributor Author

    @kairu-ms @jsntcy @qiaozha @msyyc @00Kai0 Can you please look over this today so that we can get this merged in today?

    @jonathan-innis jonathan-innis changed the title KubernetesConfiguration Regenerate SDKs for API Version 2020-07-01-preview KubernetesConfiguration Add KubernetesConfiguration package 2021-03-preview Mar 15, 2021
    @jonathan-innis jonathan-innis changed the title KubernetesConfiguration Add KubernetesConfiguration package 2021-03-preview KubernetesConfiguration Add package-preview-2021-03 Mar 15, 2021
    @jonathan-innis jonathan-innis force-pushed the kubernetesconfiguration/older-api-version branch from e81846c to e6da682 Compare March 16, 2021 01:02
    @openapi-workflow-bot
    Copy link

    Hi @jonathan-innis, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @jonathan-innis, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @jonathan-innis jonathan-innis force-pushed the kubernetesconfiguration/older-api-version branch from c4fb19e to 12472fe Compare March 16, 2021 01:59

    ```yaml $(tag) == 'package-preview-2020-07-extensions'
    input-file:
    - Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    If you only set Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json as input file, once we release a new SDK, it will only contain features in Microsoft.KubernetesConfiguration/preview/2020-07-01-preview/extensions.json, but no features in kubernetesconfiguration.json, is it what you expected?
    From users' perspective, if they use the new SDK, they will be broken as features in kubernetesconfiguration.json are missing in new SDK.

    @nickzhums
    Copy link
    Contributor

    @jonathan-innis Hey Jonathan, when looking at your PR, it seems you guys removed an existing stable tag "tag: package-2021-03
    " and changed it to "tag: package-preview-2020-07-extensions"

    Please be aware that this is not allowed, the suggested approach is to create a new tag that takes the same input files, for example, your latest API is "2021-04", you should create a "2021-04-preview"

    @nickzhums
    Copy link
    Contributor

    cc @josefree

    @jonathan-innis jonathan-innis deleted the kubernetesconfiguration/older-api-version branch March 16, 2021 17:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants