[Do not Merge] [Private SDK] Add Version Level WORM Api Support #13333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @HimanshuChhabra Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Storage/stable/2021-01-01/blob.json#L819:5 |
|
The new version has a new property 'versionLevelWorm' in response that was not found in the old version. New: Microsoft.Storage/stable/2021-01-01/blob.json#L862:7 Old: Microsoft.Storage/stable/2021-01-01/blob.json#L822:7 |
|
The new version has a new optional property 'versionLevelWorm' that was not found in the old version. New: Microsoft.Storage/stable/2021-01-01/blob.json#L862:7 Old: Microsoft.Storage/stable/2021-01-01/blob.json#L822:7 |
️❌LintDiff: 1 Errors, 2 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
- Linted configuring files (Based on target branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
| Rule | Message |
|---|---|
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Storage/stable/2021-01-01/blob.json#L848 |
| 'PUT' operation 'BlobContainers_VersionLevelWorm' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Storage/stable/2021-01-01/blob.json#L824 |
|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'BlobContainers_VersionLevelWorm', Response code: '200' Location: Microsoft.Storage/stable/2021-01-01/blob.json#L849 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The example JSON file is not referenced from the swagger file. readme: specification/storage/resource-manager/readme.md json: stable/2021-01-01/examples/BlobContainersPutVersionLevelWorm.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 150 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'OperationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'ServiceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'MetricSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'Dimension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'StorageAccountCheckNameAvailabilityParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'SKUCapability' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"storage/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'StorageSkuListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌[Staging] SpellCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unknown word (leve), please fix the error or add words to ./custom-words.txt path: Microsoft.Storage/stable/2021-01-01/blob.json#L853:85 |
Swagger Generation Artifacts
|
HimanshuChhabra
changed the title
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
Hi @HimanshuChhabra, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
This was referenced Mar 9, 2021
blueww
reviewed
Mar 9, 2021
specification/storage/resource-manager/Microsoft.Storage/stable/2021-01-01/blob.json
Outdated
Show resolved
Hide resolved
blueww
reviewed
Mar 9, 2021
specification/storage/resource-manager/Microsoft.Storage/stable/2021-01-01/blob.json
Outdated
Show resolved
Hide resolved
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Juliehzl
reviewed
Mar 16, 2021
| "description": "Accepted -- Blob Container migration to support version leve worm is accepted; operation will complete asynchronously." | ||
| } | ||
| }, | ||
| "x-ms-long-running-operation": true |
There was a problem hiding this comment.
please specify final-state0via according to https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-long-running-operation-options
There was a problem hiding this comment.
azure-async-operation - (default if not specified) poll until terminal state, the final response will be available at the uri pointed to by the header Azure-AsyncOperation
By default it will use the above, which I need so will keep it like this if no worries
Juliehzl
reviewed
Mar 16, 2021
specification/storage/resource-manager/Microsoft.Storage/stable/2021-01-01/blob.json
Show resolved
Hide resolved
|
any update for the PR? |
Juliehzl
added
the
DoNotMerge
|
Hi, @HimanshuChhabra. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi @HimanshuChhabra, any update for this feature? Do you want it go to April version with zhenfeng's change? |
Yes, the feature is part of april21 API version. It has changes in property name and updated examples. |
|
Hi, @HimanshuChhabra. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi @HimanshuChhabra, could we close this PR? Have you add this feature in new April version? |
|
support in #14211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.