[AppConfiguration] Add system metadata #13320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @x9xu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'systemData' in response that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1048:7 Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1048:7 |
|
The new version has a new optional property 'systemData' that was not found in the old version. New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1048:7 Old: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1048:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ModelValidation: 26 Errors, 0 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Missing required property definition: location JsonUrl: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1036 |
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"appconfiguration/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"appconfiguration/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"appconfiguration/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"appconfiguration/resource-manager/readme.md", "tag":"package-2020-07-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Mar 8, 2021
|
Hi @x9xu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, could you pls refer this type . |
|
NewApiVersionRequired reason: |
|
Hi @x9xu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
ruowan
approved these changes
Mar 16, 2021
|
It's known issue for model validation and semantic validation. This is caused by duplicated model name defined in local swagger and referenced types.json from common-types folder (usually 'Resource' model). Because you are updating existing api-version. Could you add suppression for this api-version? How to add suppression in readme.md |
|
Replaced by #13490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing preview version for new feature for resource system metadata as required in ARM RPC.