Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger quality issues with access review APIs | Mark fields as nullable #13124

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix swagger quality issues with access review APIs | Mark fields as nullable #13124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...r/Microsoft.Authorization/preview/2018-05-01-preview/authorization-AccessReviewCalls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,13 +1343,13 @@
"type": "string",
"format": "date-time",
"description": "The DateTime when the review is scheduled to be start. This could be a date in the future. Required on create.",
"x-nullable": false
"x-nullable": true
},
"endDate": {
"type": "string",
"format": "date-time",
"description": "The DateTime when the review is scheduled to end. Required if type is endDate",
"x-nullable": false
"x-nullable": true
}
},
"description": "Recurrence Range of an Access Review Schedule Definition."
Expand Down Expand Up @@ -1476,13 +1476,14 @@
"readOnly": true,
"format": "date-time",
"description": "Date Time when a decision was taken.",
"x-nullable": false
"x-nullable": true
},
"reviewedBy": {
"readOnly": true,
"x-ms-client-flatten": true,
"$ref": "#/definitions/AccessReviewActorIdentity",
"description": "Details of the approver."
"description": "Details of the approver.",
"x-nullable": true
},
"applyResult": {
"type": "string",
Expand All @@ -1506,13 +1507,14 @@
"readOnly": true,
"format": "date-time",
"description": "The date and time when the review decision was applied.",
"x-nullable": false
"x-nullable": true
},
"appliedBy": {
"readOnly": true,
"x-ms-client-flatten": true,
"$ref": "#/definitions/AccessReviewActorIdentity",
"description": "Details of the approver."
"description": "Details of the applier.",
"x-nullable": true
}
},
"description": "Approval Step."
Expand Down