Authorization - Add roleassignmentmetrics calls and fix correctness issues #13119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ClassicAdministratorProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ClassicAdministrator' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ClassicAdministratorListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ResourceType' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ProviderOperationsMetadata' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'ProviderOperationsMetadataListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'RoleDefinitionFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'RoleDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2020-04-01-preview", "details":"The schema 'RoleDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @jdhms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Feb 23, 2021
This was referenced Feb 23, 2021
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @jdhms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @qianwens |
|
Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued. |
@chiragg4u Thank you, fixed |
filizt
reviewed
Mar 8, 2021
...r/Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json
Show resolved
Hide resolved
filizt
reviewed
Mar 8, 2021
...ager/Microsoft.Authorization/preview/2019-08-01-preview/authorization-UsageMetricsCalls.json
Show resolved
Hide resolved
|
There are breaking changes in the PR that has to go through the breaking changes review. Please find more information on the process here: https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes |
This PR was opened during the window to fix broken for KPIs and its purpose is to fix s360 issues, would this still apply? |
It makes sense to me however you need to bring it up with API Breaking Changes person who is reviewing this PR. |
@filizt will do, thanks! do we need anything else for ARM sign-off prior to then? |
filizt
reviewed
Mar 10, 2021
...horization/preview/2019-08-01-preview/examples/RoleAssignmentMetrics_GetForSubscription.json
Outdated
Show resolved
Hide resolved
Just added a comment for a nit issue. Other than that LGTM. Will have to wait until the breaking changes board review to finalize from ARM side. |
|
NewApiVersionRequired reason: |
|
Hi @jdhms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
25 tasks
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Mar 10, 2021
This was referenced Mar 11, 2021
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
…ssues (Azure#13119) * add roleassignmentmetrics calls and fix correctness issues * update parameter * update version * fix new ci requirement
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ssues (Azure#13119) * add roleassignmentmetrics calls and fix correctness issues * update parameter * update version * fix new ci requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.