Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s360 in 2020-03-01 remove empty schema in actions to match the RP. #12975

Conversation

brpanask
Copy link
Contributor

@brpanask brpanask commented Feb 12, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @brpanask Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 12, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 16 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'ApiOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'AscOperationProperties-output' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'CacheIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'CacheNetworkSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'CacheEncryptionSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'CacheSecuritySettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'KeyVaultKeyReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'KeyVaultKeyReference-sourceVault' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'CacheHealth' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"storagecache/resource-manager/readme.md",
    "tag":"package-2020-03-01",
    "details":"The schema 'StorageTargetResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 12, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 11a54f2. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️storagecache/mgmt/2020-10-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️storagecache/mgmt/2020-03-01/storagecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `StorageTargetsClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Function `CachesClient.StopResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Function `CachesClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Function `CachesClient.UpgradeFirmwareResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Function `CachesClient.FlushResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Function `CachesClient.StartResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
      info	[Changelog] - Type of `CachesStopFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesUpgradeFirmwareFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesFlushFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `StorageTargetsDeleteFuture.Result` has been changed from `func(StorageTargetsClient) (SetObject, error)` to `func(StorageTargetsClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesDeleteFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesStartFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Struct `SetObject` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `AscOperation.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `AscOperationProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*AscOperation.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `AscOperationProperties`
      info	[Changelog] - New anonymous field `*AscOperationProperties` in struct `AscOperation`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️storagecache/mgmt/2019-11-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/storagecache/mgmt/2019-08-01-preview/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python warning [Detail]
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 11a54f2. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'Nfs3TargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ClfsTargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'UnknownTargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ApiOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AscOperationProperties-output' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheNetworkSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheEncryptionSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheSecuritySettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheActiveDirectorySettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheUsernameDownloadSettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference-sourceVault' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheHealth' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageTargetResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Nfs3Target' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ClfsTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UnknownTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkusResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /AscOperations/get/AscOperations_Get
      cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate
      cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate_ldap_only
      cmderr	[Autorest]     - name: /Caches/get/Caches_Get
      cmderr	[Autorest]     - name: /Caches/get/Caches_List
      cmderr	[Autorest]     - name: /Caches/get/Caches_ListByResourceGroup
      cmderr	[Autorest]     - name: /Caches/patch/Caches_Update
      cmderr	[Autorest]     - name: /Caches/patch/Caches_Update_ldap_only
      cmderr	[Autorest]     - name: /Caches/post/Caches_DebugInfo
      cmderr	[Autorest]     - name: /Caches/post/Caches_Flush
      cmderr	[Autorest]     - name: /Caches/post/Caches_Start
      cmderr	[Autorest]     - name: /Caches/post/Caches_Stop
      cmderr	[Autorest]     - name: /Caches/post/Caches_UpgradeFirmware
      cmderr	[Autorest]     - name: /Caches/delete/Caches_Delete
      cmderr	[Autorest]     - name: /Skus/get/Skus_List
      cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate
      cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate_NoJunctions
      cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_Get
      cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_List
      cmderr	[Autorest]     - name: /StorageTargets/delete/StorageTargets_Delete
      cmderr	[Autorest]     - name: /UsageModels/get/UsageModels_List
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️storagecache [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 11a54f2. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-19 18:23:14 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storagecache"
      cmderr	[generate.py] 2021-02-19 18:23:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-19 18:23:14 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagecache/azure-resourcemanager-storagecache --java.namespace=com.azure.resourcemanager.storagecache   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [POM][Skip] pom already has module azure-resourcemanager-storagecache
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-19 18:23:55 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Got artifact_id: azure-resourcemanager-storagecache
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG Match jar package: azure-resourcemanager-storagecache-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-19 18:27:02 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12975/azure-sdk-for-java/azure-resourcemanager-storagecache/azure-resourcemanager-storagecache-1.0.0-beta.1.jar\" -o azure-resourcemanager-storagecache-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagecache -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagecache-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-net warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 11a54f2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 11a54f2. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 11a54f2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
    • ️✔️@azure/arm-storagecache [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/storageCacheManagementClient.js → ./dist/arm-storagecache.js...
      cmderr	[npmPack] created ./dist/arm-storagecache.js in 388ms
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

    @brpanask
    Copy link
    Contributor Author

    Updating this older version to resolve an s360 swagger correctness issue.
    The swagger was written with a body with no properties but the RP has never returned a body.
    This just updates the swagger to show that no body is returned in these operations.

    @markcowl
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @markcowl
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @markcowl markcowl closed this Feb 17, 2021
    @markcowl markcowl reopened this Feb 17, 2021
    @markcowl
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @markcowl
    Copy link
    Member

    @markcowl markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 18, 2021
    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @brpanask
    Copy link
    Contributor Author

    @markcowl
    Can this be merged now that its approved.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates CI-BreakingChange-Go FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants