[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #12969

michaelwstark · 2021-02-12T02:53:52Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
This is a documentation update. The code reflected in this api update has been deployed for several years.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
As soon as it is approved.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

… Issues

openapi-workflow-bot · 2021-02-12T02:53:54Z

Hi, @michaelwstark Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

michaelwstark · 2021-02-12T03:15:32Z

/azp run unifiedPipeline

openapi-pipeline-app · 2021-02-12T03:15:33Z

Swagger Validation Report

️❌BreakingChange: 295 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2018-09-15/DTL.json <---> new: stable/2018-09-15/DTL.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L38:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L152:11
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10550:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10692:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10596:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10757:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10625:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10789:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10694:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L11029:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10765:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L11094:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10809:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L11136:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L9731:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L9667:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L10703:9 Old: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L11037:9

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- devtestlabs/resource-manager/readme.md tag:package-2018-09
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- devtestlabs/resource-manager/readme.md tag:package-2018-09

Rule	Message
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Operations_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.DevTestLab/stable/2018-09-15/DTL.json#L121

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]

The following tags are being changed in this PR

devtestlabs/resource-manager/readme.md#package-2018-09

Rule	Message
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"devtestlabs/resource-manager/readme.md", "tag":"package-2018-09", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-12T03:15:34Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/devtestlabs/resource-manager/readme.md

️✔️@azure/arm-devtestlabs [View full logs] [Release SDK Changes]

azure-arm-devtestlabs-3.2.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/devTestLabsClient.js → ./dist/arm-devtestlabs.js...
cmderr	[npmPack] created ./dist/arm-devtestlabs.js in 796ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 353cfab. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/devtestlabs/resource-manager/readme.md

️✔️devtestlabs [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-09 05:07:59 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-devtestlabs"
cmderr	[generate.py] 2021-03-09 05:07:59 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-09 05:07:59 INFO autorest --version=3.1.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/devtestlabs/azure-resourcemanager-devtestlabs --java.namespace=com.azure.resourcemanager.devtestlabs   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/devtestlabs/resource-manager/readme.md
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [POM][Skip] pom already has module azure-resourcemanager-devtestlabs
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-09 05:08:47 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-devtestlabs [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-03-09 05:12:13 DEBUG Got artifact_id: azure-resourcemanager-devtestlabs
cmderr	[Inst] 2021-03-09 05:12:13 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-09 05:12:13 DEBUG Got artifact: azure-resourcemanager-devtestlabs-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-03-09 05:12:13 DEBUG Got artifact: azure-resourcemanager-devtestlabs-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-09 05:12:13 DEBUG Match jar package: azure-resourcemanager-devtestlabs-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-09 05:12:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12969/azure-sdk-for-java/azure-resourcemanager-devtestlabs/azure-resourcemanager-devtestlabs-1.0.0-beta.1.jar\" -o azure-resourcemanager-devtestlabs-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-devtestlabs -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-devtestlabs-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/devtestlabs/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DevTestLabs [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DevTestLabs.3.0.0.nupkg
- Microsoft.Azure.Management.DevTestLabs.3.0.0.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-devtestlabs [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Disk has a new parameter storage_account_id
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation SchedulesOperations.update has a new signature
info	[Changelog]   - Operation ServiceFabricsOperations.update has a new signature
info	[Changelog]   - Operation ServiceFabricSchedulesOperations.update has a new signature
info	[Changelog]   - Operation LabsOperations.update has a new signature
info	[Changelog]   - Operation CustomImagesOperations.update has a new signature
info	[Changelog]   - Operation VirtualMachinesOperations.update has a new signature
info	[Changelog]   - Operation DisksOperations.update has a new signature
info	[Changelog]   - Operation FormulasOperations.update has a new signature
info	[Changelog]   - Operation ArtifactSourcesOperations.update has a new signature
info	[Changelog]   - Operation VirtualMachineSchedulesOperations.update has a new signature
info	[Changelog]   - Operation EnvironmentsOperations.update has a new signature
info	[Changelog]   - Operation GlobalSchedulesOperations.update has a new signature
info	[Changelog]   - Operation NotificationChannelsOperations.update has a new signature
info	[Changelog]   - Operation VirtualNetworksOperations.update has a new signature
info	[Changelog]   - Operation UsersOperations.update has a new signature
info	[Changelog]   - Operation PoliciesOperations.update has a new signature
info	[Changelog]   - Operation SecretsOperations.update has a new signature
info	[Changelog]   - Model UserFragment no longer has parameter identity
info	[Changelog]   - Model UserFragment no longer has parameter secret_store
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter virtual_machine_creation_source
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter created_by_user
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter last_known_power_state
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter artifact_deployment_status
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter created_by_user_id
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter os_type
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter compute_id
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter fqdn
info	[Changelog]   - Model SecretFragment no longer has parameter value
info	[Changelog]   - Model DiskFragment has a new signature
info	[Changelog]   - Model DtlEnvironmentFragment has a new signature
info	[Changelog]   - Model LabFragment has a new signature
info	[Changelog]   - Model VirtualNetworkFragment has a new signature
info	[Changelog]   - Model CustomImageFragment has a new signature
info	[Changelog]   - Model PolicyFragment has a new signature
info	[Changelog]   - Model NotificationChannelFragment has a new signature
info	[Changelog]   - Model ApplicableScheduleFragment has a new signature
info	[Changelog]   - Model ArtifactSourceFragment has a new signature
info	[Changelog]   - Model FormulaFragment has a new signature
info	[Changelog]   - Model ScheduleFragment has a new signature
info	[Changelog]   - Model LabVirtualMachineFragment has a new signature
info	[Changelog]   - Model ServiceFabricFragment has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️devtestlabs/mgmt/2018-09-15/dtl [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - Field `*LabVirtualMachinePropertiesFragment` of struct `LabVirtualMachineFragment` has been removed
info	[Changelog] - Field `*NotificationChannelPropertiesFragment` of struct `NotificationChannelFragment` has been removed
info	[Changelog] - Field `*FormulaPropertiesFragment` of struct `FormulaFragment` has been removed
info	[Changelog] - Field `*UserPropertiesFragment` of struct `UserFragment` has been removed
info	[Changelog] - Field `*SchedulePropertiesFragment` of struct `ScheduleFragment` has been removed
info	[Changelog] - Field `*SecretPropertiesFragment` of struct `SecretFragment` has been removed
info	[Changelog] - Field `*PolicyPropertiesFragment` of struct `PolicyFragment` has been removed
info	[Changelog] - Field `*VirtualNetworkPropertiesFragment` of struct `VirtualNetworkFragment` has been removed
info	[Changelog] - Field `*ServiceFabricPropertiesFragment` of struct `ServiceFabricFragment` has been removed
info	[Changelog] - Field `*DiskPropertiesFragment` of struct `DiskFragment` has been removed
info	[Changelog] - Field `Fqdn` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `LastKnownPowerState` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `CreatedByUser` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `OsType` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `VirtualMachineCreationSource` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `ArtifactDeploymentStatus` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `CreatedByUserID` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `ComputeID` of struct `LabVirtualMachineCreationParameterProperties` has been removed
info	[Changelog] - Field `*ArtifactSourcePropertiesFragment` of struct `ArtifactSourceFragment` has been removed
info	[Changelog] - Field `*LabPropertiesFragment` of struct `LabFragment` has been removed
info	[Changelog] - Field `*CustomImagePropertiesFragment` of struct `CustomImageFragment` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `ManagedIdentityTypeNone`
info	[Changelog] - New const `StorageAccount`
info	[Changelog] - New const `Ambiguous`
info	[Changelog] - New const `Moved`
info	[Changelog] - New const `RedirectMethod`
info	[Changelog] - New const `ManagedIdentityTypeSystemAssigned`
info	[Changelog] - New const `ManagedIdentityTypeSystemAssignedUserAssigned`
info	[Changelog] - New const `ManagedIdentityTypeUserAssigned`
info	[Changelog] - New const `Found`
info	[Changelog] - New const `RedirectKeepVerb`
info	[Changelog] - New function `PossibleManagedIdentityTypeValues() []ManagedIdentityType`
info	[Changelog] - New struct `ServiceRunnerList`
info	[Changelog] - New field `StorageAccountID` in struct `DiskProperties`
info	[Changelog]
info	[Changelog] Total 147 breaking change(s), 14 additive change(s).
info	[Changelog]

️✔️devtestlabs/mgmt/2016-05-15/dtl [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/devtestlabs/mgmt/2015-05-21-preview/dtl [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 353cfab. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-devtestlabs [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Disk has a new parameter storage_account_id
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation EnvironmentsOperations.update has a new signature
info	[Changelog]   - Operation PoliciesOperations.update has a new signature
info	[Changelog]   - Operation SchedulesOperations.update has a new signature
info	[Changelog]   - Operation ArtifactSourcesOperations.update has a new signature
info	[Changelog]   - Operation NotificationChannelsOperations.update has a new signature
info	[Changelog]   - Operation ServiceFabricSchedulesOperations.update has a new signature
info	[Changelog]   - Operation UsersOperations.update has a new signature
info	[Changelog]   - Operation CustomImagesOperations.update has a new signature
info	[Changelog]   - Operation DisksOperations.update has a new signature
info	[Changelog]   - Operation GlobalSchedulesOperations.update has a new signature
info	[Changelog]   - Operation LabsOperations.update has a new signature
info	[Changelog]   - Operation VirtualMachineSchedulesOperations.update has a new signature
info	[Changelog]   - Operation VirtualMachinesOperations.update has a new signature
info	[Changelog]   - Operation ServiceFabricsOperations.update has a new signature
info	[Changelog]   - Operation FormulasOperations.update has a new signature
info	[Changelog]   - Operation VirtualNetworksOperations.update has a new signature
info	[Changelog]   - Operation SecretsOperations.update has a new signature
info	[Changelog]   - Model UserFragment no longer has parameter identity
info	[Changelog]   - Model UserFragment no longer has parameter secret_store
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter created_by_user
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter last_known_power_state
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter fqdn
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter artifact_deployment_status
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter compute_id
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter virtual_machine_creation_source
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter created_by_user_id
info	[Changelog]   - Model LabVirtualMachineCreationParameter no longer has parameter os_type
info	[Changelog]   - Model SecretFragment no longer has parameter value
info	[Changelog]   - Model DtlEnvironmentFragment has a new signature
info	[Changelog]   - Model PolicyFragment has a new signature
info	[Changelog]   - Model ServiceFabricFragment has a new signature
info	[Changelog]   - Model LabVirtualMachineFragment has a new signature
info	[Changelog]   - Model NotificationChannelFragment has a new signature
info	[Changelog]   - Model DiskFragment has a new signature
info	[Changelog]   - Model ScheduleFragment has a new signature
info	[Changelog]   - Model LabFragment has a new signature
info	[Changelog]   - Model VirtualNetworkFragment has a new signature
info	[Changelog]   - Model CustomImageFragment has a new signature
info	[Changelog]   - Model FormulaFragment has a new signature
info	[Changelog]   - Model ArtifactSourceFragment has a new signature
info	[Changelog]   - Model ApplicableScheduleFragment has a new signature

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-02-12T03:15:37Z

No pipelines are associated with this pull request.

openapi-workflow-bot · 2021-02-12T03:17:15Z

Hi @michaelwstark, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-02-12T03:17:59Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

openapi-workflow-bot · 2021-02-12T05:16:18Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-02-12T05:16:19Z

Hi @michaelwstark, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

zhenglaizhang · 2021-02-18T03:55:23Z

/azp run

azure-pipelines · 2021-02-18T03:55:37Z

Azure Pipelines successfully started running 2 pipeline(s).

erich-wang · 2021-03-01T05:39:40Z

Adding WaitForARMReview because of new api be added:
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DevTestLab/labs/{labName}/servicerunners

chiragg4u · 2021-03-01T17:55:31Z

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

michaelwstark · 2021-03-01T18:43:01Z

Adding WaitForARMReview because of new api be added:
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DevTestLab/labs/{labName}/servicerunners

@erich-wang ServiceRunners were in the previous documentation for the api version. The list call was not documented and that is what is being added here as part of S360 corrections.

michaelwstark · 2021-03-01T18:47:03Z

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

@chiragg4u I see everything in the contribution checklist marked off -- what is missing, or where was process not followed?

erich-wang · 2021-03-04T05:28:15Z

@michaelwstark , you need to check the first check box under ARM API Review Checklist.

michaelwstark · 2021-03-05T07:04:10Z

@michaelwstark , you need to check the first check box under ARM API Review Checklist.

@Erica-Wang - I have removed the added api -- I do not believe it needs to be checked with the present state of the PR. Please correct me if I am wrong.

…n stable/2018-09-15 (Azure#12969) * Microsoft.DevTestLabs - Fix OpenApi Spec Correctness and Completeness Issues * Fix ResourceGroup Token * Remove Unreferenced Example * Fix Prettier Issues * Remove generated list api for service runners

Microsoft.DevTestLabs - Fix OpenApi Spec Correctness and Completeness…

5ade379

… Issues

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 12, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 12, 2021

openapi-workflow-bot bot added the FixS360 label Feb 12, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 12, 2021

michaelwstark added 2 commits February 11, 2021 21:04

Fix ResourceGroup Token

88b9228

Remove Unreferenced Example

0f8aaf9

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Feb 12, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 12, 2021

Fix Prettier Issues

c37dfe3

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 22, 2021

JeffreyRichter approved these changes Feb 22, 2021

View reviewed changes

michaelwstark marked this pull request as ready for review February 26, 2021 22:52

openapi-assignment-bot bot assigned erich-wang Feb 26, 2021

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 1, 2021

Remove generated list api for service runners

6ad81cc

openapi-pipeline-app bot removed the NewApiVersionRequired label Mar 5, 2021

openapi-sdkautomation bot mentioned this pull request Mar 5, 2021

[AutoPR azure-mgmt-devtestlabs] [Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 AzureSDKAutomation/azure-sdk-for-python#4512

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Mar 5, 2021

openapi-sdkautomation bot mentioned this pull request Mar 5, 2021

[AutoPR track2_azure-mgmt-devtestlabs] [Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 AzureSDKAutomation/azure-sdk-for-python#4513

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Mar 5, 2021

erich-wang approved these changes Mar 9, 2021

View reviewed changes

erich-wang merged commit 353cfab into Azure:master Mar 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #12969

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #12969

michaelwstark commented Feb 12, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 12, 2021

michaelwstark commented Feb 12, 2021

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

azure-pipelines bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

zhenglaizhang commented Feb 18, 2021

azure-pipelines bot commented Feb 18, 2021

erich-wang commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

michaelwstark commented Mar 1, 2021

michaelwstark commented Mar 1, 2021

erich-wang commented Mar 4, 2021

michaelwstark commented Mar 5, 2021

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #12969

[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #12969

Conversation

michaelwstark commented Feb 12, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 12, 2021

michaelwstark commented Feb 12, 2021

openapi-pipeline-app bot commented Feb 12, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 12, 2021 • edited Loading

Swagger Generation Artifacts

azure-pipelines bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

openapi-workflow-bot bot commented Feb 12, 2021

zhenglaizhang commented Feb 18, 2021

azure-pipelines bot commented Feb 18, 2021

erich-wang commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

michaelwstark commented Mar 1, 2021

michaelwstark commented Mar 1, 2021

erich-wang commented Mar 4, 2021

michaelwstark commented Mar 5, 2021

michaelwstark commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2021 •

edited

Loading