fix semantic and example errors in previous versions for compatability #12909

jdhms · 2021-02-09T00:09:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Update existing versions to use the common parameters for subscriptionId, resourceGroupName, and apiVersion. This enables compatibility when fixing subsequent s360 issues
Provide unique names for examples per validation errors
Add required and default responses

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-09T00:09:40Z

Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-02-09T00:09:41Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

openapi-pipeline-app · 2021-02-09T00:09:42Z

Swagger Validation Report

️❌BreakingChange: 106 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2015-06-01/authorization-ClassicAdminCalls.json <---> new: preview/2015-06-01/authorization-ClassicAdminCalls.json
- original: preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json <---> new: preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json
- original: preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json <---> new: preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json
- original: preview/2018-01-01-preview/authorization-RoleAssignmentsCalls.json <---> new: preview/2018-01-01-preview/authorization-RoleAssignmentsCalls.json
- original: preview/2018-01-01-preview/authorization-RoleDefinitionsCalls.json <---> new: preview/2018-01-01-preview/authorization-RoleDefinitionsCalls.json
- original: preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json <---> new: preview/2018-07-01-preview/authorization-DenyAssignmentGetCalls.json
- original: preview/2018-09-01-preview/authorization-RoleAssignmentsCalls.json <---> new: preview/2018-09-01-preview/authorization-RoleAssignmentsCalls.json
- original: preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json <---> new: preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json
- original: stable/2015-07-01/authorization-ClassicAdminCalls.json <---> new: stable/2015-07-01/authorization-ClassicAdminCalls.json
- original: stable/2015-07-01/authorization-ElevateAccessCalls.json <---> new: stable/2015-07-01/authorization-ElevateAccessCalls.json
- original: stable/2015-07-01/authorization-ProviderOperationsCalls.json <---> new: stable/2015-07-01/authorization-ProviderOperationsCalls.json
- original: stable/2015-07-01/authorization-RoleAssignmentsCalls.json <---> new: stable/2015-07-01/authorization-RoleAssignmentsCalls.json
- original: stable/2015-07-01/authorization-RoleDefinitionsCalls.json <---> new: stable/2015-07-01/authorization-RoleDefinitionsCalls.json

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L229:3 Old: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L217:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed? New: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L229:3 Old: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L217:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L229:3 Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L225:3
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json#L59:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L99:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L149:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L201:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L204:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L259:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L305:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 340 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentSchedule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleInstanceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleInstanceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleInstance' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"authorization/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"The schema 'RoleAssignmentScheduleInstanceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-09T00:09:43Z

Swagger Generation Artifacts

️🔄 azure-sdk-for-net inProgress [Detail]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️authorization/mgmt/2015-07-01/authorization [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f0a0a9f. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment

️✔️authorization [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN
cmderr	[resource-manager] Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-authorization [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignment has a new parameter created_by
info	[Changelog]   - Model RoleAssignment has a new parameter created_on
info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
info	[Changelog]   - Added operation group AccessReviewInstanceOperations
info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group AccessReviewInstancesOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
info	[Changelog]   - Added operation group Operations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md

️✔️@azure/arm-authorization [View full logs] [Release SDK Changes]

azure-arm-authorization-8.3.3.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 177ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-21 21:49:11 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-02-21 21:49:11 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-21 21:49:11 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-authorization-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12909/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-09T00:12:45Z

Hi @jdhms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

jdhms · 2021-02-09T00:43:37Z

Hi @allenjzhang,

This PR fixes some semantic errors in previous preview versions, which will enable us to fix further s360 issues. The issues were with swagger only:

Update existing versions to use the common parameters for compatibility when fixing subsequent s360 issues
Provide unique names for examples per validation errors
Add required and default responses

allenjzhang · 2021-02-11T07:52:05Z

/azp run SDK azure-sdk-for-net

azure-pipelines · 2021-02-11T07:52:10Z

No pipelines are associated with this pull request.

allenjzhang · 2021-02-11T07:55:12Z

/azp run

azure-pipelines · 2021-02-11T07:55:26Z

Azure Pipelines successfully started running 2 pipeline(s).

Azure#12909)

fix semantic and example errors in previous versions for compatability

2a6b307

jdhms requested a review from stankovski as a code owner February 9, 2021 00:09

openapi-assignment-bot bot assigned allenjzhang Feb 9, 2021

openapi-workflow-bot bot added the FixS360 label Feb 9, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Feb 9, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 9, 2021

allenjzhang approved these changes Feb 11, 2021

View reviewed changes

allenjzhang added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Feb 21, 2021

allenjzhang merged commit f0a0a9f into Azure:master Feb 21, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

fix semantic and example errors in previous versions for compatability (

986543b

Azure#12909)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix semantic and example errors in previous versions for compatability #12909

fix semantic and example errors in previous versions for compatability #12909

jdhms commented Feb 9, 2021

openapi-workflow-bot bot commented Feb 9, 2021

openapi-workflow-bot bot commented Feb 9, 2021

openapi-pipeline-app bot commented Feb 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 9, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 9, 2021

jdhms commented Feb 9, 2021

allenjzhang commented Feb 11, 2021

azure-pipelines bot commented Feb 11, 2021

allenjzhang commented Feb 11, 2021

azure-pipelines bot commented Feb 11, 2021

fix semantic and example errors in previous versions for compatability #12909

fix semantic and example errors in previous versions for compatability #12909

Conversation

jdhms commented Feb 9, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 9, 2021

openapi-workflow-bot bot commented Feb 9, 2021

openapi-pipeline-app bot commented Feb 9, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 9, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 9, 2021

jdhms commented Feb 9, 2021

allenjzhang commented Feb 11, 2021

azure-pipelines bot commented Feb 11, 2021

allenjzhang commented Feb 11, 2021

azure-pipelines bot commented Feb 11, 2021

openapi-pipeline-app bot commented Feb 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 9, 2021 •

edited

Loading