-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy of [Microsoft.ApiManagement][2020-06-01-preview] Gateway certificate authorities #12890
Conversation
Hi, @solankisamir Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimgateways.json#L1033:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimgateways.json#L1095:5 |
️⚠️
LintDiff: 3 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
The child tracked resource, 'certificateAuthorities' with immediate parent 'GatewayContract', must have a list by immediate parent operation. Location: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L37 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isTrusted Location: Microsoft.ApiManagement/preview/2020-06-01-preview/definitions.json#L6063 |
|
'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.ApiManagement/preview/2020-06-01-preview/apimgateways.json#L1224 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
[Staging] SDK Track2 Validation inProgress [Detail]
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi, @solankisamir your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @markcowl |
NewApiVersionRequired reason: |
The PR is copy of PR #12559 , based on latest master branch. I diff change in first commit and PR #12559 , diff part is from latest master branch, such as PR 8b17a79#diff-709e8fdccfcee1ceb40d90dbee5c8f7677dc0791187c8728053f879a4245d02d, e0441f6#diff-709e8fdccfcee1ceb40d90dbee5c8f7677dc0791187c8728053f879a4245d02d. I'll add labels from #12559 back to this PR. |
…cate authorities (Azure#12890)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This is a copy of #12559 with CI fixes, as discussed with @yungezz
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.