[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 #12876

ionuttulai · 2021-02-05T16:43:00Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…06-01 to version 2016-01-01

openapi-workflow-bot · 2021-02-05T16:43:03Z

Hi, @ionuttulai Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-05T16:43:03Z

Swagger Validation Report

️⌛BreakingChange pending [Detail]

️⌛LintDiff pending [Detail]

️⌛Avocado pending [Detail]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️⌛SemanticValidation pending [Detail]

️⌛[Staging] Cross Version BreakingChange (Base on preview version) pending [Detail]

️⌛[Staging] Cross Version BreakingChange (Base on stable version) pending [Detail]

️⌛CredScan pending [Detail]

️⌛[Staging] SDK Track2 Validation pending [Detail]

️⌛[Staging] PrettierCheck pending [Detail]

️⌛[Staging] SpellCheck pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-05T16:43:04Z

Swagger Generation Artifacts

️🔄[Staging] ApiDocPreview inProgress [Detail]

️🔄 azure-resource-manager-schemas inProgress [Detail]

️🔄 azure-sdk-for-go inProgress [Detail]

️🔄 azure-sdk-for-js inProgress [Detail]

️🔄 azure-sdk-for-java inProgress [Detail]

️⌛ azure-sdk-for-python pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-05T16:47:30Z

Hi @ionuttulai, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

ionuttulai · 2021-02-05T17:07:13Z

/azp run unifiedPipeline

openapi-workflow-bot · 2021-02-09T00:56:06Z

Hi, @ionuttulai your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @markcowl

ionuttulai · 2021-02-09T01:03:49Z

This PR is adding missing api version 2016-01-01 for swagger completeness.

varunkumta · 2021-02-09T05:30:42Z

...ification/azurestack/resource-manager/Microsoft.AzureStack/stable/2016-01-01/AzureStack.json

+    }
+  },
+  "definitions": {
+    "Resource": {


Resource [](start = 5, length = 8)

you don't need to define your own - you can reuse from common-types/resource-management/v2/types.json

and pretty much everything else in this file

In reply to: 572604325 [](ancestors = 572604325)

I removed the generic types and referenced the ones in common-types folder.

ionuttulai · 2021-02-11T01:59:39Z

@varunkumta we are taking care of s360 alerts but not by changes to an existing API version, but by adding a missing one for swagger completeness - that's why I initially had it marked as "new API version" .

Here's a link to the s360 issues we are addressing with this PR

https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=AssignedTo:All~KPI:6dc4e485-2d1b-449c-a224-30b183391437~SLA:1~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=avishwan_team;maximpop_team&tile=S360_ServiceId:9537bbc3-8945-4a80-a398-9e894170cc28~_loc:__key__UnifiedPlatform__6dc4e485-2d1b-449c-a224-30b183391437&global=4:9537bbc3-8945-4a80-a398-9e894170cc28

Cc: @markcowl for awareness

varunkumta · 2021-02-11T02:01:50Z

@varunkumta we are taking care of s360 alerts but not by changes to an existing API version, but by adding a missing one for swagger completeness - that's why I initially had it marked as "new API version" .

Here's a link to the s360 issues we are addressing with this PR

https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=AssignedTo:All~KPI:6dc4e485-2d1b-449c-a224-30b183391437~SLA:1~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=avishwan_team;maximpop_team&tile=S360_ServiceId:9537bbc3-8945-4a80-a398-9e894170cc28~_loc:__key__UnifiedPlatform__6dc4e485-2d1b-449c-a224-30b183391437&global=4:9537bbc3-8945-4a80-a398-9e894170cc28

Cc: @markcowl for awareness

yes, pretty sure here existing means 'already publicly available' not 'existing in swagger' - as I see a lot of traffic in ARM for your RP and this apiversion

ionuttulai · 2021-02-11T02:03:33Z

@varunkumta we are taking care of s360 alerts but not by changes to an existing API version, but by adding a missing one for swagger completeness - that's why I initially had it marked as "new API version" .
Here's a link to the s360 issues we are addressing with this PR
https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=AssignedTo:All~KPI:6dc4e485-2d1b-449c-a224-30b183391437~SLA:1~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=avishwan_team;maximpop_team&tile=S360_ServiceId:9537bbc3-8945-4a80-a398-9e894170cc28~_loc:__key__UnifiedPlatform__6dc4e485-2d1b-449c-a224-30b183391437&global=4:9537bbc3-8945-4a80-a398-9e894170cc28
Cc: @markcowl for awareness

yes, pretty sure here existing means 'already publicly available' not 'existing in swagger' - as I see a lot of traffic in ARM for your RP and this apiversion

Sounds good. Thanks for the review!

markcowl · 2021-02-11T04:11:49Z

@ionuttulai We cna merge when the ci jobs have passed

ionuttulai · 2021-02-11T18:48:30Z

@ionuttulai We cna merge when the ci jobs have passed

The pipeline has been running for almost 24 hours now. Is that expected, or is there a way to re-queue it?

ionuttulai · 2021-02-11T21:34:06Z

@ionuttulai We cna merge when the ci jobs have passed

@markcowl It looks like the pipeline ran successfully but the results were not reported back to the PR.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=730156&view=results

ionuttulai · 2021-02-16T17:47:02Z

@markcowl is there anything we can do to re-run the pipeline for the mandatory checks? It looks like it ran successfully but the results never made it back to the PR.

markcowl · 2021-02-17T00:10:49Z

@ionuttulai Yes, we are looking at why the notifications did not make it back here

markcowl · 2021-02-17T00:11:00Z

/azp run

azure-pipelines · 2021-02-17T00:11:16Z

Azure Pipelines successfully started running 2 pipeline(s).

markcowl · 2021-02-17T00:24:13Z

/azp run

azure-pipelines · 2021-02-17T00:24:26Z

Azure Pipelines successfully started running 2 pipeline(s).

markcowl · 2021-02-17T19:57:43Z

very latest (passing) run is here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=736836&view=results

…n stable/2016-01-01 (Azure#12876) * Adds base for updating Microsoft.AzureStack from version stable/2017-06-01 to version 2016-01-01 * Updates readme * Updates API version in new specs and examples * missing changes * readme changes * added operations path * added missing examples * switched back to old default package version * Removed local ref to generic types

ionuttulai and others added 5 commits February 5, 2021 07:58

Adds base for updating Microsoft.AzureStack from version stable/2017-…

97c2600

…06-01 to version 2016-01-01

Updates readme

242307d

Updates API version in new specs and examples

097fe1c

missing changes

906de13

readme changes

e32eb33

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 5, 2021

openapi-sdkautomation bot mentioned this pull request Feb 5, 2021

[AutoPR @azure/arm-azurestack] [Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 AzureSDKAutomation/azure-sdk-for-js#3557

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 5, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 5, 2021

added operations path

17cf20c

openapi-sdkautomation bot mentioned this pull request Feb 5, 2021

[AutoPR azure-resourcemanager-azurestack] [Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 AzureSDKAutomation/azure-sdk-for-java#7428

Closed

added missing examples

5428a23

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 5, 2021

merged from upstream master

74e777e

ionuttulai marked this pull request as ready for review February 8, 2021 23:51

openapi-assignment-bot bot assigned markcowl Feb 8, 2021

switched back to old default package version

2dfff6b

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 9, 2021

varunkumta reviewed Feb 9, 2021

View reviewed changes

Removed local ref to generic types

ef8ee95

openapi-pipeline-app bot removed the CI-BreakingChange-Python label Feb 11, 2021

varunkumta removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 11, 2021

markcowl approved these changes Feb 11, 2021

View reviewed changes

markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 11, 2021

markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-Avocado Approved-LintDiff Approved-ModelValidation Approved-SemanticValidation labels Feb 16, 2021

markcowl closed this Feb 17, 2021

markcowl reopened this Feb 17, 2021

allenjzhang merged commit 6ecbac8 into Azure:master Feb 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 #12876

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 #12876

ionuttulai commented Feb 5, 2021 •

edited by varunkumta

Loading

openapi-workflow-bot bot commented Feb 5, 2021

openapi-pipeline-app bot commented Feb 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 5, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 5, 2021

ionuttulai commented Feb 5, 2021

openapi-workflow-bot bot commented Feb 9, 2021

ionuttulai commented Feb 9, 2021

varunkumta Feb 9, 2021

varunkumta Feb 9, 2021

ionuttulai Feb 10, 2021

ionuttulai commented Feb 11, 2021

varunkumta commented Feb 11, 2021 •

edited

Loading

ionuttulai commented Feb 11, 2021

markcowl commented Feb 11, 2021

ionuttulai commented Feb 11, 2021

ionuttulai commented Feb 11, 2021

ionuttulai commented Feb 16, 2021

markcowl commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 #12876

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2016-01-01 #12876

Conversation

ionuttulai commented Feb 5, 2021 • edited by varunkumta Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 5, 2021

openapi-pipeline-app bot commented Feb 5, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 5, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 5, 2021

ionuttulai commented Feb 5, 2021

openapi-workflow-bot bot commented Feb 9, 2021

ionuttulai commented Feb 9, 2021

varunkumta Feb 9, 2021

Choose a reason for hiding this comment

varunkumta Feb 9, 2021

Choose a reason for hiding this comment

ionuttulai Feb 10, 2021

Choose a reason for hiding this comment

ionuttulai commented Feb 11, 2021

varunkumta commented Feb 11, 2021 • edited Loading

ionuttulai commented Feb 11, 2021

markcowl commented Feb 11, 2021

ionuttulai commented Feb 11, 2021

ionuttulai commented Feb 11, 2021

ionuttulai commented Feb 16, 2021

markcowl commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

markcowl commented Feb 17, 2021

ionuttulai commented Feb 5, 2021 •

edited by varunkumta

Loading

openapi-pipeline-app bot commented Feb 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 5, 2021 •

edited

Loading

varunkumta commented Feb 11, 2021 •

edited

Loading