-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the Default Error Response for 2020-06-01-preview APIs #12800
Conversation
Hi, @nichatur Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Hi @nichatur, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @nichatur, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
…oudErrorBody" This reverts commit a955700.
Hi @nichatur for SDK Track2 validation issues #12800 (comment) its recommended to fix otherwise this may block future SDK track2 generation, here is the doc https://github.com/Azure/autorest/blob/master/docs/openapi/prechecker.md And for ApiDocPreview failure you can ignore this as current this task doesn't support same operation id prefix SqlResources across different swagger files. |
/azp run |
…12800) * Fixing the Default Error Response for 2020-06-01-preview APIs * Removing refs to ErrorResponse and removing new props from CloudErrorBody * Revert "Removing refs to ErrorResponse and removing new props from CloudErrorBody" This reverts commit a955700. * Adding ErrorResponse back to avoid breaking change * Removing CloudErrorBody * Making change as minimal as possible * Trigger Build * Adding model duplication leniency * Lenient Dedup
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Fixes Issue https://github.com/Azure/azure-rest-api-specs/issues/12820 under which the error message does not propagate correctly for preview APIs under 2020-06-01-preview. This is fixed by leveraging Microsoft.Azure.Rest.CloudError instead of creating a new model for DefaultErrorResponse. This is not a breaking change.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.