Adklinge/add is legacy log analytics rule #12747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Error contract to fit the real structure
Removed readonly properties from example parameters
Added property "displayName" to the structure
Added missing enum values to ConditionalOperator property
Aligned RP name to pascal format
|
Hi, @adklinge Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/preview/2020-05-01-preview/scheduledQueryRule_API.json#L337 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L593 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2019-06 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
This was referenced Jan 31, 2021
…gacyLogAnalyticsRule
|
Hi @kairu-ms (again :)) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
approved these changes
Feb 2, 2021
|
Please fill the |
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details. |
done. I marked this PR as s360 violation fix to this item : We changed the property 'DasRule' into 'isLegacyLogAnalyticsRule' in our service, and now adjusting the swagger accordingly. |
kairu-ms
approved these changes
Feb 3, 2021
This was referenced Feb 3, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Update scheduledQueryRule_API.json Fixed Error contract to fit the real structure * Update createOrUpdateScheduledQueryRules.json Removed readonly properties from example parameters * Update scheduledQueryRule_API.json Added property "displayName" to the structure * Fix to item ; https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=A596EA9C-C8E9-4A72-90FE-4689DFCBA3F6 Fix to item ; https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=A596EA9C-C8E9-4A72-90FE-4689DFCBA3F6 * added display name to the new API version * Fixed descriptions * Added OverrideQueryTimeRange to Swagger on new API version * returned enabled property back to bool * Update scheduledQueryRule_API.json Added missing enum values to ConditionalOperator property * Update scheduledQueryRule_API.json Aligned RP name to pascal format * revert lindent correvction to avoid breaking chnage * run prettier and fixed SubscriptionIdParameter * revert subscripton id to the former description * aligned diagnosticSettings with master * removed locaiton from example * returned location to example * supress false alaram OBJECT_ADDITIONAL_PROPERTIES error * fix suppression * fix merge conflict * removed where clause * added properties isLegacyLogAnalyticsRule, createdWithApiVersion to both api versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.