[Hub Generated] Review request for Microsoft.AzureStack to add version preview/2020-06-01-preview #12709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ionuttulai Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L186 |
|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/CustomerSubscription.json#L208 |
|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L479 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns a list of all linked subscriptions. New: Microsoft.AzureStack/preview/2020-06-01-preview/LinkedSubscription.json#L62 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns a list of products. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L20 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns the specified product. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L65 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 23 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2017-06-01/AzureStack.json <---> new: preview/2020-06-01-preview/AzureStack.json
- original: stable/2017-06-01/CustomerSubscription.json <---> new: preview/2020-06-01-preview/CustomerSubscription.json
- original: stable/2017-06-01/Product.json <---> new: preview/2020-06-01-preview/Product.json
- original: stable/2017-06-01/Registration.json <---> new: preview/2020-06-01-preview/Registration.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
This PR is addressing the s360 swagger completeness issues by adding the 2020-06-01-preview version. |
xiaoxuqi-ms
added
the
WaitForARMFeedback
|
@ionuttulai , could you please help to provide the link to S360 items? |
|
There's an offline thread about adding exceptions for s360 items on resources nested after /linkedSubscriptions/{name}. This PR covers the tracked linkedSubscriptions resource type. |
jorgecotillo
reviewed
Feb 3, 2021
| "$ref": "#/definitions/LinkedSubscription" | ||
| } | ||
| }, | ||
| "201": { |
There was a problem hiding this comment.
"201" [](start = 10, length = 5)
Just to double check, this is meant to be a sync operation right?
There was a problem hiding this comment.
yes, it's a sync operation
jorgecotillo
added
ARMSignedOff
|
Breaking changes for go are introduced by previous PRs. |
|
@msyyc could you help to have a look at this PR since it has CI-breakingchange-python |
|
For python ,the PR is ok |
xiaoxuqi-ms
approved these changes
Feb 5, 2021
|
@xiaoxuqi-ms I think this is ready to be merged |
This was referenced Feb 6, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…n preview/2020-06-01-preview (Azure#12709) * Adds base for updating Microsoft.AzureStack from version stable/2017-06-01 to version 2020-06-01-preview * Updates readme * Updates API version in new specs and examples * initial commit for v 2020-06-01-preview * adding missing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.