Rollback SQL DB ImportExport.json in 2020-02-02-preview #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/import' removed or restructured? Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L602:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/import' removed or restructured? Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L660:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/export' removed or restructured? Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L715:5 |
|
The new version is missing a definition that was found in the old version. Was 'ImportExistingDatabaseDefinition' removed or renamed? New: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L645:3 Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L816:3 |
|
The new version is missing a definition that was found in the old version. Was 'NetworkIsolationSettings' removed or renamed? New: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L645:3 Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L816:3 |
|
The new version is missing a definition that was found in the old version. Was 'ImportNewDatabaseDefinition' removed or renamed? New: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L645:3 Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L816:3 |
|
The new version is missing a definition that was found in the old version. Was 'ExportDatabaseDefinition' removed or renamed? New: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L645:3 Old: Microsoft.Sql/preview/2020-02-02-preview/Databases.json#L816:3 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
bcham
approved these changes
Jan 13, 2021
|
Hi @ericshape, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 13, 2021
|
all the breaking changes are expected. Please refer to the PR description for detail. |
…specs into rollback_importexport_20200202
ericshape
commented
Jan 15, 2021
| "ImportExport" | ||
| ], | ||
| "description": "Imports a bacpac into a new database.", | ||
| "operationId": "ImportExport_Import", |
There was a problem hiding this comment.
the op ids in this json file has matched the .NET SDK: https://github.com/Azure/azure-sdk-for-net/pull/17724/files#diff-25af10433739ea75034af25610b773bd503f8f016d661a8412b70207a003eeb2
"operationId": "Databases_Export"
"operationId": "ImportExport_Import"
"operationId": "Servers_ImportDatabase",
At the same time, this PR has been rebased with the latest master branch.
Thus, with this PR in API Spec repo, there will be no any breaking changes for SDK.
@hotsnr @akning-ms can you help review and merge this PR once v4 python SDK is released? thanks!
There was a problem hiding this comment.
I re-generated .NET SDK from this change and can confirm that it removes breaking change - Azure/azure-sdk-for-net#17724
hotsnr
approved these changes
Jan 15, 2021
…specs into rollback_importexport_20200202
allenjzhang
added
the
Approved-BreakingChange
|
Per Roman. This is a rollback of an earlier breaking change. |
This was referenced Jan 26, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback SQL DB ImportExport.json in 2020-02-02-preview to address the breaking change.
Once #12293 merged, I will rebase this PR with the latest master.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.