Swagger changes for Stable version(2020-09-01) for Microsoft.DataBoxEdge #12353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @pvsraviteja Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'addons' with immediate parent 'Role', must have a list by immediate parent operation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L3783 |
|
| 'state' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L5155 |
|
| 'registrationDate' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L5169 |
|
| 'subscriptionId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L5172 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L5175 |
|
| 'SubscriptionProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L7920 |
|
| 'tenantId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L7923 |
|
| 'locationPlacementId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L7926 |
|
| 'quotaId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L7929 |
|
| 'serializedDetails' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L7932 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2020-09-01-preview/databoxedge.json <---> new: stable/2020-09-01/databoxedge.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 16 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2019-08-01/databoxedge.json <---> new: stable/2020-09-01/databoxedge.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @pvsraviteja your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @yungezz |
This was referenced Jan 10, 2021
This was referenced Jan 10, 2021
|
wait for ARM feedback. hi @msyyc, could you pls check impact to Python SDK? thanks |
We don't have any end customers using python SDK. So, we should be ok with this. |
It's ok for python |
|
In future, please commit unchanged files first so diffs against base are easy. |
j5lim
requested changes
Jan 11, 2021
| "description": "Gets or sets base64 encoded certificate raw data,\r\nthis is the public part needed to be uploaded to cert vault", | ||
| "type": "string" | ||
| }, | ||
| "privateKey": { |
There was a problem hiding this comment.
Please annotate with x-ms-secret.
| } | ||
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, |
There was a problem hiding this comment.
Doesn't the API return 'Location' header to track async DELETE?
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/Addendum.md#delete-resource-asynchronously
There was a problem hiding this comment.
Yes it returns location header to track the requests
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2020-09-01", |
There was a problem hiding this comment.
Looks like it makes the same changes as in #12350. Please apply the same comments left for the preview version.
There was a problem hiding this comment.
Changes are pushed.
j5lim
added
the
ARMChangesRequested
pvsraviteja
force-pushed
the
developer/rapvs/Stableversion
branch
from
9a81b61 to
083a883
Compare
j5lim
added
ARMSignedOff
yungezz
approved these changes
Jan 13, 2021
|
hi @pvsraviteja is service change deployed to Prod already? If yes, will merge the PR. |
|
hi @pvsraviteja could you pls rebase? there's conflict |
Sure let me do that |
Yes they are deployed to prod and ready |
pvsraviteja
force-pushed
the
developer/rapvs/Stableversion
branch
from
9819804 to
b3795bf
Compare
This was referenced Jan 13, 2021
[ReleasePR databoxedge] add con figuration for databoxedge
Azure/azure-resource-manager-schemas#1335
Merged
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jan 14, 2021
…) for Microsoft.DataBoxEdge (#1335) Create to sync Azure/azure-rest-api-specs#12353 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/databoxedge?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.