Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/move XML name mapping when ref is provided #12341

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Remove/move XML name mapping when ref is provided #12341

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99d4148
testing
tasherif-msft Jan 8, 2021
e804a0c
removed more fileshare ignored xml names
tasherif-msft Jan 8, 2021
b7008ed
fixed silly indents
tasherif-msft Jan 11, 2021
38b5166
fixed silly indents
tasherif-msft Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4610,10 +4610,7 @@
"properties": {
"SmbSettings": {
"description": "Settings for SMB protocol.",
"$ref": "#/definitions/SmbSettings",
"xml": {
"name": "SMB"
}
"$ref": "#/definitions/SmbSettings"
}
}
},
Expand Down Expand Up @@ -4785,6 +4782,9 @@
"SmbSettings": {
"description": "Settings for SMB protocol.",
"type": "object",
"xml": {
tasherif-msft marked this conversation as resolved.
Show resolved Hide resolved
"name": "SMB"
},
"properties": {
"Multichannel": {
"description": "Settings for SMB Multichannel.",
Expand Down
16 changes: 8 additions & 8 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5336,13 +5336,13 @@
"ShareProtocolSettings": {
"description": "Protocol settings",
"type": "object",
"xml": {
tasherif-msft marked this conversation as resolved.
Show resolved Hide resolved
"name": "ProtocolSettings"
},
"properties": {
"Smb": {
"description": "Settings for SMB protocol.",
"$ref": "#/definitions/ShareSmbSettings",
"xml": {
"name": "SMB"
}
"$ref": "#/definitions/ShareSmbSettings"
}
}
},
Expand Down Expand Up @@ -5530,6 +5530,9 @@
"ShareSmbSettings": {
"description": "Settings for SMB protocol.",
"type": "object",
"xml": {
tasherif-msft marked this conversation as resolved.
Show resolved Hide resolved
"name": "SMB"
},
"properties": {
"Multichannel": {
"description": "Settings for SMB Multichannel.",
Expand Down Expand Up @@ -5561,10 +5564,7 @@
},
"Protocol": {
"description": "Protocol settings",
"$ref":"#/definitions/ShareProtocolSettings",
"xml": {
"name": "ProtocolSettings"
}
"$ref":"#/definitions/ShareProtocolSettings"
}
}
},
Expand Down
16 changes: 8 additions & 8 deletions specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5364,13 +5364,13 @@
"ShareProtocolSettings": {
"description": "Protocol settings",
"type": "object",
"xml": {
"name": "ProtocolSettings"
},
"properties": {
"Smb": {
"description": "Settings for SMB protocol.",
"$ref": "#/definitions/ShareSmbSettings",
"xml": {
"name": "SMB"
}
"$ref": "#/definitions/ShareSmbSettings"
}
}
},
Expand Down Expand Up @@ -5564,6 +5564,9 @@
"ShareSmbSettings": {
"description": "Settings for SMB protocol.",
"type": "object",
"xml": {
"name": "SMB"
},
"properties": {
"Multichannel": {
"description": "Settings for SMB Multichannel.",
Expand Down Expand Up @@ -5595,10 +5598,7 @@
},
"Protocol": {
"description": "Protocol settings",
"$ref":"#/definitions/ShareProtocolSettings",
"xml": {
"name": "ProtocolSettings"
}
"$ref":"#/definitions/ShareProtocolSettings"
}
}
},
Expand Down