Azure DNS s360 fixes #12336

vladrai · 2021-01-08T16:38:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-08T16:38:41Z

Hi, @vladrai Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-01-08T16:38:43Z

Swagger Validation Report

️❌BreakingChange: 5 Errors, 5 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2015-05-04-preview/dns.json <---> new: preview/2015-05-04-preview/dns.json
- original: stable/2016-04-01/dns.json <---> new: stable/2016-04-01/dns.json
- original: stable/2017-09-01/dns.json <---> new: stable/2017-09-01/dns.json
- original: stable/2017-10-01/dns.json <---> new: stable/2017-10-01/dns.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '201'. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L121:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L195:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L260:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'tags' renamed or removed? New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L821:7 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L801:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'location' renamed or removed? New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L821:7 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L801:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L102:13 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L102:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L117:13 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L117:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L256:13 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L247:13
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L854:11 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L822:11
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.Network/preview/2015-05-04-preview/dns.json#L820:5 Old: Microsoft.Network/preview/2015-05-04-preview/dns.json#L800:5

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-08T16:38:44Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 866a7d0. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/dns/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md

️✔️@azure/arm-dns [View full logs] [Release SDK Changes]

azure-arm-dns-4.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/dnsManagementClient.js → ./dist/arm-dns.js...
cmderr	[npmPack] created ./dist/arm-dns.js in 283ms

️✔️@azure/arm-privatedns [View full logs] [Release SDK Changes]

azure-arm-privatedns-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/privateDnsManagementClient.js → ./dist/arm-privatedns.js...
cmderr	[npmPack] created ./dist/arm-privatedns.js in 282ms

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 866a7d0. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-dns [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Zone has a new parameter max_number_of_records_per_record_set

️✔️azure-mgmt-privatedns [View full logs] [Release SDK Changes]
- azure_mgmt_privatedns-0.1.0-py2.py3-none-any.whl
- azure-mgmt-privatedns-0.1.0.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 866a7d0. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-27 00:39:39 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-dns-generated"
cmderr	[generate.py] 2021-01-27 00:39:39 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-27 00:39:39 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/dns/azure-resourcemanager-dns-generated --java.namespace=com.azure.resourcemanager.dns.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/dns/resource-manager/readme.md
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [POM][Skip] pom already has module azure-resourcemanager-dns-generated
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-27 00:40:22 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-dns-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-27 00:43:04 DEBUG Got artifact_id: azure-resourcemanager-dns-generated
cmderr	[Inst] 2021-01-27 00:43:04 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-27 00:43:04 DEBUG Got artifact: azure-resourcemanager-dns-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-27 00:43:04 DEBUG Got artifact: azure-resourcemanager-dns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 00:43:04 DEBUG Match jar package: azure-resourcemanager-dns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 00:43:04 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12336/azure-sdk-for-java/azure-resourcemanager-dns-generated/azure-resourcemanager-dns-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-dns-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-dns-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-dns-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️✔️azure-resourcemanager-privatedns-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-27 00:44:49 DEBUG Got artifact_id: azure-resourcemanager-privatedns-generated
cmderr	[Inst] 2021-01-27 00:44:49 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-27 00:44:49 DEBUG Got artifact: azure-resourcemanager-privatedns-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-27 00:44:49 DEBUG Got artifact: azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 00:44:49 DEBUG Match jar package: azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-27 00:44:49 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12336/azure-sdk-for-java/azure-resourcemanager-privatedns-generated/azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-privatedns-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-privatedns-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 866a7d0. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/dns/resource-manager/readme.md
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md

️✔️dns [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN [email protected] No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager] npm ERR! code ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 87
cmderr	[resource-manager] npm ERR! [email protected] test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 87
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the [email protected] test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager] npm ERR! A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-27T00_39_49_634Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 87,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3151,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 87
cmderr	[resource-manager]  [email protected] test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 87
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the [email protected] test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-27T00_40_39_481Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 87,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3540,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 866a7d0. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️dns/mgmt/2018-05-01/dns [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️dns/mgmt/2017-10-01/dns [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Public`
info	[Changelog] - New const `Private`
info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
info	[Changelog]

️✔️dns/mgmt/2017-09-01/dns [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Public`
info	[Changelog] - New const `Private`
info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
info	[Changelog]

️✔️dns/mgmt/2016-04-01/dns [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Private`
info	[Changelog] - New const `Public`
info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
info	[Changelog]

️✔️preview/dns/mgmt/2018-03-01-preview/dns [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/dns/mgmt/2015-05-04-preview/dns [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 18 items here, please refer to log for details.

info	[Changelog]
info	[Changelog] - Field `Location` of struct `RecordSet` has been removed
info	[Changelog] - Field `Properties` of struct `RecordSet` has been removed
info	[Changelog] - Field `Tags` of struct `RecordSet` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*RecordSet.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `RecordSetProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `CloudError`
info	[Changelog] - New struct `CloudErrorBody`
info	[Changelog] - New anonymous field `*RecordSetProperties` in struct `RecordSet`
info	[Changelog] - New field `Fqdn` in struct `RecordSetProperties`
info	[Changelog] - New field `MaxNumberOfRecordsPerRecordSet` in struct `ZoneProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 10 additive change(s).
info	[Changelog]

️✔️privatedns/mgmt/2018-09-01/privatedns [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 866a7d0. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
warn		specification/dns/resource-manager/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/privatedns/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.PrivateDns [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.PrivateDns.1.0.0.nupkg
- Microsoft.Azure.Management.PrivateDns.1.0.0.snupkg

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-08T16:40:28Z

Hi @vladrai, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-08T16:41:38Z

Hi @vladrai, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

vladrai · 2021-01-08T18:10:02Z

Breaking changes explanation:

AddingResponseCode changes. This is to mitigate s360 issue because of existing behavior (these codes are returned currently but not described in swagger).
RemoveProperty and DifferentAllOf. DNS recordset resource was created as tracked resource initially, but was changed to untracked later. Swagger was never updated for preview version.

specification/dns/resource-manager/Microsoft.Network/preview/2015-05-04-preview/dns.json

specification/privatedns/resource-manager/Microsoft.Network/stable/2018-09-01/privatedns.json

This reverts commit 791a1dd.

chunyu3 · 2021-01-12T02:27:03Z

@vladrai please also need to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

vladrai · 2021-01-16T00:14:33Z

Breaking change review link: https://msazure.visualstudio.com/One/_workitems/edit/9143038

* Azure DNS s360 changes * Changes part 2 * Breaking change fix * Adding schema for 201 response * Revert "Breaking change fix" This reverts commit 791a1dd. * Adding new property and deprecating old one * Prettier + missed property * Reverting change. Will be fixed in service code

vladrai added 2 commits December 29, 2020 15:47

Azure DNS s360 changes

c3f6ce4

Changes part 2

5d46243

vladrai requested a review from nkindberg January 8, 2021 16:38

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 8, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 8, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 8, 2021

openapi-sdkautomation bot mentioned this pull request Jan 8, 2021

[AutoPR azure-resourcemanager-privatedns-generated] Azure DNS s360 fixes AzureSDKAutomation/azure-sdk-for-java#7139

Closed

Breaking change fix

791a1dd

nkindberg suggested changes Jan 8, 2021

View reviewed changes

specification/dns/resource-manager/Microsoft.Network/preview/2015-05-04-preview/dns.json Outdated Show resolved Hide resolved

specification/privatedns/resource-manager/Microsoft.Network/stable/2018-09-01/privatedns.json Outdated Show resolved Hide resolved

vladrai added 2 commits January 8, 2021 11:17

Adding schema for 201 response

b4bc9ae

Revert "Breaking change fix"

d5c4e0a

This reverts commit 791a1dd.

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 8, 2021

Adding new property and deprecating old one

b7e23c7

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-BreakingChange-Go labels Jan 8, 2021

openapi-pipeline-app bot added CI-BreakingChange-Go and removed CI-FixRequiredOnFailure labels Jan 8, 2021

vladrai marked this pull request as ready for review January 11, 2021 22:39

openapi-assignment-bot bot assigned chunyu3 Jan 11, 2021

chunyu3 removed the BreakingChangeReviewRequired label Jan 12, 2021

chunyu3 added the BreakingChangeReviewRequired label Jan 12, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 25, 2021

JeffreyRichter approved these changes Jan 25, 2021

View reviewed changes

nkindberg approved these changes Jan 25, 2021

View reviewed changes

chunyu3 merged commit 866a7d0 into Azure:master Jan 27, 2021

vladrai mentioned this pull request Feb 17, 2021

Azure DNS latest swagger generated changes Azure/azure-sdk-for-net#18815

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure DNS s360 fixes #12336

Azure DNS s360 fixes #12336

vladrai commented Jan 8, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 8, 2021

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 8, 2021

openapi-workflow-bot bot commented Jan 8, 2021

vladrai commented Jan 8, 2021

chunyu3 commented Jan 12, 2021 •

edited

Loading

vladrai commented Jan 16, 2021

Azure DNS s360 fixes #12336

Azure DNS s360 fixes #12336

Conversation

vladrai commented Jan 8, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 8, 2021

openapi-pipeline-app bot commented Jan 8, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 8, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 8, 2021

openapi-workflow-bot bot commented Jan 8, 2021

vladrai commented Jan 8, 2021

chunyu3 commented Jan 12, 2021 • edited Loading

vladrai commented Jan 16, 2021

vladrai commented Jan 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

chunyu3 commented Jan 12, 2021 •

edited

Loading