[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-09-01 #12314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @yashmuel Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'incidents' with immediate parent 'AlertRuleResource', must have a list by immediate parent operation. New: Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json#L108 |
|
| The child tracked resource, 'status' with immediate parent 'MetricAlertResource', must have a list by immediate parent operation. New: Microsoft.Insights/stable/2018-09-01/metricBaselines_API.json#L108 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2019-06 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 13 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2019-03-01/metricBaselines_API.json <---> new: stable/2018-09-01/metricBaselines_API.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
Hi @yashmuel, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 7, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
@weidongxu-microsoft can you please help me merge this one as well? |
|
I was not following this PR. It appears that this PR have multiple property removed, which is a big breaking changes from a previous api-version. My suggestion is to follow up with assignee for standard review. |
Got it. @kairu-ms can you please help me with review and merge this? |
kairu-ms
reviewed
Jan 20, 2021
| "type": "string", | ||
| "description": "The resource type of the metric baseline resource." | ||
| }, | ||
| "metricName": { |
There was a problem hiding this comment.
For api version 2019-03-01, the property name is 'name'
There was a problem hiding this comment.
Please make sure you want to rename it.
Comment on lines
+212
to
+218
| "metadataValues": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/BaselineMetadata" | ||
| }, | ||
| "description": "The baseline metadata values." | ||
| } |
There was a problem hiding this comment.
Different from 2019-03-01, Please make sure you want to rename it.
There was a problem hiding this comment.
checked. i'm sure.
|
@kairu-ms i think our source code might help you review. |
|
@kairu-ms verified your comments. thanks! |
|
@asafst i think i didn't send you this one for review, please take a look. |
asafst
approved these changes
Jan 20, 2021
kairu-ms
approved these changes
Jan 21, 2021
This was referenced Jan 21, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…stable/2018-09-01 (Azure#12314) * copied metricBaselines from 2019 * Added 2018 api version for metricBaselines * Added example file of new api * fixed prettier * fixed api version * added object type * fixed api version and semantic error * added metricBaselines to readme * fixed prettier for 2019 version * removed metricBaselines 2018 from package * added back the reference to 2018 * removed reference * added reference * Trying to edit description * Trying to fix linting error * reverted description * changed description due to validation error * trying to reference to api version from types * added reference to 2018-09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.