aks: add allowNetworkPluginKubenet field to ManagedClusterPodIdentityProfile
#12309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowNetworkPluginKubenet New: Microsoft.ContainerService/stable/2021-02-01/managedClusters.json#L3337 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 28 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2018-08-01-preview/managedClusters.json <---> new: stable/2021-02-01/managedClusters.json
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-12-01/managedClusters.json <---> new: stable/2021-02-01/managedClusters.json
|
Hi, @bcho Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
This was referenced Jan 7, 2021
PhoenixHe-NV
reviewed
Jan 7, 2021
...erservice/resource-manager/Microsoft.ContainerService/stable/2021-02-01/managedClusters.json
Show resolved
Hide resolved
PhoenixHe-NV
added
the
Reviewed-ChangesRequested
bcho
added
the
NotReadyForReview
|
Hi @bcho, Your PR has some issues. Please fix the CI sequentially by following the order of
|
bcho
force-pushed
the
hbc/aks-pi-kubenet-consent
branch
from
18d2ccb to
d463c12
Compare
bcho
removed
the
NotReadyForReview
|
this pull request is ready to merge now, PTAL @PhoenixHe-msft @levimm |
PhoenixHe-NV
approved these changes
Jan 11, 2021
levimm
approved these changes
Jan 11, 2021
|
@PhoenixHe-msft could you help merge this pr? I think it's ready to merge now, thanks! |
PhoenixHe-NV
merged commit d0ce196
into
Azure:dev-containerservice-Microsoft.ContainerService-2021-02-01
PhoenixHe-NV
pushed a commit
that referenced
this pull request
Feb 25, 2021
* Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * aks: generate 2021-02-01 sdk (#12311) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example * AKS: add fqdnSubdomain for private cluster with custom private dns zone (#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <[email protected]> * add new disk choice (#12682) * AKS: Add Node Public IP Prefix support. (#12673) * Add azure portal fqdn (#12725) * add azure portal fqdn * add azure portal fqdn * fix prettier Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: tilnl <[email protected]>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
) * Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * aks: generate 2021-02-01 sdk (Azure#12311) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example * AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <[email protected]> * add new disk choice (Azure#12682) * AKS: Add Node Public IP Prefix support. (Azure#12673) * Add azure portal fqdn (Azure#12725) * add azure portal fqdn * add azure portal fqdn * fix prettier Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Jun Sun <[email protected]> Co-authored-by: tilnl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.