Pluaralize ComputePolicies operation group #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed during initial swagger review. This new group should by pluralized since it also contains an object called "ComputePolicy"
|
@amarzavery I do not believe this has resulted in anything being published yet, so this should not be a breaking change. I have not triggered any publish jobs and the AutoRestCI PRs triggered from the original change (#1182) are both still open, so we should be good to merge this and then publish from these changes. |
fearthecowboy
approved these changes
May 10, 2017
begoldsm
pushed a commit
to begoldsm/azure-sdk-for-net
that referenced
this pull request
May 10, 2017
This swagger update is from PR: Azure/azure-rest-api-specs#1214 * Rename ComputePolicy operation to ComputePolicies ComputePolicy was never published, so this is not a breaking change and it was caught as part of a sanity check prior to publishing, so there is no risk in this change.
8 tasks
shahabhijeet
pushed a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
May 11, 2017
This swagger update is from PR: Azure/azure-rest-api-specs#1214 * Rename ComputePolicy operation to ComputePolicies ComputePolicy was never published, so this is not a breaking change and it was caught as part of a sanity check prior to publishing, so there is no risk in this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed during initial swagger review. This new group should by
pluralized since it also contains an object called "ComputePolicy"
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger