[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 #12129

joseph-porter · 2020-12-15T19:30:50Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-12-15T19:30:54Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-11-01/containerInstance.json <---> new: stable/2020-11-01/containerInstance.json

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- containerinstance/resource-manager/readme.md tag:package-2020-11
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- containerinstance/resource-manager/readme.md tag:package-2020-11

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: timestamps New: Microsoft.ContainerInstance/stable/2020-11-01/containerInstance.json#L527

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-15T19:30:55Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 7a704e6. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-22 02:33:34 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-containerinstance-generated"
cmderr	[generate.py] 2021-01-22 02:33:34 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-22 02:33:34 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/containerinstance/azure-resourcemanager-containerinstance-generated --java.namespace=com.azure.resourcemanager.containerinstance.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [POM][Skip] pom already has module azure-resourcemanager-containerinstance-generated
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-22 02:34:08 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-containerinstance-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-22 02:36:14 DEBUG Got artifact_id: azure-resourcemanager-containerinstance-generated
cmderr	[Inst] 2021-01-22 02:36:14 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-22 02:36:14 DEBUG Got artifact: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-22 02:36:14 DEBUG Match jar package: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-22 02:36:14 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12129/azure-sdk-for-java/azure-resourcemanager-containerinstance-generated/azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-containerinstance-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a704e6. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md

️✔️containerinstance [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  [email protected] No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a704e6. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️containerinstance/mgmt/2019-12-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-10-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-09-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-06-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-04-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2018-02-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-12-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-10-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-08-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a704e6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerInstance [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerInstance.3.0.0.nupkg
- Microsoft.Azure.Management.ContainerInstance.3.0.0.snupkg

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a704e6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md

️✔️azure-mgmt-containerinstance [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-containerinstance
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-containerinstance
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.containerinstance
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.containerinstance
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.containerinstance
cmderr	[changelogReport] INFO:__main__:Report written to sdk/containerinstance/azure-mgmt-containerinstance/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-containerinstance on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.3.0', '0.3.1', '0.4.0', '1.0.0', '1.1.0', '1.2.0', '1.2.1', '1.3.0', '1.4.0', '1.4.1', '1.5.0', '2.0.0', '7.0.0b1', '7.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 2.0.0 of azure-mgmt-containerinstance in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.containerinstance
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.containerinstance
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.containerinstance
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/containerinstance/azure-mgmt-containerinstance/code_reports/2.0.0/report.json
cmdout	[Changelog] Size of delta 5.065% size of original (original: 27406 chars, delta: 1388 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model LogAnalytics has a new parameter workspace_resource_id
cmdout	[Changelog]   - Model ContainerHttpGet has a new parameter http_headers
cmdout	[Changelog]   - Added operation ContainersOperations.attach
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation ContainersOperations.list_logs has a new signature
warn	Breaking change found in changelog

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7a704e6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md

️✔️@azure/arm-containerinstance [View full logs] [Release SDK Changes]

azure-arm-containerinstance-6.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/containerInstanceManagementClient.js → ./dist/arm-containerinstance.js...
cmderr	[npmPack] created ./dist/arm-containerinstance.js in 286ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-12-15T21:39:10Z

Hi, @joseph-porter Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

ghost · 2021-01-03T16:00:42Z

Hi, @joseph-porter. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

joseph-porter · 2021-01-19T16:41:56Z

@fengzhou-msft Do you have an estimate of when this PR could be merged?

…osoft.ContainerInstance to add version stable/2020-11-01 (#1476) Create to sync Azure/azure-rest-api-specs#12129 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/containerinstance?expand=1)

… version stable/2020-11-01 (Azure#12129)

joseph-porter added 3 commits December 14, 2020 15:39

Added containerAttach, httpHeaders and timestamp flag

a1797dd

Fixed resourceGroupName

ba71776

Removing SDK warning

72c7e40

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 15, 2020

joseph-porter added 3 commits December 15, 2020 15:25

Fixed descriptions and added seperate AttachResponse

72f2f18

Updated descriptions

991c436

Spelling fix

f640ce8

joseph-porter marked this pull request as ready for review December 15, 2020 21:34

joseph-porter requested a review from novinc as a code owner December 15, 2020 21:34

openapi-assignment-bot bot assigned fengzhou-msft Dec 15, 2020

novinc approved these changes Dec 16, 2020

View reviewed changes

ghost added the no-recent-activity label Jan 3, 2021

joseph-porter removed the no-recent-activity label Jan 4, 2021

fengzhou-msft merged commit 7a704e6 into Azure:master Jan 22, 2021

joseph-porter mentioned this pull request Jul 16, 2021

Update containerinstance client to the 2021-03-01 api Azure/azure-sdk-for-net#22701

Merged

11 tasks

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

[Hub Generated] Review request for Microsoft.ContainerInstance to add…

85a5506

… version stable/2020-11-01 (Azure#12129)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 #12129

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 #12129

joseph-porter commented Dec 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 15, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 15, 2020

ghost commented Jan 3, 2021

joseph-porter commented Jan 19, 2021

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 #12129

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 #12129

Conversation

joseph-porter commented Dec 15, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Dec 15, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 15, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Dec 15, 2020

ghost commented Jan 3, 2021

joseph-porter commented Jan 19, 2021

joseph-porter commented Dec 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 15, 2020 •

edited

Loading