-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Sentinel Dynamics365 data connector preview #12123
Merged
erich-wang
merged 5 commits into
Azure:master
from
alfeldsh:AzureSentinelDynamics365Preview
Dec 18, 2020
Merged
Azure Sentinel Dynamics365 data connector preview #12123
erich-wang
merged 5 commits into
Azure:master
from
alfeldsh:AzureSentinelDynamics365Preview
Dec 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @alfeldsh Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: dynamics365CDSActivities Url: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L6065 JsonUrl: 2019-01-01-preview/examples/dataConnectors/GetDataConnectors.json |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
ghost
added
the
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
label
Dec 15, 2020
Thank you for your contribution alfeldsh! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
This was referenced Dec 15, 2020
@ArcturusZhang , could you please take a look at |
The breaking changes in go SDK are introduced by #11776 and it is fine to merge |
erich-wang
approved these changes
Dec 18, 2020
This was referenced Dec 18, 2020
Merged
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* added Dynamics365 data connector * added Dynamics365 check requirements * added Dynamics365 examples * changed data type name to camelCase * fixed property name
josuhazure
pushed a commit
to josuhazure/azure-rest-api-specs
that referenced
this pull request
Jan 6, 2021
* added Dynamics365 data connector * added Dynamics365 check requirements * added Dynamics365 examples * changed data type name to camelCase * fixed property name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-BreakingChange-Go
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.