Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger correctness fix #12101

Merged
merged 2 commits into from
Jan 5, 2021
Merged

swagger correctness fix #12101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4801ecf
swagger correctness fix
juniwang Dec 14, 2020
f929a96
update preview version too
juniwang Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...signalr/resource-manager/Microsoft.SignalRService/preview/2020-07-01-preview/signalr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,12 +1142,14 @@
"description": "Optional tier of this particular SKU. 'Standard' or 'Free'. \r\n\r\n`Basic` is deprecated, use `Standard` instead."
},
"size": {
"description": "Optional string. For future use.",
"type": "string"
"description": "Not used. Retained for future use.",
"type": "string",
"readOnly": true
},
"family": {
"description": "Optional string. For future use.",
"type": "string"
"description": "Not used. Retained for future use.",
"type": "string",
"readOnly": true
},
"capacity": {
"format": "int32",
Expand Down
1 change: 0 additions & 1 deletion ...e-manager/Microsoft.SignalRService/stable/2020-05-01/examples/SignalR_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"capacity": 1
},
"properties": {
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
Expand Down
1 change: 0 additions & 1 deletion .../resource-manager/Microsoft.SignalRService/stable/2020-05-01/examples/SignalR_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"capacity": 1
},
"properties": {
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
Expand Down
13 changes: 8 additions & 5 deletions ...fication/signalr/resource-manager/Microsoft.SignalRService/stable/2020-05-01/signalr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,12 +1138,14 @@
"description": "Optional tier of this particular SKU. 'Standard' or 'Free'. \r\n\r\n`Basic` is deprecated, use `Standard` instead."
},
"size": {
"description": "Optional string. For future use.",
"type": "string"
"description": "Not used. Retained for future use.",
"type": "string",
"readOnly": true
},
"family": {
"description": "Optional string. For future use.",
"type": "string"
"description": "Not used. Retained for future use.",
"type": "string",
"readOnly": true
},
"capacity": {
"format": "int32",
Expand Down Expand Up @@ -1242,7 +1244,8 @@
"properties": {
"hostNamePrefix": {
"description": "Prefix for the hostName of the SignalR service. Retained for future use.\r\nThe hostname will be of format: <hostNamePrefix>.service.signalr.net.",
"type": "string"
"type": "string",
"readOnly": true
},
"features": {
"description": "List of SignalR featureFlags. e.g. ServiceMode.\r\n\r\nFeatureFlags that are not included in the parameters for the update operation will not be modified.\r\nAnd the response will only include featureFlags that are explicitly set. \r\nWhen a featureFlag is not explicitly set, SignalR service will use its globally default value. \r\nBut keep in mind, the default value doesn't mean \"false\". It varies in terms of different FeatureFlags.",
Expand Down