[SRP] Add allowSharedKeyAccess property support #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HimanshuChhabra
requested review from
blueww and
JasonYang-MSFT
as code owners
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'allowSharedKeyAccess' in response that was not found in the old version. New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2783:7 Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2779:7 |
|
The new version has a new property 'allowSharedKeyAccess' in response that was not found in the old version. New: Microsoft.Storage/stable/2019-04-01/storage.json#L1624:7 Old: Microsoft.Storage/stable/2019-04-01/storage.json#L1620:7 |
|
The new version has a new property 'allowSharedKeyAccess' in response that was not found in the old version. New: Microsoft.Storage/stable/2019-06-01/storage.json#L2433:7 Old: Microsoft.Storage/stable/2019-06-01/storage.json#L2429:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
This was referenced Nov 20, 2020
|
Unsure what is the breaking change here. This is a preview version and a new additive property has been added. |
Please go through the breaking change process to request an exception if you feel this is not a breaking change for your consumers |
pilor
added
WaitForARMFeedback
|
Hi @HimanshuChhabra, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Kindly explain the breaking change. This is an Evolutionary change in a Preview Api version. : https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#versioning |
|
Raised a workitem as per the request: https://msazure.visualstudio.com/One/_workitems/edit/8863671 |
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Jan 28, 2021
pilor
reviewed
Jan 28, 2021
| }, | ||
| "allowSharedKeyAccess": { | ||
| "type": "boolean", | ||
| "description": "Indicates whether the storage account permits requests to be authorized with the account access key via Shared Key. If false, then all requests, including shared access signatures, must be authorized with Azure Active Directory (Azure AD). The default value is null, which is equivalent to true." |
There was a problem hiding this comment.
if the default is true please add "default": true so consuming services know that it is a non standard default
There was a problem hiding this comment.
The default value is null, if it is not set the behavior is the same as when set true.
pilor
added
ARMSignedOff
blueww
approved these changes
Jan 29, 2021
This was referenced Jan 29, 2021
3 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Add allowSharedKeyAccess property support * Remove x-ms-clientname as it cannot be same as property name as per new ARM rules * backfill June19 and April19 Api versions with allowsharedkeyaccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.