OSSRDBMS Swagger completeness related changes #11685

shinilm · 2020-11-16T08:03:15Z

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- [X ] update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- [X ] SDK of Python
- SDK of Java
- SDK of Js
- [X ] SDK of Go
- PowerShell
- [X ] CLI
- [X ] Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

[X ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-11-16T08:03:20Z

Swagger Validation Report

️❌BreakingChange: 54 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2018-06-01-preview/mariadb.json <---> new: preview/2018-06-01-preview/mariadb.json
- original: stable/2018-06-01/mariadb.json <---> new: stable/2018-06-01/mariadb.json
- original: preview/2017-12-01-preview/mysql.json <---> new: preview/2017-12-01-preview/mysql.json
- original: stable/2017-12-01/mysql.json <---> new: stable/2017-12-01/mysql.json
- original: preview/2017-12-01-preview/postgresql.json <---> new: preview/2017-12-01-preview/postgresql.json
- original: stable/2017-12-01/postgresql.json <---> new: stable/2017-12-01/postgresql.json

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/preview/2017-12-01-preview/postgresql.json#L1362:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/preview/2017-12-01-preview/postgresql.json#L1320:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMySQL/preview/2017-12-01-preview/mysql.json#L1317:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1036:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1133:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1175:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1144:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1247:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1289:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforMySQL/preview/2017-12-01-preview/mysql.json#L1036:5

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )

Rule	Message
⚠️ R2010 - LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. New: Microsoft.DBforMySQL/preview/2017-12-01-preview/mysql.json#L1036

️⚠️Avocado: 3 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mariadb/resource-manager/readme.md tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mysql/resource-manager/readme.md tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2020-11-16T08:03:20Z

Thank you for your contribution shinilm! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2020-11-16T08:03:20Z

Swagger Generation Artifacts

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from 877e69b. SDK Automation 14.0.0

Only show 40 items here, please refer to log for details.

cmderr	[generate.py] 2020-12-08 07:29:07 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-08 07:29:07 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/w/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/w/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[generate.py] 2020-12-08 07:29:54 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2020-12-08 07:29:54 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2020-12-08 07:29:54 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2020-12-08 07:29:54 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2020-12-08 07:29:54 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
cmderr	[generate.py] 2020-12-08 07:32:06 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mysql"
cmderr	[generate.py] 2020-12-08 07:32:06 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-08 07:32:06 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/w/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/w/azure-sdk-for-java/sdk/mysql/azure-resourcemanager-mysql --java.namespace=com.azure.resourcemanager.mysql  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
cmderr	[generate.py] 2020-12-08 07:32:30 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2020-12-08 07:32:30 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2020-12-08 07:32:30 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2020-12-08 07:32:30 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2020-12-08 07:32:30 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
cmderr	[generate.py] 2020-12-08 07:33:44 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-postgresql"
cmderr	[generate.py] 2020-12-08 07:33:44 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-08 07:33:44 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/w/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/w/azure-sdk-for-java/sdk/postgresql/azure-resourcemanager-postgresql --java.namespace=com.azure.resourcemanager.postgresql  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[generate.py] 2020-12-08 07:34:03 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2020-12-08 07:34:03 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2020-12-08 07:34:03 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2020-12-08 07:34:03 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2020-12-08 07:34:03 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
ENOTDIR: not a directory, scandir 'azure-sdk-for-java/pom.xml'
Error: ENOTDIR: not a directory, scandir 'azure-sdk-for-java/pom.xml'

️✔️azure-resourcemanager-mariadb [View full logs]

error	Fatal error: ENOTDIR: not a directory, scandir 'azure-sdk-for-java/pom.xml'
error	The following packages are still pending:
error		azure-resourcemanager-mariadb
error		azure-resourcemanager-mysql
error		azure-resourcemanager-postgresql

️✔️azure-resourcemanager-mysql
️✔️azure-resourcemanager-postgresql

️⚠️ azure-sdk-for-net warning [Detail]

⚠️Warning [Logs]Release - Generate from 877e69b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.MariaDB [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```
️✔️Microsoft.Azure.Management.MySQL [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.MySQL.0.1.0-preview.nupkg
- Microsoft.Azure.Management.MySQL.0.1.0-preview.snupkg
️✔️Microsoft.Azure.Management.PostgreSQL [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.PostgreSQL.0.9.5-preview.nupkg
- Microsoft.Azure.Management.PostgreSQL.0.9.5-preview.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 877e69b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md

️✔️@azure/arm-mariadb [View full logs] [Release SDK Changes]

azure-arm-mariadb-1.4.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mariaDBManagementClient.js → ./dist/arm-mariadb.js...
cmderr	[npmPack] created ./dist/arm-mariadb.js in 571ms

️✔️@azure/arm-mysql [View full logs] [Release SDK Changes]

azure-arm-mysql-3.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mySQLManagementClient.js → ./dist/arm-mysql.js...
cmderr	[npmPack] created ./dist/arm-mysql.js in 648ms

️✔️@azure/arm-postgresql [View full logs] [Release SDK Changes]

azure-arm-postgresql-4.4.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql.js...
cmderr	[npmPack] created ./dist/arm-postgresql.js in 509ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 877e69b. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md

️✔️mariadb [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs]Release - Generate from 877e69b. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cannot force update branch 'sdkAuto/preview_mysql/mgmt/2020-07-01-preview/mysqlflexibleservers' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/preview_mysql/mgmt/2020-07-01-preview/mysqlflexibleservers' as it is the current HEAD of the repository.

️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers [View full logs]

Only show 7 items here, please refer to log for details.

error		mariadb/mgmt/2018-06-01/mariadb
error		preview/mysql/mgmt/2017-12-01-preview/mysql
error		preview/mysql/mgmt/2017-12-01-preview/mysql
error		preview/postgresql/mgmt/2017-12-01-preview/postgresql
error		mysql/mgmt/2017-12-01/mysql
error		postgresql/mgmt/2017-12-01/postgresql
error		mysql/mgmt/2017-12-01/mysql

️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers
️✔️mariadb/mgmt/2020-01-01/mariadb
️✔️mariadb/mgmt/2020-01-01/mariadb
️✔️mysql/mgmt/2020-01-01/mysql
️✔️postgresql/mgmt/2020-01-01/postgresql
️✔️mariadb/mgmt/2020-01-01/mariadb
️✔️mysql/mgmt/2020-01-01/mysql
️✔️mariadb/mgmt/2018-06-01/mariadb
️✔️mariadb/mgmt/2018-06-01/mariadb
️✔️mariadb/mgmt/2018-06-01/mariadb
️✔️preview/mysql/mgmt/2017-12-01-preview/mysql
️✔️preview/mysql/mgmt/2017-12-01-preview/mysql
️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql
️✔️mysql/mgmt/2017-12-01/mysql
️✔️postgresql/mgmt/2017-12-01/postgresql
️✔️mysql/mgmt/2017-12-01/mysql

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

- Breaking Change Detected

️✔️Succeeded [Logs]Release - Generate from 877e69b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md

️✔️azure-mgmt-rdbms [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 120 items here, please refer to log for details.

cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.aio
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mariadb
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mariadb.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mysql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mysql.v2020_01_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mysql.v2020_07_01_privatepreview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/postgresql.v2020_01_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/postgresql.v2020_02_14_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Merged report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/merged_report.json
cmdout	[Changelog] Size of delta 43.750% size of original (original: 72263 chars, delta: 31615 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model Server has a new parameter server_tags
cmdout	[Changelog]   - Model LogFile has a new parameter log_file_type
cmdout	[Changelog]   - Added operation FirewallRulesOperations.create_or_update
cmdout	[Changelog]   - Added operation FirewallRulesOperations.delete
cmdout	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerAdministratorsOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerAdministratorsOperations.delete
cmdout	[Changelog]   - Added operation ConfigurationsOperations.update
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.create_or_update
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.update_tags
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.delete
cmdout	[Changelog]   - Added operation ServerKeysOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerKeysOperations.delete
cmdout	[Changelog]   - Added operation VirtualNetworkRulesOperations.create_or_update
cmdout	[Changelog]   - Added operation VirtualNetworkRulesOperations.delete
cmdout	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.create_recommended_action_session
cmdout	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.create_recommended_action_session
cmdout	[Changelog]   - Added operation DatabasesOperations.create
cmdout	[Changelog]   - Added operation DatabasesOperations.delete
cmdout	[Changelog]   - Added operation ServersOperations.restart
cmdout	[Changelog]   - Added operation ServersOperations.update
cmdout	[Changelog]   - Added operation ServersOperations.stop
cmdout	[Changelog]   - Added operation ServersOperations.delete
cmdout	[Changelog]   - Added operation ServersOperations.create
cmdout	[Changelog]   - Added operation ServersOperations.start
cmdout	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations
cmdout	[Changelog]   - Added operation group ServerParametersOperations
cmdout	[Changelog]   - Added operation group RecoverableServersOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Parameter virtual_network_subnet_id of model VirtualNetworkRule is now required
cmdout	[Changelog]   - Parameter login of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter tenant_id of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter sid of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter administrator_type of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter server_key_type of model ServerKey is now required
cmdout	[Changelog]   - Parameter state of model ServerSecurityAlertPolicy is now required
cmdout	[Changelog]   - Operation WaitStatisticsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation WaitStatisticsOperations.get has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkRulesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkRulesOperations.get has a new signature
cmdout	[Changelog]   - Operation TopQueryStatisticsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation TopQueryStatisticsOperations.get has a new signature
cmdout	[Changelog]   - Operation ServerKeysOperations.list has a new signature
cmdout	[Changelog]   - Operation ServerKeysOperations.get has a new signature
cmdout	[Changelog]   - Operation ServerAdministratorsOperations.list has a new signature
cmdout	[Changelog]   - Operation ServerAdministratorsOperations.get has a new signature
cmdout	[Changelog]   - Operation ReplicasOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation RecommendedActionsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation RecommendedActionsOperations.get has a new signature
cmdout	[Changelog]   - Operation QueryTextsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation QueryTextsOperations.get has a new signature
cmdout	[Changelog]   - Operation PrivateLinkResourcesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation PrivateLinkResourcesOperations.get has a new signature
cmdout	[Changelog]   - Operation PrivateEndpointConnectionsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation PrivateEndpointConnectionsOperations.get has a new signature
cmdout	[Changelog]   - Operation LogFilesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation LocationBasedRecommendedActionSessionsResultOperations.list has a new signature
cmdout	[Changelog]   - Operation LocationBasedRecommendedActionSessionsOperationStatusOperations.get has a new signature
cmdout	[Changelog]   - Operation LocationBasedPerformanceTierOperations.list has a new signature
cmdout	[Changelog]   - Operation LocationBasedCapabilitiesOperations.execute has a new signature
cmdout	[Changelog]   - Operation FirewallRulesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation FirewallRulesOperations.get has a new signature
cmdout	[Changelog]   - Operation ConfigurationsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation ConfigurationsOperations.get has a new signature
cmdout	[Changelog]   - Operation AdvisorsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation AdvisorsOperations.get has a new signature
cmdout	[Changelog]   - Model Server no longer has parameter tags_properties_tags
cmdout	[Changelog]   - Model ConfigurationListResult no longer has parameter next_link
cmdout	[Changelog]   - Model LogFile no longer has parameter type_properties_type
cmdout	[Changelog]   - Operation Operations.list has a new signature
cmdout	[Changelog]   - Operation ServerSecurityAlertPoliciesOperations.get has a new signature
cmdout	[Changelog]   - Operation CheckVirtualNetworkSubnetUsageOperations.execute has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkSubnetUsageOperations.execute has a new signature
cmdout	[Changelog]   - Operation CheckNameAvailabilityOperations.execute has a new signature
cmdout	[Changelog]   - Model PerformanceTierProperties has a new signature
cmdout	[Changelog]   - Removed operation FirewallRulesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation FirewallRulesOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServerSecurityAlertPoliciesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_delete
cmdout	[Changelog]   - Removed operation ConfigurationsOperations.begin_update
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServerKeysOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServerKeysOperations.begin_delete
cmdout	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_delete
cmdout	[Changelog]   - Removed operation MariaDBManagementClientOperationsMixin.begin_create_recommended_action_session
cmdout	[Changelog]   - Removed operation MySQLManagementClientOperationsMixin.begin_create_recommended_action_session
cmdout	[Changelog]   - Removed operation DatabasesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation DatabasesOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServersOperations.begin_create
cmdout	[Changelog]   - Removed operation ServersOperations.begin_start
cmdout	[Changelog]   - Removed operation ServersOperations.begin_restart
cmdout	[Changelog]   - Removed operation ServersOperations.begin_stop
cmdout	[Changelog]   - Removed operation ServersOperations.begin_update
cmdout	[Changelog]   - Removed operation ServersOperations.begin_delete
warn	Breaking change found in changelog

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

…into ossrdbms-compliance

erich-wang · 2020-11-19T05:23:41Z

/azp run

azure-pipelines · 2020-11-19T05:23:57Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2020-11-19T05:25:03Z

Hi @shinilm, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

openapi-workflow-bot · 2020-12-01T23:30:49Z

Hi, @shinilm Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

...anager/Microsoft.DBforMariaDB/preview/2018-06-01-preview/examples/RecoverableServersGet.json

...tion/mariadb/resource-manager/Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json

j5lim · 2020-12-02T19:40:47Z

specification/mariadb/resource-manager/Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json

+            "$ref": "./examples/RecoverableServersGet.json"
+          }
+        },
+        "description": "Gets a recoverable MariaDB Server.",


Same comments as the preview version.

This is what service returns

j5lim

This is to make old api version and swagger aligned. Signing from ARM side.

shinilm · 2020-12-07T18:05:22Z

Hi Erich, The ARM team and the Breaking change board approved the PR. Please help merge this PR. Thanks Shinil From: erich-wang <[email protected]> Sent: Wednesday, November 18, 2020 9:24 PM To: Azure/azure-rest-api-specs <[email protected]> Cc: Shinil Mannadath <[email protected]>; Author <[email protected]> Subject: Re: [Azure/azure-rest-api-specs] OSSRDBMS Swagger completeness related changes (#11685) /azp run — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F11685%23issuecomment-730137384&data=04%7C01%7Cshinim%40microsoft.com%7C2a4d9f15f11d4b3454ee08d88c4b4ee4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637413602360425709%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oOrfN0TAmBWnjlMuaCaWftsqYxT%2FYbpj1NHqJuls1uU%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKUG6JQ7HSOZKXMFU6V7LEDSQSTWVANCNFSM4TW2SIKA&data=04%7C01%7Cshinim%40microsoft.com%7C2a4d9f15f11d4b3454ee08d88c4b4ee4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637413602360435704%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=wC7fnrRMf7o4OWsXHShP4hQESkfUNEvhxdBXEIvHN%2FU%3D&reserved=0>.

* OSSRDBMS Swagger completeness related changes * OSSRDBMS Swagger completeness related changes * OSSRDBMS Swagger completeness related changes * OSSRDBMS Swagger completeness related changes

OSSRDBMS Swagger completeness related changes

2b99d0f

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 16, 2020

openapi-assignment-bot bot assigned erich-wang Nov 16, 2020

openapi-pipeline-app bot added the CI-BreakingChange-Python label Nov 16, 2020

openapi-sdkautomation bot mentioned this pull request Nov 16, 2020

[AutoPR mariadb] OSSRDBMS Swagger completeness related changes AzureSDKAutomation/azure-resource-manager-schemas#840

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 16, 2020

shinilm added 4 commits November 16, 2020 00:38

OSSRDBMS Swagger completeness related changes

c693efa

OSSRDBMS Swagger completeness related changes

bee0210

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

6fdabe9

…into ossrdbms-compliance

OSSRDBMS Swagger completeness related changes

24c218f

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2020

erich-wang added the BreakingChangeReviewRequired label Nov 19, 2020

openapi-pipeline-app bot added the NewApiVersionRequired label Nov 19, 2020

JeffreyRichter self-requested a review December 2, 2020 18:22

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 2, 2020

JeffreyRichter approved these changes Dec 2, 2020

View reviewed changes

j5lim reviewed Dec 2, 2020

View reviewed changes

...anager/Microsoft.DBforMariaDB/preview/2018-06-01-preview/examples/RecoverableServersGet.json Show resolved Hide resolved

...tion/mariadb/resource-manager/Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json Show resolved Hide resolved

j5lim reviewed Dec 2, 2020

View reviewed changes

j5lim added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 2, 2020

j5lim approved these changes Dec 5, 2020

View reviewed changes

erich-wang merged commit 877e69b into Azure:master Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSSRDBMS Swagger completeness related changes #11685

OSSRDBMS Swagger completeness related changes #11685

shinilm commented Nov 16, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 16, 2020 •

edited

Loading

ghost commented Nov 16, 2020

openapi-pipeline-app bot commented Nov 16, 2020 •

edited

Loading

erich-wang commented Nov 19, 2020

azure-pipelines bot commented Nov 19, 2020

openapi-workflow-bot bot commented Nov 19, 2020

openapi-workflow-bot bot commented Dec 1, 2020

j5lim Dec 2, 2020

shinilm Dec 4, 2020

j5lim left a comment

shinilm commented Dec 7, 2020 via email

OSSRDBMS Swagger completeness related changes #11685

OSSRDBMS Swagger completeness related changes #11685

Conversation

shinilm commented Nov 16, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Nov 16, 2020 • edited Loading

Swagger Validation Report

ghost commented Nov 16, 2020

openapi-pipeline-app bot commented Nov 16, 2020 • edited Loading

Swagger Generation Artifacts

erich-wang commented Nov 19, 2020

azure-pipelines bot commented Nov 19, 2020

openapi-workflow-bot bot commented Nov 19, 2020

openapi-workflow-bot bot commented Dec 1, 2020

j5lim Dec 2, 2020

Choose a reason for hiding this comment

shinilm Dec 4, 2020

Choose a reason for hiding this comment

j5lim left a comment

Choose a reason for hiding this comment

shinilm commented Dec 7, 2020 via email

shinilm commented Nov 16, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 16, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 16, 2020 •

edited

Loading