Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 #11407

Merged
merged 18 commits into from
Dec 25, 2020
Merged

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 #11407

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
64c3c51
Init the next version so diffs can work better.
brpanask Sep 8, 2020
1f7633f
Updates readme
brpanask Oct 26, 2020
a2beb65
Updates API version in new specs and examples
brpanask Oct 26, 2020
6396339
Updates to StorageTargetProperties and added examples of cmk, mtu
brpanask Sep 2, 2020
65478ff
Add prettier fix after rebase
brpanask Oct 30, 2020
a19740e
Remove 202 bodies and add systemData to examples.
brpanask Oct 31, 2020
8c2f79e
Update spec with prettier.
brpanask Oct 31, 2020
15917b5
Address comments on spec for descriptions, readmes, and extendedGroup…
brpanask Nov 4, 2020
2f688fe
Updating to address addition ldap and pattern comments.
brpanask Nov 11, 2020
851b501
Update version tag to include 01
brpanask Nov 11, 2020
cc5006d
Restore changes that would be considered breaking changes matching 20…
brpanask Nov 17, 2020
2392aa8
Address a few other comments.
brpanask Nov 17, 2020
82d34bf
Update netbios field names and some descriptions.
brpanask Dec 3, 2020
c02d6e2
Fix s360 for missing debugInfo operation.
brpanask Dec 7, 2020
a3d6bc4
Fix credscan error in example file.
brpanask Dec 16, 2020
84fb038
Update required fields, new validator failure on debugInfo return cod…
brpanask Dec 23, 2020
f5c8b61
Update debug info example with new return codes.
brpanask Dec 23, 2020
f0b031b
Update other credscan password errors.
brpanask Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,7 @@ paramref
PARAVIRTUAL
partnertopic
Passthrough
passwd
patternanyentities
patternrule
patternrules
Expand Down Expand Up @@ -1593,6 +1594,7 @@ subfolders
subinquireditemcount
sublist
sublists
submount
subnames
subnet
subnet's
Expand All @@ -1616,6 +1618,7 @@ subword
subwords
sudoer
suggesters
suid
Superfresh
superset
supportedimages
Expand Down
19 changes: 19 additions & 0 deletions ...resource-manager/Microsoft.StorageCache/stable/2020-10-01/examples/AscOperations_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"location": "westus",
"operationId": "testoperationid",
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/id/locations/westus/ascOperations/testoperationid",
"name": "testoperationid",
"startTime": "2020-10-01T13:13:13.933Z",
"endTime": "2020-10-01T16:13:13.933Z",
"status": "Succeeded"
}
}
}
}
255 changes: 255 additions & 0 deletions ...urce-manager/Microsoft.StorageCache/stable/2020-10-01/examples/Caches_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,255 @@
{
"parameters": {
"resourceGroupName": "scgroup",
"cacheName": "sc1",
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"api-version": "2020-10-01",
"cache": {
"tags": {
"Dept": "ContosoAds"
},
"location": "westus",
"properties": {
"cacheSizeGB": 3072,
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2047/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"cacheNetBiosName": "contosoSmb",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"credentials": {
"username": "consotoAdmin",
"password": "password123"
}
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"credentials": {
"bindDn": "cn=ldapadmin,dc=contosoad,dc=contoso,dc=local",
"bindPassword": "ldapPassword123"
}
}
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
}
},
"sku": {
"name": "Standard_2G"
}
}
},
"responses": {
"202": {},
"201": {
"body": {
"tags": {
"Dept": "ContosoAds"
},
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.StorageCache/caches/sc1",
"location": "westus",
"name": "sc1",
"type": "Microsoft.StorageCache/Cache",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"cacheSizeGB": 3072,
"health": {
"state": "Transitioning",
"statusDescription": "Cache is being created."
},
"mountAddresses": [
"192.168.1.1",
"192.168.1.2"
],
"provisioningState": "Succeeded",
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"upgradeStatus": {
"currentFirmwareVersion": "5.3.23",
"firmwareUpdateStatus": "available",
"firmwareUpdateDeadline": "2019-04-21T18:25:43.511Z",
"lastFirmwareUpdate": "2019-01-21T18:25:43.511Z",
"pendingFirmwareVersion": "5.3.24"
},
"networkSettings": {
"mtu": 1500
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
},
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2048/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"cacheNetBiosName": "contosoSmb",
"domainJoined": "No"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
"caCertificateURI": "",
"usernameDownloaded": "No"
}
}
},
"sku": {
"name": "Standard_2G"
}
}
},
"200": {
"body": {
"tags": {
"Dept": "ContosoAds"
},
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.StorageCache/caches/sc1",
"location": "westus",
"name": "sc1",
"type": "Microsoft.StorageCache/Cache",
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"cacheSizeGB": 3072,
"health": {
"state": "Transitioning",
"statusDescription": "Cache is being created."
},
"mountAddresses": [
"192.168.1.1",
"192.168.1.2"
],
"provisioningState": "Updating",
"subnet": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.Network/virtualNetworks/scvnet/subnets/sub1",
"upgradeStatus": {
"currentFirmwareVersion": "V5.1.12",
"firmwareUpdateStatus": "available",
"firmwareUpdateDeadline": "2019-04-21T18:25:43.511Z",
"lastFirmwareUpdate": "2019-01-21T18:25:43.511Z",
"pendingFirmwareVersion": "V5.1.15"
},
"networkSettings": {
"mtu": 1500
},
"securitySettings": {
"accessPolicies": [
{
"name": "default",
"accessRules": [
{
"scope": "default",
"access": "rw",
"suid": false,
"submountAccess": true,
"rootSquash": false
}
]
}
]
},
"encryptionSettings": {
"keyEncryptionKey": {
"keyUrl": "https://keyvault-cmk.vault.azure.net/keys/key2048/test",
"sourceVault": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scgroup/providers/Microsoft.KeyVault/vaults/keyvault-cmk"
}
}
},
"directoryServicesSettings": {
"activeDirectory": {
"primaryDnsIpAddress": "192.0.2.10",
"secondaryDnsIpAddress": "192.0.2.11",
"domainName": "contosoAd.contoso.local",
"domainNetBiosName": "contosoAd",
"cacheNetBiosName": "contosoSmb",
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
"caCertificateURI": "",
"usernameDownloaded": "Yes"
}
}
},
"sku": {
"name": "Standard_2G"
}
}
}
}
}
Loading