-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new api-version in go SDK for operationalinsights #11213
Add new api-version in go SDK for operationalinsights #11213
Conversation
[Staging] Swagger Validation Report
️✔️ |
Rule | Message |
---|---|
AutoRest Exception |
"details":" "Channel": "fatal", "Text": "swagger-document/compose - FAILED" "Channel": "fatal", "Text": "Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---\n>-\n Gets subscription credentials which uniquely identify Microsoft Azure\n subscription. The subscription ID forms part of the URI for every service\n call.\n, ---\nThe workspace's resource subscription ID.\n)."(node:5981) UnhandledPromiseRejectionWarning: Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (--->-", "location":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/operationalinsights/resource-manager/readme.md" |
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
1f6c6d7
to
ebc61ac
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Hey |
Hi @hohershk could you please also give an approval if this looks good to you. We would take care of the lint diff error (fix it or ignore it) |
@ArcturusZhang |
This lintDiff error is caused by the existing conflict in the original master branch , and since this PR only changes the description of swaggers , the error can be ignored . If it's blocking the PR merging , may ask @akning-ms force merge it |
Thanks |
* Add new api-version in go SDK for operationalinsights * Trying to resolve the modeler error * unify another description * Fix modeler issue * Fix another description * change some statement
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.