-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sso, and vmtemplate #11198
sso, and vmtemplate #11198
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @jianyexi |
Hi @datr93, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Pull request contains merge conflicts. |
Azure Pipelines successfully started running 1 pipeline(s). |
@jianyexi @PhoenixHe-msft the check all pass can we merge this? |
needs ARM's approval first |
Who is the arm approver? I'll ask them to review. |
Azure Pipelines successfully started running 1 pipeline(s). |
optional - Since it's repeated, you could probably extract it into a common definition. Refers to: specification/desktopvirtualization/resource-manager/Microsoft.DesktopVirtualization/preview/2020-10-19-preview/desktopvirtualization.json:2637 in bea2bbd. [](commit_id = bea2bbd, deletion_comment = False) |
"type": "string", | ||
"description": "The error message." | ||
}, | ||
"sessionHostHealthCheckResult": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example it looks like this is returning a JSON embedded in the string value. Why isn't it modeled as an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I talked to the developer who worked on the property. She said the sessionHostHealthCheckResult property was a string in the DB and decided to surface the value as a string.
Is this not acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the property will re add when change is made
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
* add 2020-10-19-preview * readme * remove space * SessionHostHealthCheckResult * fix readme * revert to 2020-09-21 * apply new version again * remove sessionHostHealthCheckResult
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.