Add Policy apis and Unblock Documentation Team #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amarzavery @dsgouda this fixes the issue #1071 |
|
FYI: I ran the latest validation (and manually suppressed some that I think are not applicable) and got the following: You're not really modifying these today, so I'm not going to block on them, but I'm going to note that corrections will soon have to be made to pass the validations. |
fearthecowboy
suggested changes
Apr 14, 2017
| @@ -2,13 +2,9 @@ | |||
| "swagger": "2.0", | |||
| "info": { | |||
| "title": "ApiManagementClient", | |||
| "description": "Use these REST APIs for managing OAuth2 servers configuration in your Azure API Management deployment.", | |||
| "description": "Use these REST APIs for managing OAuth2 servers configuration in your Azure API Management deployment. We can authorize developer accounts using OAuth 2.0 in Azure API Management. For more information refer to [How to OAuth2](https://docs.microsoft.com/en-us/azure/api-management/api-management-howto-oauth2).", | |||
There was a problem hiding this comment.
Minor quibble : We can authorize developer accounts...
We seems an odd choice for words here. Typically, documentation should be written in the non-possessive tense:
OAuth 2.0 can be used to authorize developer accounts for Azure API Management or something. (like I said... minor quibble 😄 )
| "$ref": "#/parameters/OperationIdParameter" | ||
| }, | ||
| { | ||
| "name": "policyData", |
There was a problem hiding this comment.
Standards are now that a body parameter should be named parameters (instead of policyData )
(BodyParametersValidation/M2063/SDKViolation): A body parameter must be named 'parameters'.
let's fix these ones 👍 (all cases!)
|
@fearthecowboy regarding RPC Violations, we have got exception from @ravbhatnagar and have an open issue #1060 tracking to be fixed in next api-version |
fearthecowboy
approved these changes
Apr 14, 2017
|
@solankisamir I assumed as much; just like to point them out 😄 |
|
No modification for Ruby |
|
No modification for Python |
|
No modification for NodeJS |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Create FeatureRP swagger file * Address comments * Address comments * add SubscriptionFeatureRegistrationGET example * Create SubscriptionFeatureRegistrationPUT.json * Create SubscriptionFeatureRegistrationDELETE.json * Create SubscriptionFeatureRegistrationLIST.json * Update SubscriptionFeatureRegistrationGET.json * Update SubscriptionFeatureRegistrationPUT.json * Update SubscriptionFeatureRegistration.json * Update SubscriptionFeatureRegistrationLIST.json * Update SubscriptionFeatureRegistration.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger