-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anf 7051 2020 05 01 api version swagger linting issues kpi #11167
Anf 7051 2020 05 01 api version swagger linting issues kpi #11167
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
Trenton Generation - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @erich-wang |
specification/netapp/resource-manager/Microsoft.NetApp/stable/2020-05-01/netapp.json
Show resolved
Hide resolved
"maximum": 549755813888000, | ||
"default": 4398046511104 | ||
}, | ||
"serviceLevel": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of differences in this compared to 2020-06-01. Especially this patch which is completely different in 2020-06-01. Please diff the two api-versions and confirm that the differences are intentional. In this case why is the patchable properties different between the two versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description to reflect this.
2020-06-01 added a qosType property to pools that turns out is not available in 2020-05. It also removed the option to update the service level of a pool in the service after it is created because now that is not allowed.
Azure Pipelines successfully started running 1 pipeline(s). |
* Add 2020-05-01 api version folder * update api numbers * update specs * fix valdiation issues in examples * Revert change to volumeList * add x-secret Co-authored-by: Audunn Baldvinsson <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This adds API version 2020-05-01 that is mentioned in NetAppFiles ARM Manifest but was not officially released. The additions are therefore functionally the similar as 2020-06-01.
note 2020-06 has these additional updates that are not part of 2020-05-01
pool properties
volume properties
ActiveDirectory
The PR addresses this Swagger Completeness issue
https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8188089
SDK will not need to be generated from this as all changes here are represented in the latest API version 2020-06-01
Note 2020-03-01 API-Version was in another PR #10742 .
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.