Eventhub: Added APIs to 2018-01-01-preview API version #11027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
v-Ajnava
added
the
WaitForARMFeedback
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-python
|
azure-sdk-for-python-track2
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 2, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new PR with this recommendation for faster review. |
|
Why are we adding older preview API version? |
We are adding support for all API (as on 2017 stable version) on the 2018-preview version. we will discuss with team and update the PR. |
|
Signing off from ARM side. This PR is bring all the APIs from 2017-04-01 api version to 2018 preview api version. There is no change in the APIs which were present in the 2017 stable api-version. |
ravbhatnagar
added
ARMSignedOff
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=180013&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
25 tasks
|
@allenjzhang , can you please take look, I think the CI is stuck. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Dec 7, 2020
allenjzhang
approved these changes
Dec 9, 2020
This was referenced Dec 9, 2020
Closed
DeMale
pushed a commit
to DeMale/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2020
* Added support for all API in 2018-preview version * removed extra files * fixed UNREFERENCED_JSON_FILE * update * prettier fix Co-authored-by: v-ajnava <[email protected]>
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Added support for all API in 2018-preview version * removed extra files * fixed UNREFERENCED_JSON_FILE * update * prettier fix Co-authored-by: v-ajnava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.