[Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-12-01 #10996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-10-31 to version 2020-12-01
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1729 |
|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1564 |
|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1040 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L729 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L642 |
|
| 'privateEndpointConnections' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L986 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1564 |
|
| 'privateEndpoint' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1685 |
|
| 'privateLinkServiceConnectionState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1699 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.DigitalTwins/stable/2020-12-01/digitaltwins.json#L1729 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 75 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-03-01-preview/digitaltwins.json <---> new: stable/2020-12-01/digitaltwins.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 19 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-10-31/digitaltwins.json <---> new: stable/2020-12-01/digitaltwins.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 30, 2020
ravbhatnagar
added
the
ARMSignedOff
|
@ChenTanyi , @erich-wang : since ARM has now signed off on the PR, please merge this PR as soon as possible. We are planning on opening this version up to the public within the next 2 weeks. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Dec 8, 2020
|
@sjiherzig Please fix the LintDiff error. |
|
@ChenTanyi There is a known problem in codegen tool, so please ignore the failure temporarily. |
|
@ChenTanyi - this is a new error, and I think it used to be a warning. We are not planning to support systemData in this API version (OK per ARM, as seen in review comments), but only in the next version. |
@jianyexi @akning-ms What's your opinion? @sjiherzig Due to the CI is required, I cannot merge when CI error. If so, it needs @akning-ms for helping force merge. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi, @sjiherzig Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
@ChenTanyi - per @jianyexi's e-mail, we've gone through the swagger suppression process. ARM has signed off on the change. Linter check now passes. Since the Python SDK still fails (known), can you please have @akning-ms force merge? |
ChenTanyi
approved these changes
Dec 15, 2020
|
@akning-ms please help to merge it. |
This was referenced Dec 16, 2020
Closed
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…ion stable/2020-12-01 (Azure#10996) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-10-31 to version 2020-12-01 * Updates readme * Updates API version in new specs and examples * Update swagger spec * Modify SDK build configs * Fix example filename reference * Rename example file * Fix validation errors * Updated examples * Revert change to behavior of async op * Modify discriminators * Enable two discriminators * Fix delete endpoint example * Attempted fix with discriminator * Added westus2, change discriminator enum type name * Decouple allOf from properties * Bugfixes * Modify response to fix validation errors * Fix examples * Change private link type names to be smaller * Fix validation errors in private links * Fix validation error related to private links * Reference private link example * Add public network access * Align with GA swagger * Update private links / private endpoints * Fix example to use actual response status code * Remove unused example * Unmark private endpoint connection to be an azure resource * Add type and name to private endpoint connection resource * Mark id as read-only * Fix return types for endpoint connections * Align return of DELETE * Fix validation errors * Fix version tag in python.md; remove body from DELETE endpoint connection DELETE responses * Synchronize swagger with 2020-10-31 version * Increase resource group name max length to 90 characters * Make publicNetworkAccess nullable * Add publicNetworkAccess flag to PATCH request * Fixed typo * Fix placing of example for endpoints * Update operation ids * Added suppression message
josuhazure
pushed a commit
to josuhazure/azure-rest-api-specs
that referenced
this pull request
Jan 6, 2021
…ion stable/2020-12-01 (Azure#10996) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-10-31 to version 2020-12-01 * Updates readme * Updates API version in new specs and examples * Update swagger spec * Modify SDK build configs * Fix example filename reference * Rename example file * Fix validation errors * Updated examples * Revert change to behavior of async op * Modify discriminators * Enable two discriminators * Fix delete endpoint example * Attempted fix with discriminator * Added westus2, change discriminator enum type name * Decouple allOf from properties * Bugfixes * Modify response to fix validation errors * Fix examples * Change private link type names to be smaller * Fix validation errors in private links * Fix validation error related to private links * Reference private link example * Add public network access * Align with GA swagger * Update private links / private endpoints * Fix example to use actual response status code * Remove unused example * Unmark private endpoint connection to be an azure resource * Add type and name to private endpoint connection resource * Mark id as read-only * Fix return types for endpoint connections * Align return of DELETE * Fix validation errors * Fix version tag in python.md; remove body from DELETE endpoint connection DELETE responses * Synchronize swagger with 2020-10-31 version * Increase resource group name max length to 90 characters * Make publicNetworkAccess nullable * Add publicNetworkAccess flag to PATCH request * Fixed typo * Fix placing of example for endpoints * Update operation ids * Added suppression message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.