Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.StorageSync] 2020-09-01 API version updates #10983

Merged
merged 22 commits into from
Oct 7, 2020
Merged

[Microsoft.StorageSync] 2020-09-01 API version updates #10983

merged 22 commits into from
Oct 7, 2020

Conversation

anpint
Copy link
Member

@anpint anpint commented Sep 29, 2020

The following changes are made to the 2020-09-01 API version:

  • Fix various protocol bugs that were flagged from previous protocol versions
  • Add "serverName" property to registered server and server endpoint properties

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

anpint and others added 15 commits September 17, 2020 13:22
…c] Registered server structure in swagger is missing agent version status
…tegration have “properties” which is not defined in swagger. Add missing properties to operations API specification
…requests does not match swagger spec. Add missing properties to specification
[Microsoft.StorageSync] Add serverName to registered server and server endpoint in 2020-09-01 API version
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 29, 2020

[Staging] Swagger Validation Report

BreakingChange: 45 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1020 - AddedEnumValue The new version is adding enum value(s) 'Unavailable' from the old version.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4452:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4268:9
1020 - AddedEnumValue The new version is adding enum value(s) 'Unavailable' from the old version.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4462:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4278:9
1020 - AddedEnumValue The new version is adding enum value(s) 'Unavailable' from the old version.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4882:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4643:9
1020 - AddedEnumValue The new version is adding enum value(s) 'Unavailable' from the old version.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4457:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4273:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4190:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4028:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4190:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4028:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4251:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4080:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4227:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4060:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4222:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4056:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4261:9
Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4088:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 29, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d4c6676 with merge commit 79b7964. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-storagesync [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/storageSyncManagementClient.js → ./dist/arm-storagesync.js...
    [npmPack] created ./dist/arm-storagesync.js in 516ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 265.9kB dist/arm-storagesync.js                              
    [npmPack] npm notice 95.4kB  dist/arm-storagesync.min.js                          
    [npmPack] npm notice 26.9kB  esm/operations/cloudEndpoints.js                     
    [npmPack] npm notice 1.8kB   esm/models/cloudEndpointsMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 716B    esm/operations/index.js                              
    [npmPack] npm notice 109.0kB esm/models/mappers.js                                
    [npmPack] npm notice 2.5kB   esm/operations/operations.js                         
    [npmPack] npm notice 721B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 2.4kB   esm/operations/operationStatusOperations.js          
    [npmPack] npm notice 546B    esm/models/operationStatusOperationsMappers.js       
    [npmPack] npm notice 3.6kB   esm/models/parameters.js                             
    [npmPack] npm notice 10.2kB  esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 1.5kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 2.1kB   esm/operations/privateLinkResources.js               
    [npmPack] npm notice 1.3kB   esm/models/privateLinkResourcesMappers.js            
    [npmPack] npm notice 11.7kB  esm/operations/registeredServers.js                  
    [npmPack] npm notice 1.6kB   esm/models/registeredServersMappers.js               
    [npmPack] npm notice 995B    rollup.config.js                                     
    [npmPack] npm notice 15.6kB  esm/operations/serverEndpoints.js                    
    [npmPack] npm notice 1.6kB   esm/models/serverEndpointsMappers.js                 
    [npmPack] npm notice 2.2kB   esm/storageSyncManagementClient.js                   
    [npmPack] npm notice 2.6kB   esm/storageSyncManagementClientContext.js            
    [npmPack] npm notice 12.6kB  esm/operations/storageSyncServices.js                
    [npmPack] npm notice 1.7kB   esm/models/storageSyncServicesMappers.js             
    [npmPack] npm notice 6.2kB   esm/operations/syncGroups.js                         
    [npmPack] npm notice 1.5kB   esm/models/syncGroupsMappers.js                      
    [npmPack] npm notice 4.6kB   esm/operations/workflows.js                          
    [npmPack] npm notice 1.4kB   esm/models/workflowsMappers.js                       
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 456.9kB dist/arm-storagesync.js.map                          
    [npmPack] npm notice 71.1kB  dist/arm-storagesync.min.js.map                      
    [npmPack] npm notice 5.1kB   esm/operations/cloudEndpoints.d.ts.map               
    [npmPack] npm notice 11.1kB  esm/operations/cloudEndpoints.js.map                 
    [npmPack] npm notice 846B    esm/models/cloudEndpointsMappers.d.ts.map            
    [npmPack] npm notice 859B    esm/models/cloudEndpointsMappers.js.map              
    [npmPack] npm notice 32.9kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 340B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 355B    esm/operations/index.js.map                          
    [npmPack] npm notice 5.4kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 58.7kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 1.5kB   esm/operations/operations.js.map                     
    [npmPack] npm notice 322B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 335B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 949B    esm/operations/operationStatusOperations.d.ts.map    
    [npmPack] npm notice 1.2kB   esm/operations/operationStatusOperations.js.map      
    [npmPack] npm notice 274B    esm/models/operationStatusOperationsMappers.d.ts.map 
    [npmPack] npm notice 287B    esm/models/operationStatusOperationsMappers.js.map   
    [npmPack] npm notice 829B    esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.1kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 4.0kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 707B    esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 720B    esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 832B    esm/operations/privateLinkResources.d.ts.map         
    [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map           
    [npmPack] npm notice 614B    esm/models/privateLinkResourcesMappers.d.ts.map      
    [npmPack] npm notice 627B    esm/models/privateLinkResourcesMappers.js.map        
    [npmPack] npm notice 2.5kB   esm/operations/registeredServers.d.ts.map            
    [npmPack] npm notice 5.2kB   esm/operations/registeredServers.js.map              
    [npmPack] npm notice 728B    esm/models/registeredServersMappers.d.ts.map         
    [npmPack] npm notice 741B    esm/models/registeredServersMappers.js.map           
    [npmPack] npm notice 3.1kB   esm/operations/serverEndpoints.d.ts.map              
    [npmPack] npm notice 6.6kB   esm/operations/serverEndpoints.js.map                
    [npmPack] npm notice 750B    esm/models/serverEndpointsMappers.d.ts.map           
    [npmPack] npm notice 763B    esm/models/serverEndpointsMappers.js.map             
    [npmPack] npm notice 970B    esm/storageSyncManagementClient.d.ts.map             
    [npmPack] npm notice 1.3kB   esm/storageSyncManagementClient.js.map               
    [npmPack] npm notice 520B    esm/storageSyncManagementClientContext.d.ts.map      
    [npmPack] npm notice 1.4kB   esm/storageSyncManagementClientContext.js.map        
    [npmPack] npm notice 3.0kB   esm/operations/storageSyncServices.d.ts.map          
    [npmPack] npm notice 6.1kB   esm/operations/storageSyncServices.js.map            
    [npmPack] npm notice 794B    esm/models/storageSyncServicesMappers.d.ts.map       
    [npmPack] npm notice 807B    esm/models/storageSyncServicesMappers.js.map         
    [npmPack] npm notice 2.4kB   esm/operations/syncGroups.d.ts.map                   
    [npmPack] npm notice 3.4kB   esm/operations/syncGroups.js.map                     
    [npmPack] npm notice 685B    esm/models/syncGroupsMappers.d.ts.map                
    [npmPack] npm notice 698B    esm/models/syncGroupsMappers.js.map                  
    [npmPack] npm notice 1.8kB   esm/operations/workflows.d.ts.map                    
    [npmPack] npm notice 2.5kB   esm/operations/workflows.js.map                      
    [npmPack] npm notice 670B    esm/models/workflowsMappers.d.ts.map                 
    [npmPack] npm notice 683B    esm/models/workflowsMappers.js.map                   
    [npmPack] npm notice 3.2kB   README.md                                            
    [npmPack] npm notice 16.3kB  esm/operations/cloudEndpoints.d.ts                   

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 29, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service storagesync [Preview Changes]
    curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10983/azure-cli-extensions/storagesync/storagesync-0.1.0-py3-none-any.whl" -o storagesync-0.1.0-py3-none-any.whl
    az extension add --source=storagesync-0.1.0-py3-none-any.whl
    
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d4c6676 with merge commit 79b7964. Azure CLI Automation 13.0.17.20200918.2
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TriggerChangeDetectionParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RecallActionParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageSyncServiceCreateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageSyncServiceCreateParametersProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudEndpointCreateParametersProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ServerEndpointCreateParametersProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RegisteredServerCreateParametersProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ServerEndpointUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CheckNameAvailabilityParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CheckNameAvailabilityResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageSyncServiceUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpoint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkServiceConnectionState' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnectionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
  • ️✔️storagesync [View full logs]  [Release Azure CLI Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 07 Oct 2020 02:10:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:FB11:4B9698:580424:5F7D23AA","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 29, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d4c6676 with merge commit 79b7964. SDK Automation 13.0.17.20200918.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.StorageSync [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 07 Oct 2020 02:13:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0701:0EA2:1C5F3F:41D585:5F7D2446","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 29, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from d4c6676 with merge commit 79b7964. Schema Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 29, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from d4c6676 with merge commit 79b7964. SDK Automation 13.0.17.20200918.2
  • ⚠️sdk/storagesync/mgmt-v2019_02_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[695,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,88] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[704,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListByResourceGroupHeaders>>
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[785,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListBySubscriptionHeaders>>
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[151,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,84] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1042,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,89] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[171,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,91] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[143,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,25] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,83] cannot find symbol
      [mvn]   symbol: class ServiceResponse
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storagesync: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[695,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/CloudEndpointsInner.java:[700,88] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[704,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListByResourceGroupHeaders>>
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/StorageSyncServicesInner.java:[785,47] incompatible types: rx.Observable>> cannot be converted to rx.Observable,com.microsoft.azure.management.storagesync.v2019_02_01.StorageSyncServicesListBySubscriptionHeaders>>
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[151,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/SyncGroupsInner.java:[156,84] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1042,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/ServerEndpointsInner.java:[1047,89] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[171,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/RegisteredServersInner.java:[176,91] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[143,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,25] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storagesync/mgmt-v2019_02_01/src/main/java/com/microsoft/azure/management/storagesync/v2019_02_01/implementation/WorkflowsInner.java:[148,83] cannot find symbol
      [mvn] [ERROR]   symbol: class ServiceResponse
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 07 Oct 2020 02:13:11 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0581:7EE0:383647:5DFD5C:5F7D2437","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 29, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from d4c6676 with merge commit 79b7964. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-storagesync [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-storagesync
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-storagesync
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 07 Oct 2020 02:11:47 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0441:6CF5:342532:569566:5F7D23E3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 35.411% size of original (original: 60345 chars, delta: 21369 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model StorageSyncApiError has a new parameter inner_error
      [ChangeLog]   - Model StorageSyncServiceCreateParameters has a new parameter incoming_traffic_policy
      [ChangeLog]   - Model OperationEntity has a new parameter properties
      [ChangeLog]   - Model ServerEndpointSyncStatus has a new parameter background_data_download_activity
      [ChangeLog]   - Model StorageSyncServiceUpdateParameters has a new parameter incoming_traffic_policy
      [ChangeLog]   - Model ServerEndpointUpdateParameters has a new parameter local_cache_mode
      [ChangeLog]   - Model ServerEndpointSyncActivityStatus has a new parameter sync_mode
      [ChangeLog]   - Model ServerEndpoint has a new parameter server_name
      [ChangeLog]   - Model ServerEndpoint has a new parameter initial_download_policy
      [ChangeLog]   - Model ServerEndpoint has a new parameter local_cache_mode
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter volume_free_space_policy_status
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter space_savings
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter date_policy_status
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter files_not_tiering
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter health_last_updated_timestamp
      [ChangeLog]   - Model ServerEndpointCloudTieringStatus has a new parameter cache_performance
      [ChangeLog]   - Model ServerEndpointSyncSessionStatus has a new parameter last_sync_mode
      [ChangeLog]   - Model StorageSyncService has a new parameter incoming_traffic_policy
      [ChangeLog]   - Model StorageSyncService has a new parameter last_workflow_id
      [ChangeLog]   - Model StorageSyncService has a new parameter provisioning_state
      [ChangeLog]   - Model StorageSyncService has a new parameter last_operation_name
      [ChangeLog]   - Model StorageSyncService has a new parameter private_endpoint_connections
      [ChangeLog]   - Model ServerEndpointCreateParameters has a new parameter initial_download_policy
      [ChangeLog]   - Model ServerEndpointCreateParameters has a new parameter local_cache_mode
      [ChangeLog]   - Model RegisteredServer has a new parameter server_name
      [ChangeLog]   - Model RegisteredServer has a new parameter monitoring_endpoint_uri
      [ChangeLog]   - Model RegisteredServer has a new parameter agent_version_expiration_date
      [ChangeLog]   - Model RegisteredServer has a new parameter agent_version_status
      [ChangeLog]   - Model StorageSyncErrorDetails has a new parameter hashed_message
      [ChangeLog]   - Model StorageSyncErrorDetails has a new parameter exception_type
      [ChangeLog]   - Model StorageSyncErrorDetails has a new parameter http_method
      [ChangeLog]   - Model StorageSyncErrorDetails has a new parameter request_uri
      [ChangeLog]   - Model StorageSyncErrorDetails has a new parameter http_error_code
      [ChangeLog]   - Model Workflow has a new parameter command_name
      [ChangeLog]   - Model Workflow has a new parameter created_timestamp
      [ChangeLog]   - Model Workflow has a new parameter last_status_timestamp
      [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation StorageSyncServicesOperations.update has a new signature
      [ChangeLog]   - Model StorageSyncServiceCreateParameters no longer has parameter properties
      [ChangeLog]   - Model StorageSyncServiceUpdateParameters no longer has parameter properties

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 29, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 29, 2020

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 29, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    …olbugfixes' of https://github.com/anpint/azure-rest-api-specs into dev-storagesync-Microsoft.StorageSync-2020-09-01-protocolbugfixes
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ankushbindlish2
    Copy link
    Member

    @anpint Please add SDK test into our codebase for the cloned version, and then the bumped version with your changes

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ankushbindlish2
    Copy link
    Member

    @anpint Would you please make v1 references to v2 . this will include systemdata etc

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @anpint
    Copy link
    Member Author

    anpint commented Oct 2, 2020

    @akning-ms, could you please help us complete this PR? I see that some of the validations are failing, but I'm not sure how to address them. The breaking change validations should not be applied because this is a preview API version that is not yet released to any clients. Also, ModelValidation is failing due to a malformed date-time string, but I don't see any issue with that date-time string.

    @@ -17,6 +17,8 @@
    "name": "SampleRegisteredServer_1.redmond.corp.microsoft.com",
    "properties": {
    "agentVersion": "3.1.5.0",
    "agentVersionStatus": "Ok",
    "agentVersionExpirationDate": "2018-06-11T21:50:40.5840543Z",
    "serverOSVersion": "10.0.14393.0",
    "serverManagementErrorCode": 0,
    "lastHeartBeat": "\"2018-06-11T21:50:40.5840543Z\"",
    Copy link
    Contributor

    @akning-ms akning-ms Oct 6, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since lastHeartBeat format change to date-time. so I think \" in string is not required which will cause ModelValidation failure

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks, I didn't realize that was the issue.

    @@ -28,7 +28,7 @@
    "operationId": "Operations_List",
    "parameters": [
    {
    "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
    "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Except ErrorResponse, all other common definition like ApiVersionParameter SubscriptionIdParameter can still ref to v1.

    Only change in V2 is ErrorResponse.

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ok, set references back to v1

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @akning-ms akning-ms added potential-sdk-breaking-change Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Oct 7, 2020
    @akning-ms akning-ms merged commit 79b7964 into Azure:master Oct 7, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python potential-sdk-breaking-change
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants