-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.StorageSync] 2020-09-01 API version updates #10983
[Microsoft.StorageSync] 2020-09-01 API version updates #10983
Conversation
…-03-01 to version 2020-09-01
…te. Switch to general health state enum
…c] Registered server structure in swagger is missing agent version status
…recently added fields
…tegration have “properties” which is not defined in swagger. Add missing properties to operations API specification
…requests does not match swagger spec. Add missing properties to specification
Storagesync 20200901 fixprotocolbugs
[Microsoft.StorageSync] Add serverName to registered server and server endpoint in 2020-09-01 API version
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
…olbugfixes' of https://github.com/anpint/azure-rest-api-specs into dev-storagesync-Microsoft.StorageSync-2020-09-01-protocolbugfixes
Azure Pipelines successfully started running 1 pipeline(s). |
@anpint Please add SDK test into our codebase for the cloned version, and then the bumped version with your changes |
Azure Pipelines successfully started running 1 pipeline(s). |
@anpint Would you please make v1 references to v2 . this will include systemdata etc |
Azure Pipelines successfully started running 1 pipeline(s). |
@akning-ms, could you please help us complete this PR? I see that some of the validations are failing, but I'm not sure how to address them. The breaking change validations should not be applied because this is a preview API version that is not yet released to any clients. Also, ModelValidation is failing due to a malformed date-time string, but I don't see any issue with that date-time string. |
@@ -17,6 +17,8 @@ | |||
"name": "SampleRegisteredServer_1.redmond.corp.microsoft.com", | |||
"properties": { | |||
"agentVersion": "3.1.5.0", | |||
"agentVersionStatus": "Ok", | |||
"agentVersionExpirationDate": "2018-06-11T21:50:40.5840543Z", | |||
"serverOSVersion": "10.0.14393.0", | |||
"serverManagementErrorCode": 0, | |||
"lastHeartBeat": "\"2018-06-11T21:50:40.5840543Z\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since lastHeartBeat format change to date-time. so I think \" in string is not required which will cause ModelValidation failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't realize that was the issue.
@@ -28,7 +28,7 @@ | |||
"operationId": "Operations_List", | |||
"parameters": [ | |||
{ | |||
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter" | |||
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except ErrorResponse, all other common definition like ApiVersionParameter SubscriptionIdParameter can still ref to v1.
Only change in V2 is ErrorResponse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, set references back to v1
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
The following changes are made to the 2020-09-01 API version:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.