[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10965

hassanchawiche · 2020-09-28T11:44:53Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-28T11:44:56Z

[Staging] Swagger Validation Report

️❌BreakingChange: 19 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/{operationalInsightsResourceProvider}/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/watchlists' removed or restructured? Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L3577:5
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'createdTimeUtc' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'notes' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'lastUpdatedTimeUtc' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'watchlistItems' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'workspaceId' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'watchlistItems' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'createdTimeUtc' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'workspaceId' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'notes' renamed or removed? New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9590:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L9635:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-28T11:45:10Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-28T11:46:47Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-28T11:46:49Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from e7e99f5 with merge commit bfbfa7d. SDK Automation 13.0.17.20200918.2
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:46:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:0679:1C0C191:3DF6298:5FA391B2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-09-28T11:46:50Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from e7e99f5 with merge commit bfbfa7d. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-28T11:46:51Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e7e99f5 with merge commit bfbfa7d. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:48:08 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0740:6BFD:29C2605:6246BD3:5FA39218","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-28T11:46:51Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-28T11:46:52Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e7e99f5 with merge commit bfbfa7d. SDK Automation 13.0.17.20200918.2

️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]

preview.securityinsight.mgmt.2019-01-01-preview.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:51:07 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0683:DBAC:F57F69B:118AB533:5FA392CB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

️✔️securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]

securityinsight.mgmt.v1.0.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:51:20 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0680:3A01:2795633:5C2E1D6:5FA392D8","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-28T11:46:53Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-28T11:46:54Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10965/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl" -o sentinel-0.1.0-py3-none-any.whl az extension add --source=sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e7e99f5 with merge commit bfbfa7d. Azure CLI Automation 13.0.17.20200918.2

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:45:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:2A6D:47FD459:79A3A7A:5FA39189","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-09-28T11:46:57Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e7e99f5 with merge commit bfbfa7d. Schema Automation 13.0.17.20200918.2

[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[securityinsights][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend

️✔️securityinsights [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5802 passing (1m)
AzureResourceSchema has no registered package commands.
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 05:50:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0700:6C35:F17B79:2636BF3:5FA392C1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

azure-pipelines · 2020-10-03T16:10:03Z

Azure Pipelines successfully started running 1 pipeline(s).

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

chiragg4u · 2020-10-09T02:38:53Z

As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

azure-pipelines · 2020-10-17T04:45:06Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz

Breaking changes board approved the breaking change and the API looks fine as well from ARM perspective. Signed off from ARM side.

That said, you need to fix your linter failures.

azure-pipelines · 2020-10-27T01:21:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-10-27T01:36:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-10-29T12:37:10Z

Azure Pipelines successfully started running 1 pipeline(s).

njuCZ · 2020-10-30T05:08:45Z

@hassanchawiche Have you gone thought the Breaking Change Process ?
since this is a preview version for more than 1 year, is there a deadline for it to become stable?

hassanchawiche · 2020-10-30T14:48:49Z

@hassanchawiche Have you gone thought the Breaking Change Process ?
since this is a preview version for more than 1 year, is there a deadline for it to become stable?

Yes, they approved my changes by Jeffrey Richter. This is the approved work item : https://msazure.visualstudio.com/One/_workitems/edit/8534867

As for the preview version, we do have one stable (2020-01-01). Watchlist is a new feature, and it's currently in preview.

njuCZ · 2020-11-02T08:33:07Z

since this PR is already approved by JeffreyRichter, I will merge it

…version preview/2019-01-01-preview (Azure#10965) * Update swagger for Watchlist public preview * Suppress R4017 * Adjust numberOfLinesToSkip type * Add type format to numberOfLinesToSkip * numberOfLinesToSkip : adjust example * Enhanced Put description

Update swagger for Watchlist public preview

fb4a503

hassanchawiche marked this pull request as ready for review September 28, 2020 11:56

openapi-assignment-bot bot assigned njuCZ Sep 28, 2020

njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 29, 2020

Suppress R4017

06d601d

hassanchawiche added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 6, 2020

akning-ms added BreakingChangeReviewRequired and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 8, 2020

chiragg4u reviewed Oct 9, 2020

View reviewed changes

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Show resolved Hide resolved

JeffreyRichter self-requested a review October 15, 2020 17:21

Adjust numberOfLinesToSkip type

a8821c0

JeffreyRichter approved these changes Oct 19, 2020

View reviewed changes

hassanchawiche added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed BreakingChangeReviewRequired labels Oct 22, 2020

pilor self-requested a review October 22, 2020 17:43

majastrz approved these changes Oct 26, 2020

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 26, 2020

Add type format to numberOfLinesToSkip

fa0bacf

numberOfLinesToSkip : adjust example

52e79aa

Enhanced Put description

e7e99f5

njuCZ added BreakingChangeReviewRequired and removed BreakingChangeReviewRequired labels Nov 2, 2020

Azure deleted a comment from openapi-workflow-bot bot Nov 2, 2020

njuCZ approved these changes Nov 5, 2020

View reviewed changes

njuCZ added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 5, 2020

njuCZ merged commit bfbfa7d into Azure:master Nov 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10965

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10965

hassanchawiche commented Sep 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 28, 2020 •

edited

Loading

azure-pipelines bot commented Sep 28, 2020

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

azure-pipelines bot commented Oct 3, 2020

chiragg4u commented Oct 9, 2020

azure-pipelines bot commented Oct 17, 2020

majastrz left a comment

azure-pipelines bot commented Oct 27, 2020

azure-pipelines bot commented Oct 27, 2020

azure-pipelines bot commented Oct 29, 2020

njuCZ commented Oct 30, 2020

hassanchawiche commented Oct 30, 2020

njuCZ commented Nov 2, 2020

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10965

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10965

Conversation

hassanchawiche commented Sep 28, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Sep 28, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Sep 28, 2020

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 28, 2020 • edited Loading

azure-resource-manager-schemas - Release

azure-pipelines bot commented Oct 3, 2020

chiragg4u commented Oct 9, 2020

azure-pipelines bot commented Oct 17, 2020

majastrz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Oct 27, 2020

azure-pipelines bot commented Oct 27, 2020

azure-pipelines bot commented Oct 29, 2020

njuCZ commented Oct 30, 2020

hassanchawiche commented Oct 30, 2020

njuCZ commented Nov 2, 2020

hassanchawiche commented Sep 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 28, 2020 •

edited

Loading