-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LabelingJob to preview swagger #10874
Conversation
You don't have permission to trigger SDK Automation. |
Swagger Validation Report
|
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/jobs.json#L728 |
|
Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/jobs.json#L764 |
|
Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/jobs.json#L789 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LabelingJobs_CreateOrUpdate' Request Model: 'LabelingJobCreateResource' Response Model: 'LabelingJobResource' New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/jobs.json#L38 |
|
The child tracked resource, 'labelingJobs' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
|
The child tracked resource, 'computes' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
|
The child tracked resource, 'linkedServices' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
|
The child tracked resource, 'services' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
|
The child tracked resource, 'connections' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2296 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Thank you for your contribution yetamsft! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, please have a look
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...er/Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json
Outdated
Show resolved
Hide resolved
Hi @yetamsft since you have separated the LabelingJob entities to another swagger file, you will have to add this new swagger file to the input file list in the corresponding tag in the And also could you please fix other CI checks? |
Merge from azure
Swagger Generation Artifacts
|
Apologize for the delay. I just resolved the conflict. Please help merge this. Thanks -Ye |
* Add labeling jobs operations in spec and examples * Fix labeling job id * move to jobs.json following codeJob pattern * fix eol * Fix readme.md * Fix spec failures * fix spec * Fix deleteLabelingJob * Fix status message list * fix * Fix prettier * handle polymorphic objects * Fix discriminator * Fix polyphorphic def * Fix * Fix * fix * fix * Fix lintdiff error * Fix conflict * Fix LintDiff * Fix LintDiff * Remove id and continuation token. Address comments * Fix LintDiff * Fix * Update azuresourceschema.md * Fix LintDiff * Fix LintDiff * Fix LintDiff
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.