Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add management group registration description to ARM #10869

Merged
merged 9 commits into from
Oct 5, 2020
Merged

add management group registration description to ARM #10869

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
25cc485
add management group registration description to ARM
tjegbejimba Sep 21, 2020
111fdb5
Add response to MG registration description
tjegbejimba Sep 22, 2020
62ccde4
fix ID parameter for MG register
tjegbejimba Sep 25, 2020
e9941fc
fix API signature linter error
tjegbejimba Sep 25, 2020
dd88bd1
fix MG register operationID
tjegbejimba Sep 25, 2020
d243750
fix repsonse schema for MG register
tjegbejimba Sep 25, 2020
b15efec
move MG register to rp section
tjegbejimba Sep 25, 2020
79f6835
update operationId for MG register
tjegbejimba Sep 29, 2020
b68ff4f
update operationID for MG register
tjegbejimba Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions ...ification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2047,6 +2047,41 @@
}
}
},
"/providers/Microsoft.Management/managementGroups/{groupId}/providers/{resourceProviderNamespace}/register": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable swagger is NOT supposed to be modified. Do you know if SDKs have been released on this api-version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this is a swagger bug fix rather than adding a new API. @tjegbejimba can you confirm that this is the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MG registration capability is already on the service side it just hasn't been added to the swagger yet. We're not adding a new API

"post": {
"tags": [
"Providers"
],
"operationId": "Providers_RegisterAtManagementGroupScope",
"description": "Registers a management group with a resource provider.",
"parameters": [
{
"name": "resourceProviderNamespace",
"in": "path",
"required": true,
"type": "string",
"description": "The namespace of the resource provider to register."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/GroupIdParameter"
}
],
"responses": {
"200": {
"description": "OK - Returns information about the resource provider."
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/providers/{resourceProviderNamespace}/register": {
"post": {
"tags": [
Expand Down