aligned deivceSecurityGroups to stable #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 13, 2020
PhoenixHe-NV
suggested changes
Sep 14, 2020
| @@ -3,7 +3,7 @@ | |||
| "info": { | |||
| "title": "Security Center", | |||
| "description": "API spec for Microsoft.Security (Azure Security Center) resource provider", | |||
| "version": "2017-08-01-preview" | |||
| "version": "2019-08-01" | |||
There was a problem hiding this comment.
Please move this change to a new folder 2019-08-01
There was a problem hiding this comment.
Hi @NullMDR
This PR actually does not change the API contract and doesn't contain breaking changes.
The same changes were already made to the stable version a few months back (see discussion in PR: #8820), since the original swagger started to break the SDK generation (the preview version remained untouched in that PR).
Now, the preview version started to break other, unrelated PRs (see: #10418 (comment)) (ones that add new resource types). So this PR fixes the preview version the same way the stable version was fixed (again, no actual API changes are made).
Thanks for reviewing 🙂
There was a problem hiding this comment.
@NullMDR just realized what you actually meant... 😬
The API version was changed by mistake. I've reverted that change (my other general comments still stand though 😅)
PhoenixHe-NV
added
the
Reviewed-ChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @liranc you are trying to introduce breaking change for preview api over 1 year. Please follow breaking change policy https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes |
@NullMDR we actually had the same discussion in this PR: #8820 🙂 (the changes in this PR as the same). The latest version of the swagger results in an error when attempt to generate code using AutoRest. |
PhoenixHe-NV
added
potential-sdk-breaking-change
Approved-BreakingChange
PhoenixHe-NV
approved these changes
Sep 21, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* aligned deivceSecurityGroups to stable * Fix tests * Fixed api version Co-authored-by: Liran Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.