Change type name 'TrackedResourceLocation' to 'AzureTrackedResourceLocation' #10613

surashed · 2020-08-27T10:00:23Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-27T10:00:28Z

[Staging] Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: resource-manager/common/v1/types.json#L60:5 Old: resource-manager/common/v1/types.json#L60:5

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-27T10:01:13Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-27T10:02:52Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-27T10:02:54Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-27T10:02:55Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a310d97 with merge commit c664728. SDK Automation 13.0.17.20200825.1
️✔️preview/security/mgmt/v1.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v1.0.zip
️✔️preview/security/mgmt/v2.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v2.0.zip
️✔️preview/security/mgmt/v3.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v3.0.zip

openapi-sdkautomation · 2020-08-27T10:02:57Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a310d97 with merge commit c664728. SDK Automation 13.0.17.20200825.1

️✔️@azure/arm-security [View full logs] [Release SDK Changes]

azure-arm-security-2.0.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
[npmPack] created ./dist/arm-security.js in 1.1s
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 4.8kB   esm/operations/adaptiveApplicationControls.js                          
[npmPack] npm notice 634B    esm/models/adaptiveApplicationControlsMappers.js                       
[npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
[npmPack] npm notice 3.1kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
[npmPack] npm notice 3.0kB   esm/operations/advancedThreatProtection.js                             
[npmPack] npm notice 3.1kB   esm/models/advancedThreatProtectionMappers.js                          
[npmPack] npm notice 13.7kB  esm/operations/alerts.js                                               
[npmPack] npm notice 3.0kB   esm/models/alertsMappers.js                                            
[npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
[npmPack] npm notice 3.1kB   esm/models/alertsSuppressionRulesMappers.js                            
[npmPack] npm notice 5.0kB   esm/operations/allowedConnections.js                                   
[npmPack] npm notice 521B    esm/models/allowedConnectionsMappers.js                                
[npmPack] npm notice 761.8kB dist/arm-security.js                                                   
[npmPack] npm notice 297.4kB dist/arm-security.min.js                                               
[npmPack] npm notice 5.3kB   esm/operations/assessments.js                                          
[npmPack] npm notice 3.1kB   esm/models/assessmentsMappers.js                                       
[npmPack] npm notice 7.7kB   esm/operations/assessmentsMetadata.js                                  
[npmPack] npm notice 3.1kB   esm/models/assessmentsMetadataMappers.js                               
[npmPack] npm notice 8.3kB   esm/operations/automations.js                                          
[npmPack] npm notice 672B    esm/models/automationsMappers.js                                       
[npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
[npmPack] npm notice 3.1kB   esm/models/autoProvisioningSettingsMappers.js                          
[npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
[npmPack] npm notice 3.1kB   esm/models/complianceResultsMappers.js                                 
[npmPack] npm notice 3.2kB   esm/operations/compliances.js                                          
[npmPack] npm notice 3.1kB   esm/models/compliancesMappers.js                                       
[npmPack] npm notice 5.1kB   esm/operations/connectors.js                                           
[npmPack] npm notice 3.1kB   esm/models/connectorsMappers.js                                        
[npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
[npmPack] npm notice 3.1kB   esm/models/deviceSecurityGroupsMappers.js                              
[npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
[npmPack] npm notice 498B    esm/models/discoveredSecuritySolutionsMappers.js                       
[npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
[npmPack] npm notice 704B    esm/models/externalSecuritySolutionsMappers.js                         
[npmPack] npm notice 345B    esm/models/index.js                                                    
[npmPack] npm notice 2.2kB   esm/operations/index.js                                                
[npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
[npmPack] npm notice 3.1kB   esm/models/informationProtectionPoliciesMappers.js                     
[npmPack] npm notice 3.8kB   esm/operations/iotAlerts.js                                            
[npmPack] npm notice 444B    esm/models/iotAlertsMappers.js                                         
[npmPack] npm notice 3.0kB   esm/operations/iotAlertTypes.js                                        
[npmPack] npm notice 3.1kB   esm/models/iotAlertTypesMappers.js                                     
[npmPack] npm notice 4.9kB   esm/operations/iotDefenderSettings.js                                  
[npmPack] npm notice 3.3kB   esm/models/iotDefenderSettingsMappers.js                               
[npmPack] npm notice 3.9kB   esm/operations/iotRecommendations.js                                   
[npmPack] npm notice 3.1kB   esm/models/iotRecommendationsMappers.js                                
[npmPack] npm notice 3.2kB   esm/operations/iotRecommendationTypes.js                               
[npmPack] npm notice 3.1kB   esm/models/iotRecommendationTypesMappers.js                            
[npmPack] npm notice 8.9kB   esm/operations/iotSecuritySolution.js                                  
[npmPack] npm notice 3.1kB   esm/operations/iotSecuritySolutionAnalytics.js                         
[npmPack] npm notice 3.1kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
[npmPack] npm notice 598B    esm/models/iotSecuritySolutionMappers.js                               
[npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
[npmPack] npm notice 571B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
[npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
[npmPack] npm notice 532B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
[npmPack] npm notice 5.0kB   esm/operations/iotSensors.js                                           
[npmPack] npm notice 3.1kB   esm/models/iotSensorsMappers.js                                        
[npmPack] npm notice 12.6kB  esm/operations/jitNetworkAccessPolicies.js                             
[npmPack] npm notice 767B    esm/models/jitNetworkAccessPoliciesMappers.js                          
[npmPack] npm notice 3.1kB   esm/operations/locations.js                                            
[npmPack] npm notice 3.1kB   esm/models/locationsMappers.js                                         
[npmPack] npm notice 220.6kB esm/models/mappers.js                                                  
[npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
[npmPack] npm notice 465B    esm/models/operationsMappers.js                                        
[npmPack] npm notice 17.9kB  esm/models/parameters.js                                               
[npmPack] npm notice 3.4kB   esm/operations/pricings.js                                             
[npmPack] npm notice 3.0kB   esm/models/pricingsMappers.js                                          
[npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
[npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
[npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
[npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceControlsMappers.js                      
[npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
[npmPack] npm notice 3.1kB   esm/models/regulatoryComplianceStandardsMappers.js                     
[npmPack] npm notice 976B    rollup.config.js                                                       
[npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
[npmPack] npm notice 3.1kB   esm/models/secureScoreControlDefinitionsMappers.js                     
[npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
[npmPack] npm notice 3.1kB   esm/models/secureScoreControlsMappers.js                               
[npmPack] npm notice 3.2kB   esm/operations/secureScores.js                                         
[npmPack] npm notice 3.1kB   esm/models/secureScoresMappers.js                                      
[npmPack] npm notice 5.2kB   esm/securityCenter.js                                                  
[npmPack] npm notice 2.7kB   esm/securityCenterContext.js                                           
[npmPack] npm notice 6.3kB   esm/operations/securityContacts.js                                     
[npmPack] npm notice 3.1kB   esm/models/securityContactsMappers.js                                  
[npmPack] npm notice 3.5kB   esm/operations/securitySolutions.js                                    
[npmPack] npm notice 468B    esm/models/securitySolutionsMappers.js

openapi-sdkautomation · 2020-08-27T10:03:03Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a310d97 with merge commit c664728. SDK Automation 13.0.17.20200825.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.2.1.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.2.1.0.snupkg

openapi-sdkautomation · 2020-08-27T10:03:18Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a310d97 with merge commit c664728. SDK Automation 13.0.17.20200825.1

️✔️azure-mgmt-security [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-security
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-security
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 18.300% size of original (original: 166445 chars, delta: 30460 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model SecureScoreItem has a new parameter weight
[ChangeLog]   - Added operation group SecuritySolutionsOperations
[ChangeLog]   - Added operation group IotSensorsOperations
[ChangeLog]   - Added operation group IotDefenderSettingsOperations
[ChangeLog]   - Added operation group IotRecommendationsOperations
[ChangeLog]   - Added operation group ConnectorsOperations
[ChangeLog]   - Added operation group IotRecommendationTypesOperations
[ChangeLog]   - Added operation group IotAlertTypesOperations
[ChangeLog]   - Added operation group IotAlertsOperations
[ChangeLog]   - Added operation group SecuritySolutionsReferenceDataOperations

openapi-sdkautomation · 2020-08-27T10:03:18Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a310d97 with merge commit c664728. Schema Automation 13.0.17.20200825.1

️✔️security [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5657 passing (58s)
AzureResourceSchema has no registered package commands.

openapi-sdkautomation · 2020-08-27T10:03:47Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-27T10:04:00Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-27T12:48:21Z

Azure Pipelines successfully started running 1 pipeline(s).

erich-wang · 2020-08-28T14:13:34Z

It seems the SDK schema failure has nothing to do with this PR, @akning-ms, could you force merge it?

akning-ms · 2020-08-29T03:24:48Z

It seems the SDK schema failure has nothing to do with this PR, @akning-ms, could you force merge it?

It may impact ARM template, @leni-msft to take a look

leni-msft · 2020-08-29T07:32:20Z

Hi @erich-wang, it's the BreakingChange failure blocking the PR merge. The schema check is not required currently.
The schema generation failure is not related with this PR. It's caused by enum name conflict in Security's swagger in other apiVersion.

leni-msft · 2020-08-29T07:37:56Z

@surashed pls note. Currently the failing tags (package-composite-v1, etc.) have been excluded from schema generation scope. If your team want to generate ARM template schemas for those apiVersions, you'll need to fix the issues.

surashed and others added 10 commits August 13, 2020 09:29

Add SubAssessment event source type and add more automations examples

7ff73a7

Change Location isReadOnlu to false

8dcfac3

Test

4bf2361

Add new read/write location and add new type TrackedResourceLocation

b80ad9b

Minor

193945c

minor

f481945

prettier fixes

49286fe

Change variable name to TrackedResourceLocation

e58a0d7

Change type name TrackedResourceLocation to AzureTrackedResourceLocation

a4cf298

merge with upstream/master

18aa485

openapi-assignment-bot bot assigned erich-wang Aug 27, 2020

Update automations example

a310d97

erich-wang approved these changes Aug 28, 2020

View reviewed changes

akning-ms merged commit c664728 into Azure:master Aug 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change type name 'TrackedResourceLocation' to 'AzureTrackedResourceLocation' #10613

Change type name 'TrackedResourceLocation' to 'AzureTrackedResourceLocation' #10613

surashed commented Aug 27, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 27, 2020 •

edited

Loading

azure-pipelines bot commented Aug 27, 2020

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

azure-pipelines bot commented Aug 27, 2020

erich-wang commented Aug 28, 2020

akning-ms commented Aug 29, 2020

leni-msft commented Aug 29, 2020

leni-msft commented Aug 29, 2020

Change type name 'TrackedResourceLocation' to 'AzureTrackedResourceLocation' #10613

Change type name 'TrackedResourceLocation' to 'AzureTrackedResourceLocation' #10613

Conversation

surashed commented Aug 27, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 27, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 27, 2020

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Aug 27, 2020

erich-wang commented Aug 28, 2020

akning-ms commented Aug 29, 2020

leni-msft commented Aug 29, 2020

leni-msft commented Aug 29, 2020

surashed commented Aug 27, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading