Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atchub pe preview microsoft.hybrid compute 2020 08 15 preview #10610

Conversation

Atchub
Copy link
Contributor

@Atchub Atchub commented Aug 27, 2020

this PR is to add the Private endpoint scenario for HybridCompute . It includes already reviewed changes from #10496
the differences being

  1. the API version is changed to Preview
  2. privateLinkScopedResources property is added on Machine resource to introduce the Privatelinkscope information on Machine
  3. linkedResources list in ScopedResource is changed to a string from an array of strings to simplify the scenario.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 27, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9300f63 with merge commit 4c9f2c0. SDK Automation 13.0.17.20200825.1
  • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/hybridComputeManagementClient.js → ./dist/arm-hybridcompute.js...
    [npmPack] created ./dist/arm-hybridcompute.js in 419ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 128.1kB dist/arm-hybridcompute.js                            
    [npmPack] npm notice 44.0kB  dist/arm-hybridcompute.min.js                        
    [npmPack] npm notice 2.1kB   esm/hybridComputeManagementClient.js                 
    [npmPack] npm notice 2.6kB   esm/hybridComputeManagementClientContext.js          
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 615B    esm/operations/index.js                              
    [npmPack] npm notice 11.1kB  esm/operations/machineExtensions.js                  
    [npmPack] npm notice 989B    esm/models/machineExtensionsMappers.js               
    [npmPack] npm notice 5.9kB   esm/operations/machines.js                           
    [npmPack] npm notice 918B    esm/models/machinesMappers.js                        
    [npmPack] npm notice 45.6kB  esm/models/mappers.js                                
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                         
    [npmPack] npm notice 458B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 2.8kB   esm/models/parameters.js                             
    [npmPack] npm notice 9.2kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 1.0kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 3.9kB   esm/operations/privateLinkResources.js               
    [npmPack] npm notice 1.0kB   esm/models/privateLinkResourcesMappers.js            
    [npmPack] npm notice 8.6kB   esm/operations/privateLinkScopedResources.js         
    [npmPack] npm notice 1.0kB   esm/models/privateLinkScopedResourcesMappers.js      
    [npmPack] npm notice 9.6kB   esm/operations/privateLinkScopes.js                  
    [npmPack] npm notice 1.0kB   esm/models/privateLinkScopesMappers.js               
    [npmPack] npm notice 1.0kB   rollup.config.js                                     
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 252.5kB dist/arm-hybridcompute.js.map                        
    [npmPack] npm notice 35.6kB  dist/arm-hybridcompute.min.js.map                    
    [npmPack] npm notice 868B    esm/hybridComputeManagementClient.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/hybridComputeManagementClient.js.map             
    [npmPack] npm notice 524B    esm/hybridComputeManagementClientContext.d.ts.map    
    [npmPack] npm notice 1.4kB   esm/hybridComputeManagementClientContext.js.map      
    [npmPack] npm notice 16.6kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 273B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 288B    esm/operations/index.js.map                          
    [npmPack] npm notice 2.8kB   esm/operations/machineExtensions.d.ts.map            
    [npmPack] npm notice 5.2kB   esm/operations/machineExtensions.js.map              
    [npmPack] npm notice 505B    esm/models/machineExtensionsMappers.d.ts.map         
    [npmPack] npm notice 518B    esm/models/machineExtensionsMappers.js.map           
    [npmPack] npm notice 2.7kB   esm/operations/machines.d.ts.map                     
    [npmPack] npm notice 3.7kB   esm/operations/machines.js.map                       
    [npmPack] npm notice 455B    esm/models/machinesMappers.d.ts.map                  
    [npmPack] npm notice 468B    esm/models/machinesMappers.js.map                    
    [npmPack] npm notice 2.3kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 25.5kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 908B    esm/operations/operations.js.map                     
    [npmPack] npm notice 212B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 225B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 682B    esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 2.1kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 530B    esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 543B    esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 1.7kB   esm/operations/privateLinkResources.d.ts.map         
    [npmPack] npm notice 2.2kB   esm/operations/privateLinkResources.js.map           
    [npmPack] npm notice 518B    esm/models/privateLinkResourcesMappers.d.ts.map      
    [npmPack] npm notice 531B    esm/models/privateLinkResourcesMappers.js.map        
    [npmPack] npm notice 2.5kB   esm/operations/privateLinkScopedResources.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/privateLinkScopedResources.js.map     
    [npmPack] npm notice 530B    esm/models/privateLinkScopedResourcesMappers.d.ts.map
    [npmPack] npm notice 543B    esm/models/privateLinkScopedResourcesMappers.js.map  
    [npmPack] npm notice 3.7kB   esm/operations/privateLinkScopes.d.ts.map            
    [npmPack] npm notice 5.4kB   esm/operations/privateLinkScopes.js.map              
    [npmPack] npm notice 522B    esm/models/privateLinkScopesMappers.d.ts.map         
    [npmPack] npm notice 535B    esm/models/privateLinkScopesMappers.js.map           
    [npmPack] npm notice 3.5kB   README.md                                            
    [npmPack] npm notice 1.4kB   esm/hybridComputeManagementClient.d.ts               
    [npmPack] npm notice 2.3kB   src/hybridComputeManagementClient.ts                 
    [npmPack] npm notice 834B    esm/hybridComputeManagementClientContext.d.ts        
    [npmPack] npm notice 2.3kB   src/hybridComputeManagementClientContext.ts          
    [npmPack] npm notice 47.5kB  esm/models/index.d.ts                                
    [npmPack] npm notice 299B    esm/operations/index.d.ts                            
    [npmPack] npm notice 45.4kB  src/models/index.ts                                  
    [npmPack] npm notice 583B    src/operations/index.ts                              
    [npmPack] npm notice 8.0kB   esm/operations/machineExtensions.d.ts                
    [npmPack] npm notice 14.9kB  src/operations/machineExtensions.ts                  
    [npmPack] npm notice 679B    esm/models/machineExtensionsMappers.d.ts             
    [npmPack] npm notice 994B    src/models/machineExtensionsMappers.ts               
    [npmPack] npm notice 6.7kB   esm/operations/machines.d.ts                         
    [npmPack] npm notice 12.7kB  src/operations/machines.ts                           
    [npmPack] npm notice 608B    esm/models/machinesMappers.d.ts                      
    [npmPack] npm notice 926B    src/models/machinesMappers.ts                        
    [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts                              
    [npmPack] npm notice 36.4kB  src/models/mappers.ts                                
    [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                       

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9300f63 with merge commit 4c9f2c0. SDK Automation 13.0.17.20200825.1
  • ⚠️azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridcompute
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridcompute
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 46.038% size of original (original: 32506 chars, delta: 14965 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model MachineProperties has a new parameter os_sku
    [ChangeLog]   - Model MachineProperties has a new parameter ad_fqdn
    [ChangeLog]   - Model MachineProperties has a new parameter domain_name
    [ChangeLog]   - Model MachineProperties has a new parameter private_link_scoped_resources
    [ChangeLog]   - Model MachineProperties has a new parameter dns_fqdn
    [ChangeLog]   - Model MachineProperties has a new parameter vm_uuid
    [ChangeLog]   - Model Machine has a new parameter ad_fqdn
    [ChangeLog]   - Model Machine has a new parameter os_sku
    [ChangeLog]   - Model Machine has a new parameter domain_name
    [ChangeLog]   - Model Machine has a new parameter private_link_scoped_resources
    [ChangeLog]   - Model Machine has a new parameter dns_fqdn
    [ChangeLog]   - Model Machine has a new parameter vm_uuid
    [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
    [ChangeLog]   - Added operation group PrivateLinkScopedResourcesOperations
    [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
    [ChangeLog]   - Added operation group PrivateLinkScopesOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model ErrorResponse has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9300f63 with merge commit 4c9f2c0. SDK Automation 13.0.17.20200825.1
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.HybridCompute [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    azure-resource-manager-schemas - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 9300f63 with merge commit 4c9f2c0. Schema Automation 13.0.17.20200825.1
    • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5649 passing (1m)
        AzureResourceSchema has no registered package commands.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 27, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 28, 2020
      @Atchub
      Copy link
      Contributor Author

      Atchub commented Aug 28, 2020

      @fengzhou-msft , can you please review

      @fengzhou-msft fengzhou-msft merged commit 4c9f2c0 into Azure:master Aug 31, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      5 participants