-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2020-06-01-preview] Update namedvalue contract for keyvault #10604
[2020-06-01-preview] Update namedvalue contract for keyvault #10604
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Please reconfirm if any of the following is true. On brief look I don't see this as the case! Please confirm and update the check list and remove WaitForARMFeedback tag. |
@njuCZ can you please review this and merge if you are OK? |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this API is not public, there is no SDK to break.
* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview * Updates readme * Updates API version in new specs and examples * Add support in API Management for Availability Zones (#10284) * apim in azs * fix prettier check * PATCH should return 200 OK (#10328) * add support for PATCH returning 200 OK * CI fixes prettier fix CI fixes part 2 * Password no longer a mandatory property when uploading Certificates * add missing x-ms-odata extension for filter support * +gatewayhostnameconfiguration protocol changes (#10292) * [2020-06-01-preview] Update Oauth Server secrets Contract (#10602) * Oauth server secrets contract * fix azureMonitor enum * API Management Service Deleted Services Resource (#10607) * API Management Service Deleted Services Resource * Path fix * Lint + custom-words fixes * Location URI parameter for deletedservices Resource * GET for deletedservices by service name * Remove resourceGroupName from resource path * fixes * schema for purge operation * perttier applied * 204 response code added Co-authored-by: REDMOND\glfeokti <[email protected]> * OperationNameFormat property added to Diagnostic contract (#10641) * OperationNameFormat property added to Diagnostic contract * add azuremonitor to update contract Co-authored-by: REDMOND\glfeokti <[email protected]> * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331) * Change Network Status response contract * Update examples for network status contract * identityClientId support (#10776) * [2020-06-01-preview] Update namedvalue contract for keyvault (#10604) * update namedvalue contract for keyvault * add examples * separate out create contract * common create contract * fix examples * Data Masking settings for Diagnostic (#11033) * Data Masking settings for Diagnostic * Move dataMasking under HttpMessageDiagnostic Co-authored-by: REDMOND\glfeokti <[email protected]> * Add isolated skutype (#11029) * cache entity (#11098) * [2020-06-01-preview] update certificate contract for KeyVault (#11097) * The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (#11227) * secret ok in POST operation * fix prettier * fix example (#11249) Co-authored-by: maksimkim <[email protected]> Co-authored-by: promoisha <[email protected]> Co-authored-by: REDMOND\glfeokti <[email protected]> Co-authored-by: RupengLiu <[email protected]> Co-authored-by: JJ <[email protected]> Co-authored-by: Kacie <[email protected]>
* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview * Updates readme * Updates API version in new specs and examples * Add support in API Management for Availability Zones (Azure#10284) * apim in azs * fix prettier check * PATCH should return 200 OK (Azure#10328) * add support for PATCH returning 200 OK * CI fixes prettier fix CI fixes part 2 * Password no longer a mandatory property when uploading Certificates * add missing x-ms-odata extension for filter support * +gatewayhostnameconfiguration protocol changes (Azure#10292) * [2020-06-01-preview] Update Oauth Server secrets Contract (Azure#10602) * Oauth server secrets contract * fix azureMonitor enum * API Management Service Deleted Services Resource (Azure#10607) * API Management Service Deleted Services Resource * Path fix * Lint + custom-words fixes * Location URI parameter for deletedservices Resource * GET for deletedservices by service name * Remove resourceGroupName from resource path * fixes * schema for purge operation * perttier applied * 204 response code added Co-authored-by: REDMOND\glfeokti <[email protected]> * OperationNameFormat property added to Diagnostic contract (Azure#10641) * OperationNameFormat property added to Diagnostic contract * add azuremonitor to update contract Co-authored-by: REDMOND\glfeokti <[email protected]> * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (Azure#10331) * Change Network Status response contract * Update examples for network status contract * identityClientId support (Azure#10776) * [2020-06-01-preview] Update namedvalue contract for keyvault (Azure#10604) * update namedvalue contract for keyvault * add examples * separate out create contract * common create contract * fix examples * Data Masking settings for Diagnostic (Azure#11033) * Data Masking settings for Diagnostic * Move dataMasking under HttpMessageDiagnostic Co-authored-by: REDMOND\glfeokti <[email protected]> * Add isolated skutype (Azure#11029) * cache entity (Azure#11098) * [2020-06-01-preview] update certificate contract for KeyVault (Azure#11097) * The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (Azure#11227) * secret ok in POST operation * fix prettier * fix example (Azure#11249) Co-authored-by: maksimkim <[email protected]> Co-authored-by: promoisha <[email protected]> Co-authored-by: REDMOND\glfeokti <[email protected]> Co-authored-by: RupengLiu <[email protected]> Co-authored-by: JJ <[email protected]> Co-authored-by: Kacie <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.