Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2020-06-01-preview] Update namedvalue contract for keyvault #10604

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Aug 27, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 27, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@solankisamir solankisamir added 2020-06-01-preview API Management WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2144c49 with merge commit f8fdce2c31392bd18cef5b69b6b8908079dfc7a2. SDK Automation 13.0.17.20200918.2
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
  • ️✔️@azure/arm-apimanagement [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
    [npmPack] created ./dist/arm-apimanagement.js in 1.4s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.4kB  esm/operations/api.js                                  
    [npmPack] npm notice 9.8kB   esm/operations/apiDiagnostic.js                        
    [npmPack] npm notice 2.8kB   esm/models/apiDiagnosticMappers.js                     
    [npmPack] npm notice 2.0kB   esm/operations/apiExport.js                            
    [npmPack] npm notice 466B    esm/models/apiExportMappers.js                         
    [npmPack] npm notice 9.6kB   esm/operations/apiIssue.js                             
    [npmPack] npm notice 8.8kB   esm/operations/apiIssueAttachment.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueAttachmentMappers.js                
    [npmPack] npm notice 8.7kB   esm/operations/apiIssueComment.js                      
    [npmPack] npm notice 2.7kB   esm/models/apiIssueCommentMappers.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueMappers.js                          
    [npmPack] npm notice 6.0kB   esm/apiManagementClient.js                             
    [npmPack] npm notice 2.6kB   esm/apiManagementClientContext.js                      
    [npmPack] npm notice 2.4kB   esm/operations/apiManagementOperations.js              
    [npmPack] npm notice 468B    esm/models/apiManagementOperationsMappers.js           
    [npmPack] npm notice 21.7kB  esm/operations/apiManagementService.js                 
    [npmPack] npm notice 2.9kB   esm/models/apiManagementServiceMappers.js              
    [npmPack] npm notice 2.8kB   esm/operations/apiManagementServiceSkus.js             
    [npmPack] npm notice 515B    esm/models/apiManagementServiceSkusMappers.js          
    [npmPack] npm notice 3.1kB   esm/models/apiMappers.js                               
    [npmPack] npm notice 9.8kB   esm/operations/apiOperation.js                         
    [npmPack] npm notice 2.8kB   esm/models/apiOperationMappers.js                      
    [npmPack] npm notice 7.9kB   esm/operations/apiOperationPolicy.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiOperationPolicyMappers.js                
    [npmPack] npm notice 7.1kB   esm/operations/apiPolicy.js                            
    [npmPack] npm notice 2.7kB   esm/models/apiPolicyMappers.js                         
    [npmPack] npm notice 2.8kB   esm/operations/apiProduct.js                           
    [npmPack] npm notice 2.6kB   esm/models/apiProductMappers.js                        
    [npmPack] npm notice 9.7kB   esm/operations/apiRelease.js                           
    [npmPack] npm notice 2.8kB   esm/models/apiReleaseMappers.js                        
    [npmPack] npm notice 2.8kB   esm/operations/apiRevision.js                          
    [npmPack] npm notice 473B    esm/models/apiRevisionMappers.js                       
    [npmPack] npm notice 9.9kB   esm/operations/apiSchema.js                            
    [npmPack] npm notice 2.7kB   esm/models/apiSchemaMappers.js                         
    [npmPack] npm notice 8.5kB   esm/operations/apiTagDescription.js                    
    [npmPack] npm notice 2.8kB   esm/models/apiTagDescriptionMappers.js                 
    [npmPack] npm notice 9.4kB   esm/operations/apiVersionSet.js                        
    [npmPack] npm notice 2.8kB   esm/models/apiVersionSetMappers.js                     
    [npmPack] npm notice 1.3MB   dist/arm-apimanagement.js                              
    [npmPack] npm notice 483.3kB dist/arm-apimanagement.min.js                          
    [npmPack] npm notice 10.8kB  esm/operations/authorizationServer.js                  
    [npmPack] npm notice 2.9kB   esm/models/authorizationServerMappers.js               
    [npmPack] npm notice 10.3kB  esm/operations/backend.js                              
    [npmPack] npm notice 2.8kB   esm/models/backendMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/cache.js                                
    [npmPack] npm notice 2.7kB   esm/models/cacheMappers.js                             
    [npmPack] npm notice 7.9kB   esm/operations/certificate.js                          
    [npmPack] npm notice 2.8kB   esm/models/certificateMappers.js                       
    [npmPack] npm notice 6.4kB   esm/operations/contentType.js                          
    [npmPack] npm notice 8.4kB   esm/operations/contentTypeContentItem.js               
    [npmPack] npm notice 2.8kB   esm/models/contentTypeContentItemMappers.js            
    [npmPack] npm notice 2.7kB   esm/models/contentTypeMappers.js                       
    [npmPack] npm notice 6.8kB   esm/operations/delegationSettings.js                   
    [npmPack] npm notice 2.7kB   esm/models/delegationSettingsMappers.js                
    [npmPack] npm notice 4.4kB   esm/operations/deletedServices.js                      
    [npmPack] npm notice 2.7kB   esm/models/deletedServicesMappers.js                   
    [npmPack] npm notice 9.3kB   esm/operations/diagnostic.js                           
    [npmPack] npm notice 2.8kB   esm/models/diagnosticMappers.js                        
    [npmPack] npm notice 9.2kB   esm/operations/emailTemplate.js                        
    [npmPack] npm notice 2.8kB   esm/models/emailTemplateMappers.js                     
    [npmPack] npm notice 12.9kB  esm/operations/gateway.js                              
    [npmPack] npm notice 6.5kB   esm/operations/gatewayApi.js                           
    [npmPack] npm notice 2.7kB   esm/models/gatewayApiMappers.js                        
    [npmPack] npm notice 8.7kB   esm/operations/gatewayHostnameConfiguration.js         
    [npmPack] npm notice 2.8kB   esm/models/gatewayHostnameConfigurationMappers.js      
    [npmPack] npm notice 2.9kB   esm/models/gatewayMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/group.js                                
    [npmPack] npm notice 2.8kB   esm/models/groupMappers.js                             
    [npmPack] npm notice 6.1kB   esm/operations/groupUser.js                            
    [npmPack] npm notice 2.6kB   esm/models/groupUserMappers.js                         
    [npmPack] npm notice 11.0kB  esm/operations/identityProvider.js                     
    [npmPack] npm notice 2.9kB   esm/models/identityProviderMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                    
    [npmPack] npm notice 2.6kB   esm/operations/index.js                                
    [npmPack] npm notice 3.8kB   esm/operations/issue.js                                
    [npmPack] npm notice 2.6kB   esm/models/issueMappers.js                             
    [npmPack] npm notice 9.1kB   esm/operations/logger.js                               
    [npmPack] npm notice 2.8kB   esm/models/loggerMappers.js                            
    [npmPack] npm notice 323.2kB esm/models/mappers.js                                  
    [npmPack] npm notice 13.3kB  esm/operations/namedValue.js                           
    [npmPack] npm notice 2.8kB   esm/models/namedValueMappers.js                        
    [npmPack] npm notice 3.4kB   esm/operations/networkStatus.js                        
    [npmPack] npm notice 515B    esm/models/networkStatusMappers.js                     
    [npmPack] npm notice 5.0kB   esm/operations/notification.js                         
    [npmPack] npm notice 2.6kB   esm/models/notificationMappers.js                      
    [npmPack] npm notice 5.9kB   esm/operations/notificationRecipientEmail.js           
    [npmPack] npm notice 2.7kB   esm/models/notificationRecipientEmailMappers.js        

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2020

azure-sdk-for-net

failed [Logs] [Expand Details]
  • Generate from 2144c49 with merge commit f8fdce2c31392bd18cef5b69b6b8908079dfc7a2. SDK Automation 13.0.17.20200918.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
  • Microsoft.Azure.Management.ApiManagement [View full logs]  [Preview SDK Changes]
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {} 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 2144c49 with merge commit f8fdce2c31392bd18cef5b69b6b8908079dfc7a2. SDK Automation 13.0.17.20200918.2
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_state_by_operation' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_state_by_api' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_state_by_product' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_state' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
      [AutoRest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    • ⚠️azure-mgmt-apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-apimanagement
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-apimanagement
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 5.687% size of original (original: 243506 chars, delta: 13848 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model NamedValueCreateContract has a new parameter key_vault
      [ChangeLog]   - Model DiagnosticContract has a new parameter operation_name_format
      [ChangeLog]   - Model AdditionalLocation has a new parameter zones
      [ChangeLog]   - Model NamedValueUpdateParameters has a new parameter key_vault
      [ChangeLog]   - Model NamedValueContract has a new parameter key_vault
      [ChangeLog]   - Model ApiManagementServiceUpdateParameters has a new parameter restore
      [ChangeLog]   - Model ApiManagementServiceResource has a new parameter restore
      [ChangeLog]   - Model ApiManagementServiceResource has a new parameter zones
      [ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter tls10_enabled
      [ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter tls11_enabled
      [ChangeLog]   - Model GatewayHostnameConfigurationContract has a new parameter http2_enabled
      [ChangeLog]   - Model ApiManagementServiceBaseProperties has a new parameter restore
      [ChangeLog]   - Added operation group DeletedServicesOperations
      [ChangeLog]   - Added operation group ContentTypeOperations
      [ChangeLog]   - Added operation group ContentTypeContentItemOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation CertificateOperations.create_or_update has a new signature
      [ChangeLog]   - Operation EmailTemplateOperations.update has a new signature
      [ChangeLog]   - Operation GatewayHostnameConfigurationOperations.create_or_update has a new signature
      [ChangeLog]   - Operation GatewayHostnameConfigurationOperations.delete has a new signature
      [ChangeLog]   - Operation SubscriptionOperations.create_or_update has a new signature
      [ChangeLog]   - Operation SubscriptionOperations.update has a new signature
      [ChangeLog]   - Operation UserConfirmationPasswordOperations.send has a new signature
      [ChangeLog]   - Operation UserOperations.delete has a new signature
      [ChangeLog]   - Operation LoggerOperations.delete has a new signature
      [ChangeLog]   - Operation EmailTemplateOperations.update has a new signature
      [ChangeLog]   - Operation CertificateOperations.create_or_update has a new signature
      [ChangeLog]   - Operation GatewayApiOperations.list_by_service has a new signature
      [ChangeLog]   - Operation GatewayHostnameConfigurationOperations.list_by_service has a new signature
      [ChangeLog]   - Operation GatewayOperations.list_by_service has a new signature
      [ChangeLog]   - Operation UserOperations.create_or_update has a new signature
      [ChangeLog]   - Model ConnectivityStatusContract has a new required parameter resource_type
      [ChangeLog]   - Model ConnectivityStatusContract has a new required parameter is_optional

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 27, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @chiragg4u
    Copy link
    Contributor

    Please reconfirm if any of the following is true. On brief look I don't see this as the case!
    Adding new API(s)
    Adding a new API version
    Adding a new service

    Please confirm and update the check list and remove WaitForARMFeedback tag.

    @solankisamir solankisamir removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 12, 2020
    @solankisamir
    Copy link
    Member Author

    @njuCZ can you please review this and merge if you are OK?

    @markcowl
    Copy link
    Member

    markcowl commented Oct 2, 2020

    /azp run automation - sdk

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since this API is not public, there is no SDK to break.

    @markcowl markcowl merged commit 977e3b8 into Azure:apimanagement-2020-06-01-preview Oct 2, 2020
    raych1 pushed a commit that referenced this pull request Oct 20, 2020
    * Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add support in API Management for Availability Zones (#10284)
    
    * apim in azs
    
    * fix prettier check
    
    * PATCH should return 200 OK (#10328)
    
    * add support for PATCH returning 200 OK
    
    * CI fixes
    
    prettier fix
    
    CI fixes part 2
    
    * Password no longer a mandatory property when uploading Certificates
    
    * add missing x-ms-odata extension for filter support
    
    * +gatewayhostnameconfiguration protocol changes (#10292)
    
    * [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)
    
    * Oauth server secrets contract
    
    * fix azureMonitor enum
    
    * API Management Service Deleted Services Resource (#10607)
    
    * API Management Service Deleted Services Resource
    
    * Path fix
    
    * Lint + custom-words fixes
    
    * Location URI parameter for deletedservices Resource
    
    * GET for deletedservices by service name
    
    * Remove resourceGroupName from resource path
    
    * fixes
    
    * schema for purge operation
    
    * perttier applied
    
    * 204 response code added
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * OperationNameFormat property added to Diagnostic contract (#10641)
    
    * OperationNameFormat property added to Diagnostic contract
    
    * add azuremonitor to update contract
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)
    
    * Change Network Status response contract
    
    * Update examples for network status contract
    
    * identityClientId support (#10776)
    
    * [2020-06-01-preview] Update namedvalue contract for keyvault (#10604)
    
    * update namedvalue contract for keyvault
    
    * add examples
    
    * separate out create contract
    
    * common create contract
    
    * fix examples
    
    * Data Masking settings for Diagnostic (#11033)
    
    * Data Masking settings for Diagnostic
    
    * Move dataMasking under HttpMessageDiagnostic
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * Add isolated skutype (#11029)
    
    * cache entity (#11098)
    
    * [2020-06-01-preview] update certificate contract for KeyVault (#11097)
    
    * The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (#11227)
    
    * secret ok in POST operation
    
    * fix prettier
    
    * fix example (#11249)
    
    Co-authored-by: maksimkim <[email protected]>
    Co-authored-by: promoisha <[email protected]>
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    Co-authored-by: RupengLiu <[email protected]>
    Co-authored-by: JJ <[email protected]>
    Co-authored-by: Kacie <[email protected]>
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    * Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add support in API Management for Availability Zones (Azure#10284)
    
    * apim in azs
    
    * fix prettier check
    
    * PATCH should return 200 OK (Azure#10328)
    
    * add support for PATCH returning 200 OK
    
    * CI fixes
    
    prettier fix
    
    CI fixes part 2
    
    * Password no longer a mandatory property when uploading Certificates
    
    * add missing x-ms-odata extension for filter support
    
    * +gatewayhostnameconfiguration protocol changes (Azure#10292)
    
    * [2020-06-01-preview] Update Oauth Server secrets Contract (Azure#10602)
    
    * Oauth server secrets contract
    
    * fix azureMonitor enum
    
    * API Management Service Deleted Services Resource (Azure#10607)
    
    * API Management Service Deleted Services Resource
    
    * Path fix
    
    * Lint + custom-words fixes
    
    * Location URI parameter for deletedservices Resource
    
    * GET for deletedservices by service name
    
    * Remove resourceGroupName from resource path
    
    * fixes
    
    * schema for purge operation
    
    * perttier applied
    
    * 204 response code added
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * OperationNameFormat property added to Diagnostic contract (Azure#10641)
    
    * OperationNameFormat property added to Diagnostic contract
    
    * add azuremonitor to update contract
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (Azure#10331)
    
    * Change Network Status response contract
    
    * Update examples for network status contract
    
    * identityClientId support (Azure#10776)
    
    * [2020-06-01-preview] Update namedvalue contract for keyvault (Azure#10604)
    
    * update namedvalue contract for keyvault
    
    * add examples
    
    * separate out create contract
    
    * common create contract
    
    * fix examples
    
    * Data Masking settings for Diagnostic (Azure#11033)
    
    * Data Masking settings for Diagnostic
    
    * Move dataMasking under HttpMessageDiagnostic
    
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    
    * Add isolated skutype (Azure#11029)
    
    * cache entity (Azure#11098)
    
    * [2020-06-01-preview] update certificate contract for KeyVault (Azure#11097)
    
    * The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (Azure#11227)
    
    * secret ok in POST operation
    
    * fix prettier
    
    * fix example (Azure#11249)
    
    Co-authored-by: maksimkim <[email protected]>
    Co-authored-by: promoisha <[email protected]>
    Co-authored-by: REDMOND\glfeokti <[email protected]>
    Co-authored-by: RupengLiu <[email protected]>
    Co-authored-by: JJ <[email protected]>
    Co-authored-by: Kacie <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants