Update KeyVault.json - Add VaultAccessPolicyChangedEvent #10569

jlichwa · 2020-08-24T17:48:12Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-24T17:48:16Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-24T17:48:28Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-24T17:51:06Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-24T17:51:33Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2435eb0 with merge commit 3ab1e68. SDK Automation 13.0.17.20200807.2
️✔️eventgrid/2018-01-01 [View full logs] [Release SDK Changes]
- eventgrid.2018-01-01.zip

openapi-sdkautomation · 2020-08-24T17:51:44Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-24T17:51:57Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-24T17:52:03Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 2435eb0 with merge commit 3ab1e68. SDK Automation 13.0.17.20200807.2

️✔️azure-eventgrid [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-eventgrid
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-eventgrid
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Traceback (most recent call last):
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
[ChangeLog]     "__main__", mod_spec)
[ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
[ChangeLog]     exec(code, run_globals)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
[ChangeLog]     change_log = build_change_log(old_report, new_report)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
[ChangeLog]     change_log.operation(diff_line)
[ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
[ChangeLog]     _, operation_name, *remaining_path = path
[ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
[ChangeLog] Size of delta 48.293% size of original (original: 95568 chars, delta: 46153 chars)

openapi-sdkautomation · 2020-08-24T17:52:03Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-24T17:52:05Z

azure-sdk-for-js - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 2435eb0 with merge commit 3ab1e68. SDK Automation 13.0.17.20200807.2

❌@azure/eventgrid [View full logs] [Release SDK Changes]

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 2
[npmPack] npm ERR! @azure/[email protected] build: `tsc && rollup -c rollup.config.js && npm run minify`
[npmPack] npm ERR! Exit status 2
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/[email protected] build script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-08-24T21_26_56_241Z-debug.log
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 2
[npmPack] npm ERR! @azure/[email protected] prepack: `npm install && npm run build`
[npmPack] npm ERR! Exit status 2
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/[email protected] prepack script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-08-24T21_26_56_263Z-debug.log
Failed to create the package @azure/eventgrid.
Error: npm pack npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm notice created a lockfile as package-lock.json. You should commit this file.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @azure/[email protected] build: `tsc && rollup -c rollup.config.js && npm run minify`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the @azure/[email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:

npm ERR!     /home/sdk/.npm/_logs/2020-08-24T21_26_56_241Z-debug.log

npm ERR! code ELIFECYCLE

npm ERR! errno 2

npm ERR! @azure/[email protected] prepack: npm install && npm run build

npm ERR! Exit status 2

npm ERR!

npm ERR! Failed at the @azure/[email protected] prepack script.

npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:

npm ERR!     /home/sdk/.npm/_logs/2020-08-24T21_26_56_263Z-debug.log

, {}

openapi-sdkautomation · 2020-08-24T17:52:05Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-24T17:52:24Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

jlichwa · 2020-08-24T18:42:22Z

#sign-off

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json

azure-pipelines · 2020-08-24T20:00:30Z

Azure Pipelines successfully started running 1 pipeline(s).

jlichwa · 2020-08-24T20:12:44Z

#sign-off

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json

Update KeyVault.json

c3bcedf

jlichwa requested review from ahamad-MS and Kishp01 as code owners August 24, 2020 17:48

openapi-assignment-bot bot assigned jhendrixMSFT Aug 24, 2020

jhendrixMSFT requested changes Aug 24, 2020

View reviewed changes

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json Outdated Show resolved Hide resolved

Update KeyVault.json

2435eb0

Kishp01 approved these changes Aug 24, 2020

View reviewed changes

jhendrixMSFT reviewed Aug 24, 2020

View reviewed changes

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json Show resolved Hide resolved

jhendrixMSFT approved these changes Aug 24, 2020

View reviewed changes

jhendrixMSFT merged commit 3ab1e68 into master Aug 24, 2020

JackTn deleted the jlichwa-patch-4 branch August 9, 2021 10:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update KeyVault.json - Add VaultAccessPolicyChangedEvent #10569

Update KeyVault.json - Add VaultAccessPolicyChangedEvent #10569

jlichwa commented Aug 24, 2020

openapi-pipeline-app bot commented Aug 24, 2020 •

edited

Loading

azure-pipelines bot commented Aug 24, 2020

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

jlichwa commented Aug 24, 2020

azure-pipelines bot commented Aug 24, 2020

jlichwa commented Aug 24, 2020

Update KeyVault.json - Add VaultAccessPolicyChangedEvent #10569

Update KeyVault.json - Add VaultAccessPolicyChangedEvent #10569

Conversation

jlichwa commented Aug 24, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 24, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 24, 2020

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 24, 2020 • edited Loading

Trenton Generation - Release

jlichwa commented Aug 24, 2020

azure-pipelines bot commented Aug 24, 2020

jlichwa commented Aug 24, 2020

openapi-pipeline-app bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 24, 2020 •

edited

Loading