-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version 2020-01-01 of security alert policies for Orcas #10527
Remove version 2020-01-01 of security alert policies for Orcas #10527
Conversation
…into ayshpige/RemoveVersion2020ForSecurityAlertPoliciesForOrcas
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
It seems you're removing APIs from stable version, please check Breaking Change Policy. |
Hi @erich-wang to clarify, this PR is not actually removing something - it is replacing an API in higher API version by a lower API version. Well I am not quite sure this is breaking changes or not. At least the breaking changes CI says no |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Supersedes #10474 |
FYI, breaking changes CI tools have a known issue: it will not report a break change in the case of deleting a swagger file |
Hi @erich-wang, This PR removes swagger files of APIs which were not exposed in the manifest. Therefore customers don’t use them. Moreover, these APIs didn’t add any new functionality. |
Per the discussion with API review board, 2020-01-01 version has not been enabled so approve the revert back the changes. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.