Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription quick fix #10486

Merged
merged 5 commits into from
Aug 21, 2020
Merged

subscription quick fix #10486

merged 5 commits into from
Aug 21, 2020

Conversation

dw511214992
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@dw511214992 dw511214992 requested a review from navysingla August 17, 2020 02:09
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'Subscription_CreateAlias' to 'Alias_Create'. This will impact generated code.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L164:7
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L152:7
1008 - ModifiedOperationId The operation id has been changed from 'Subscription_GetAlias' to 'Alias_Get'. This will impact generated code.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L213:7
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L198:7
1008 - ModifiedOperationId The operation id has been changed from 'Subscription_DeleteAlias' to 'Alias_Delete'. This will impact generated code.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L247:7
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L229:7
1008 - ModifiedOperationId The operation id has been changed from 'Subscription_ListAlias' to 'Alias_List'. This will impact generated code.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L283:7
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L262:7
1034 - AddedRequiredProperty The new version has new required property 'properties' that was not found in the old version.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L204:13
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L189:13
1034 - AddedRequiredProperty The new version has new required property 'properties' that was not found in the old version.
New: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L424:5
Old: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L400:5
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b5cd6fa with merge commit 09a8448. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-subscriptions [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/subscriptionClient.js → ./dist/arm-subscriptions.js...
    [npmPack] created ./dist/arm-subscriptions.js in 200ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 4.6kB   esm/operations/alias.js                          
    [npmPack] npm notice 546B    esm/models/aliasMappers.js                       
    [npmPack] npm notice 46.8kB  dist/arm-subscriptions.js                        
    [npmPack] npm notice 15.0kB  dist/arm-subscriptions.min.js                    
    [npmPack] npm notice 345B    esm/models/index.js                              
    [npmPack] npm notice 508B    esm/operations/index.js                          
    [npmPack] npm notice 15.3kB  esm/models/mappers.js                            
    [npmPack] npm notice 1.5kB   esm/operations/operations.js                     
    [npmPack] npm notice 458B    esm/models/operationsMappers.js                  
    [npmPack] npm notice 1.7kB   esm/models/parameters.js                         
    [npmPack] npm notice 990B    rollup.config.js                                 
    [npmPack] npm notice 1.6kB   esm/subscriptionClient.js                        
    [npmPack] npm notice 2.2kB   esm/subscriptionClientContext.js                 
    [npmPack] npm notice 3.6kB   esm/operations/subscriptionOperations.js         
    [npmPack] npm notice 508B    esm/models/subscriptionOperationsMappers.js      
    [npmPack] npm notice 3.8kB   esm/operations/subscriptions.js                  
    [npmPack] npm notice 498B    esm/models/subscriptionsMappers.js               
    [npmPack] npm notice 2.2kB   esm/operations/tenants.js                        
    [npmPack] npm notice 441B    esm/models/tenantsMappers.js                     
    [npmPack] npm notice 1.7kB   package.json                                     
    [npmPack] npm notice 457B    tsconfig.json                                    
    [npmPack] npm notice 1.7kB   esm/operations/alias.d.ts.map                    
    [npmPack] npm notice 2.8kB   esm/operations/alias.js.map                      
    [npmPack] npm notice 254B    esm/models/aliasMappers.d.ts.map                 
    [npmPack] npm notice 267B    esm/models/aliasMappers.js.map                   
    [npmPack] npm notice 100.0kB dist/arm-subscriptions.js.map                    
    [npmPack] npm notice 14.8kB  dist/arm-subscriptions.min.js.map                
    [npmPack] npm notice 6.4kB   esm/models/index.d.ts.map                        
    [npmPack] npm notice 225B    esm/operations/index.d.ts.map                    
    [npmPack] npm notice 126B    esm/models/index.js.map                          
    [npmPack] npm notice 240B    esm/operations/index.js.map                      
    [npmPack] npm notice 1.2kB   esm/models/mappers.d.ts.map                      
    [npmPack] npm notice 9.0kB   esm/models/mappers.js.map                        
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map               
    [npmPack] npm notice 908B    esm/operations/operations.js.map                 
    [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map            
    [npmPack] npm notice 228B    esm/models/operationsMappers.js.map              
    [npmPack] npm notice 443B    esm/models/parameters.d.ts.map                   
    [npmPack] npm notice 1.2kB   esm/models/parameters.js.map                     
    [npmPack] npm notice 735B    esm/subscriptionClient.d.ts.map                  
    [npmPack] npm notice 918B    esm/subscriptionClient.js.map                    
    [npmPack] npm notice 424B    esm/subscriptionClientContext.d.ts.map           
    [npmPack] npm notice 1.2kB   esm/subscriptionClientContext.js.map             
    [npmPack] npm notice 1.6kB   esm/operations/subscriptionOperations.d.ts.map   
    [npmPack] npm notice 2.2kB   esm/operations/subscriptionOperations.js.map     
    [npmPack] npm notice 255B    esm/models/subscriptionOperationsMappers.d.ts.map
    [npmPack] npm notice 268B    esm/models/subscriptionOperationsMappers.js.map  
    [npmPack] npm notice 1.8kB   esm/operations/subscriptions.d.ts.map            
    [npmPack] npm notice 2.4kB   esm/operations/subscriptions.js.map              
    [npmPack] npm notice 244B    esm/models/subscriptionsMappers.d.ts.map         
    [npmPack] npm notice 257B    esm/models/subscriptionsMappers.js.map           
    [npmPack] npm notice 1.0kB   esm/operations/tenants.d.ts.map                  
    [npmPack] npm notice 1.4kB   esm/operations/tenants.js.map                    
    [npmPack] npm notice 199B    esm/models/tenantsMappers.d.ts.map               
    [npmPack] npm notice 212B    esm/models/tenantsMappers.js.map                 
    [npmPack] npm notice 3.3kB   README.md                                        
    [npmPack] npm notice 3.2kB   esm/operations/alias.d.ts                        
    [npmPack] npm notice 6.9kB   src/operations/alias.ts                          
    [npmPack] npm notice 236B    esm/models/aliasMappers.d.ts                     
    [npmPack] npm notice 523B    src/models/aliasMappers.ts                       
    [npmPack] npm notice 17.2kB  esm/models/index.d.ts                            
    [npmPack] npm notice 192B    esm/operations/index.d.ts                        
    [npmPack] npm notice 16.7kB  src/models/index.ts                              
    [npmPack] npm notice 476B    src/operations/index.ts                          
    [npmPack] npm notice 1.6kB   esm/models/mappers.d.ts                          
    [npmPack] npm notice 12.4kB  src/models/mappers.ts                            
    [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                   
    [npmPack] npm notice 2.3kB   src/operations/operations.ts                     
    [npmPack] npm notice 148B    esm/models/operationsMappers.d.ts                
    [npmPack] npm notice 422B    src/models/operationsMappers.ts                  
    [npmPack] npm notice 475B    esm/models/parameters.d.ts                       
    [npmPack] npm notice 1.7kB   src/models/parameters.ts                         
    [npmPack] npm notice 1.0kB   esm/subscriptionClient.d.ts                      
    [npmPack] npm notice 1.6kB   src/subscriptionClient.ts                        
    [npmPack] npm notice 649B    esm/subscriptionClientContext.d.ts               
    [npmPack] npm notice 2.0kB   src/subscriptionClientContext.ts                 
    [npmPack] npm notice 3.2kB   esm/operations/subscriptionOperations.d.ts       
    [npmPack] npm notice 6.5kB   src/operations/subscriptionOperations.ts         
    [npmPack] npm notice 198B    esm/models/subscriptionOperationsMappers.d.ts    
    [npmPack] npm notice 462B    src/models/subscriptionOperationsMappers.ts      
    [npmPack] npm notice 4.0kB   esm/operations/subscriptions.d.ts                
    [npmPack] npm notice 7.7kB   src/operations/subscriptions.ts                  
    [npmPack] npm notice 188B    esm/models/subscriptionsMappers.d.ts             
    [npmPack] npm notice 463B    src/models/subscriptionsMappers.ts               
    [npmPack] npm notice 2.0kB   esm/operations/tenants.d.ts                      
    [npmPack] npm notice 4.0kB   src/operations/tenants.ts                        
    [npmPack] npm notice 131B    esm/models/tenantsMappers.d.ts                   

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b5cd6fa with merge commit 09a8448. SDK Automation 13.0.17.20200807.2
  • ⚠️azure-mgmt-subscription [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-subscription
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-subscription
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 39.388% size of original (original: 9117 chars, delta: 3591 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation group AliasOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription_in_enrollment_account
    [ChangeLog]   - Removed operation SubscriptionOperations.create_csp_subscription
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription
    [ChangeLog]   - Removed operation group SubscriptionOperationOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from b5cd6fa with merge commit 09a8448. SDK Automation 13.0.17.20200807.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.Subscription [View full logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.Subscription.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=subscription /v:n /p:SkipTests=true , {} 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 2d594c9 with merge commit efd778cb013d124406f059e99a21b828b74d9ce0. SDK Automation 13.0.17.20200807.2
    • ⚠️azure-mgmt-subscription [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-subscription
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-subscription
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 39.395% size of original (original: 9118 chars, delta: 3592 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Added operation group AliasOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription_in_enrollment_account
      [ChangeLog]   - Removed operation SubscriptionOperations.create_csp_subscription
      [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription
      [ChangeLog]   - Removed operation group SubscriptionOperationOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    azure-resource-manager-schemas - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from b5cd6fa with merge commit 09a8448. Schema Automation 13.0.17.20200807.2
    • ️✔️subscription [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5619 passing (1m)
        AzureResourceSchema has no registered package commands.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 17, 2020

      Azure CLI Extension Generation - Release

      • Installation instruction for service account [Preview Changes]
        az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10486/azure-cli-extensions/Azure/azure-cli-extensions/account/account-0.1.0-py3-none-any.whl
      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b5cd6fa with merge commit 09a8448. Azure CLI Automation 13.0.17.20200807.2
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Subscription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantIdDescription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CanceledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RenamedSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnabledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasRequestProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
        [AutoRest] 
        [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
        [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
        [AutoRest] --------------------------------------------------------
        [AutoRest]   test-scenario:
        [AutoRest]     - name: /Alias/put/CreateAlias
        [AutoRest]     - name: /Alias/get/GetAlias
        [AutoRest]     - name: /Alias/get/GetAlias
        [AutoRest]     - name: /Subscription/post/cancelSubscription
        [AutoRest]     - name: /Subscription/post/enableSubscription
        [AutoRest]     - name: /Subscription/post/renameSubscription
        [AutoRest]     - name: /Subscriptions/get/getSubscription
        [AutoRest]     - name: /Subscriptions/get/listLocations
        [AutoRest]     - name: /Subscriptions/get/listSubscriptions
        [AutoRest]     - name: /Tenants/get/listTenants
        [AutoRest]     - name: /Alias/delete/DeleteAlias
        [AutoRest] --------------------------------------------------------

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @navysingla
      Copy link
      Contributor

      @qianwens Can we merge this PR?

      add configuration for latest tag
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @dw511214992
      Copy link
      Member Author

      Hi @navysingla the configuration of readme.go.md is added for latest tag. Please review it.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 18, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @navysingla
      Copy link
      Contributor

      @qianwens Can we merge this PR?

      @akning-ms
      Copy link
      Contributor

      akning-ms commented Aug 21, 2020

      Hi @navysingla, looks your PR include 3 validation issue:

      1. PrettierCheck failure which need to fix(refer to https://aka.ms/ci-fix)
      2. For breaking change which caused by change operation id. Looks 2020-09-01 is a very new version, can we let us whether it is official GA? if yes. you may refer to below process https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes
      3. Python SDK breaking change (caused by operation id change) Is this expected?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @dw511214992
      Copy link
      Member Author

      dw511214992 commented Aug 21, 2020

      Hi @akning-ms

      1. PrettierCheck failure which need to fix(refer to https://aka.ms/ci-fix)
        Answer: I have fixed PrettierCheck failure.
      2. For breaking change which caused by change operation id. Looks 2020-09-01 is a very new version, can we let us whether it is official GA? if yes. you may refer to below process https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes
        Answer: I change the operation id because the operation id is not in a standard format, which is not friendly to codegen. @navysingla Please check wether we need to refer to the above process.
      3. Python SDK breaking change (caused by operation id change) Is this expected?
        Answer: @navysingla please check whether it is allowed.

      @navysingla
      Copy link
      Contributor

      Hi @akning-ms

      1. PrettierCheck failure which need to fix(refer to https://aka.ms/ci-fix)
        Answer: I have fixed PrettierCheck failure.
      2. For breaking change which caused by change operation id. Looks 2020-09-01 is a very new version, can we let us whether it is official GA? if yes. you may refer to below process https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes
        Answer: I change the operation id because the operation id is not in a standard format, which is not friendly to codegen. @navysingla Please check wether we need to refer to the above process.
      3. Python SDK breaking change (caused by operation id change) Is this expected?
        Answer: @navysingla please check whether it is allowed.

      This is newly added version which is added last week. No SDK has been released yet for this version and API is not live yet for real customers, only internal testing users are using it.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @qianwens qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 21, 2020
      @qianwens qianwens merged commit 09a8448 into master Aug 21, 2020
      @JackTn JackTn deleted the subscription-swagger-quick-fix branch August 9, 2021 10:16
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      6 participants