Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10465

Merged
merged 3 commits into from
Aug 20, 2020
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10465

merged 3 commits into from
Aug 20, 2020

Conversation

sashahdo
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2020

[Staging] Swagger Validation Report

BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'grouping' renamed or removed?
New: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L2523:7
Old: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L2588:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service costmanagement [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10465/azure-cli-extensions/Azure/azure-cli-extensions/costmanagement/costmanagement-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 378268d with merge commit 38b9360. Azure CLI Automation 13.0.17.20200807.2
    Only show 100 items here, please refer to log for details.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigSorting' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DismissAlertPayload' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ForecastDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ForecastDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Alerts/get/BillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/BillingProfileAlerts
    [AutoRest]     - name: /Alerts/get/DepartmentAlerts
    [AutoRest]     - name: /Alerts/get/EnrollmentAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalBillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalSubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/InvoiceSectionAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/patch/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/patch/SubscriptionAlerts
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
    [AutoRest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
    [AutoRest]     - name: /Exports/get/ExportGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportsGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportsGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportsGetBySubscription
  • ️✔️costmanagement [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 378268d with merge commit 38b9360. SDK Automation 13.0.17.20200807.2
  • ⚠️azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-costmanagement
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-costmanagement
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 64.270% size of original (original: 34282 chars, delta: 22033 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Export has a new parameter run_history
    [ChangeLog]   - Model Export has a new parameter e_tag
    [ChangeLog]   - Model Export has a new parameter next_run_time_estimate
    [ChangeLog]   - Model CommonExportProperties has a new parameter run_history
    [ChangeLog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
    [ChangeLog]   - Model ExportExecution has a new parameter error
    [ChangeLog]   - Added operation DimensionsOperations.by_external_cloud_provider_type
    [ChangeLog]   - Added operation QueryOperations.usage_by_external_cloud_provider_type
    [ChangeLog]   - Added operation group ForecastOperations
    [ChangeLog]   - Added operation group ViewsOperations
    [ChangeLog]   - Added operation group AlertsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation ExportsOperations.get has a new signature
    [ChangeLog]   - Operation ExportsOperations.list has a new signature
    [ChangeLog]   - Model Export no longer has parameter tags

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 378268d with merge commit 38b9360. Schema Automation 13.0.17.20200807.2
    [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Skipping definition with path '/providers/Microsoft.Billing/departments/{departmentId}/providers/Microsoft.CostManagement/reports/{reportName}'.
    [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Using definition with path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.CostManagement/reports/{reportName}'.
  • ⚠️cost-management [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5632 passing (1m)
      [after_scripts|node]   9 failing
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @sashahdo
    Copy link
    Contributor Author

    sashahdo commented Aug 14, 2020

    the Grouping property is not supported in Forecast API, this change is to remove the property from Forecast in swagger to match the api. Hence the detected breaking change

    @erich-wang
    Copy link
    Member

    erich-wang commented Aug 18, 2020

    The title is for version 2020-06, not aligned with the changed file, could you pls clarify?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sashahdo
    Copy link
    Contributor Author

    The title is for version 2020-06, not aligned with the changed file, could you pls clarify?

    Thanks for pointing this out. I've moved the change to the appropriate version.

    @sashahdo sashahdo closed this Aug 18, 2020
    @sashahdo sashahdo reopened this Aug 18, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @erich-wang
    Copy link
    Member

    Based on comment from service team in #10464, the change is just bug fix for swagger spec, no change in API side, and currently there is no SDKs released for this API version, sign off this PR.

    @erich-wang erich-wang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 20, 2020
    @erich-wang erich-wang merged commit 38b9360 into Azure:master Aug 20, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants