-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10465
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 #10465
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'grouping' renamed or removed? New: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L2523:7 Old: Microsoft.CostManagement/stable/2020-06-01/costmanagement.json#L2588:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
the Grouping property is not supported in Forecast API, this change is to remove the property from Forecast in swagger to match the api. Hence the detected breaking change |
The title is for version 2020-06, not aligned with the changed file, could you pls clarify? |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for pointing this out. I've moved the change to the appropriate version. |
Azure Pipelines successfully started running 1 pipeline(s). |
Based on comment from service team in #10464, the change is just bug fix for swagger spec, no change in API side, and currently there is no SDKs released for this API version, sign off this PR. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.