Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of Export, Cmk and BYOK features with version upgrade. #10424

Merged
merged 19 commits into from
Aug 31, 2020
Merged

Adding support of Export, Cmk and BYOK features with version upgrade. #10424

merged 19 commits into from
Aug 31, 2020

Conversation

dhawal777
Copy link
Contributor

@dhawal777 dhawal777 commented Aug 11, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 11, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 11, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service databox [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10424/azure-cli-extensions/Azure/azure-cli-extensions/databox/databox-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from f97e160 with merge commit 507c0fe. Azure CLI Automation 13.0.17.20200825.1
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'CreateJobValidations' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'DataBoxScheduleAvailabilityRequest' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'HeavyScheduleAvailabilityRequest' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SubscriptionIsAllowedToCreateJobValidationRequest' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] WARNING: parameter location has two different references but they have the same flattened name

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 11, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f97e160 with merge commit 507c0fe. SDK Automation 13.0.17.20200825.1
  • ⚠️azure-mgmt-databox [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[11,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[14,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[27,13] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.AddressValidationOutputInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[47,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.AddressValidationOutputInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[11,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[81,13] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.JobResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[224,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.JobResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[35,13] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.ValidationInputResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[42,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.ValidationInputResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[11,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[38,13] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.JobSecrets
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[54,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.JobSecrets
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobResource.java:[22,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobResource.java:[52,5] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: interface com.microsoft.azure.management.databox.JobResource
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/AddressValidationOutput.java:[16,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/AddressValidationOutput.java:[30,5] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: interface com.microsoft.azure.management.databox.AddressValidationOutput
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceImpl.java:[20,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceImpl.java:[99,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.JobResourceImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputImpl.java:[15,26] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputImpl.java:[36,12] cannot find symbol
      [mvn]   symbol:   class CloudError
      [mvn]   location: class com.microsoft.azure.management.databox.implementation.AddressValidationOutputImpl
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-databox: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[11,26] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[14,26] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[27,13] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.implementation.AddressValidationOutputInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/AddressValidationOutputInner.java:[47,12] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.implementation.AddressValidationOutputInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[11,26] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[81,13] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.implementation.JobResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/implementation/JobResourceInner.java:[224,12] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.implementation.JobResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[35,13] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.ValidationInputResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/ValidationInputResponse.java:[42,12] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.ValidationInputResponse
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[11,26] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: package com.microsoft.rest
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[38,13] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.JobSecrets
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobSecrets.java:[54,12] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError
      [mvn] [ERROR]   location: class com.microsoft.azure.management.databox.JobSecrets
      [mvn] [ERROR] /z/work/azure-sdk-for-java/azure-mgmt-databox/src/main/java/com/microsoft/azure/management/databox/JobResource.java:[22,26] cannot find symbol
      [mvn] [ERROR]   symbol:   class CloudError

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 11, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from f97e160 with merge commit 507c0fe. SDK Automation 13.0.17.20200825.1
    • ️✔️@azure/arm-databox [View full logs]  [Release SDK Changes]
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/dataBoxManagementClient.js → ./dist/arm-databox.js...
      [npmPack] created ./dist/arm-databox.js in 336ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 165.9kB dist/arm-databox.js                        
      [npmPack] npm notice 63.1kB  dist/arm-databox.min.js                    
      [npmPack] npm notice 1.6kB   esm/dataBoxManagementClient.js             
      [npmPack] npm notice 2.5kB   esm/dataBoxManagementClientContext.js      
      [npmPack] npm notice 345B    esm/models/index.js                        
      [npmPack] npm notice 432B    esm/operations/index.js                    
      [npmPack] npm notice 15.2kB  esm/operations/jobs.js                     
      [npmPack] npm notice 1.6kB   esm/models/jobsMappers.js                  
      [npmPack] npm notice 102.1kB esm/models/mappers.js                      
      [npmPack] npm notice 2.2kB   esm/operations/operations.js               
      [npmPack] npm notice 485B    esm/models/operationsMappers.js            
      [npmPack] npm notice 2.5kB   esm/models/parameters.js                   
      [npmPack] npm notice 983B    rollup.config.js                           
      [npmPack] npm notice 9.1kB   esm/operations/service.js                  
      [npmPack] npm notice 1.9kB   esm/models/serviceMappers.js               
      [npmPack] npm notice 1.6kB   package.json                               
      [npmPack] npm notice 457B    tsconfig.json                              
      [npmPack] npm notice 322.1kB dist/arm-databox.js.map                    
      [npmPack] npm notice 50.6kB  dist/arm-databox.min.js.map                
      [npmPack] npm notice 692B    esm/dataBoxManagementClient.d.ts.map       
      [npmPack] npm notice 816B    esm/dataBoxManagementClient.js.map         
      [npmPack] npm notice 512B    esm/dataBoxManagementClientContext.d.ts.map
      [npmPack] npm notice 1.4kB   esm/dataBoxManagementClientContext.js.map  
      [npmPack] npm notice 28.3kB  esm/models/index.d.ts.map                  
      [npmPack] npm notice 179B    esm/operations/index.d.ts.map              
      [npmPack] npm notice 126B    esm/models/index.js.map                    
      [npmPack] npm notice 194B    esm/operations/index.js.map                
      [npmPack] npm notice 4.7kB   esm/operations/jobs.d.ts.map               
      [npmPack] npm notice 8.0kB   esm/operations/jobs.js.map                 
      [npmPack] npm notice 900B    esm/models/jobsMappers.d.ts.map            
      [npmPack] npm notice 913B    esm/models/jobsMappers.js.map              
      [npmPack] npm notice 4.9kB   esm/models/mappers.d.ts.map                
      [npmPack] npm notice 54.5kB  esm/models/mappers.js.map                  
      [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map         
      [npmPack] npm notice 1.4kB   esm/operations/operations.js.map           
      [npmPack] npm notice 242B    esm/models/operationsMappers.d.ts.map      
      [npmPack] npm notice 255B    esm/models/operationsMappers.js.map        
      [npmPack] npm notice 633B    esm/models/parameters.d.ts.map             
      [npmPack] npm notice 1.9kB   esm/models/parameters.js.map               
      [npmPack] npm notice 3.6kB   esm/operations/service.d.ts.map            
      [npmPack] npm notice 5.3kB   esm/operations/service.js.map              
      [npmPack] npm notice 855B    esm/models/serviceMappers.d.ts.map         
      [npmPack] npm notice 868B    esm/models/serviceMappers.js.map           
      [npmPack] npm notice 3.1kB   README.md                                  
      [npmPack] npm notice 1.1kB   esm/dataBoxManagementClient.d.ts           
      [npmPack] npm notice 1.6kB   src/dataBoxManagementClient.ts             
      [npmPack] npm notice 795B    esm/dataBoxManagementClientContext.d.ts    
      [npmPack] npm notice 2.3kB   src/dataBoxManagementClientContext.ts      
      [npmPack] npm notice 89.1kB  esm/models/index.d.ts                      
      [npmPack] npm notice 116B    esm/operations/index.d.ts                  
      [npmPack] npm notice 85.3kB  src/models/index.ts                        
      [npmPack] npm notice 400B    src/operations/index.ts                    
      [npmPack] npm notice 14.5kB  esm/operations/jobs.d.ts                   
      [npmPack] npm notice 25.8kB  src/operations/jobs.ts                     
      [npmPack] npm notice 1.3kB   esm/models/jobsMappers.d.ts                
      [npmPack] npm notice 1.7kB   src/models/jobsMappers.ts                  
      [npmPack] npm notice 9.0kB   esm/models/mappers.d.ts                    
      [npmPack] npm notice 82.2kB  src/models/mappers.ts                      
      [npmPack] npm notice 2.0kB   esm/operations/operations.d.ts             
      [npmPack] npm notice 4.0kB   src/operations/operations.ts               
      [npmPack] npm notice 175B    esm/models/operationsMappers.d.ts          
      [npmPack] npm notice 455B    src/models/operationsMappers.ts            
      [npmPack] npm notice 719B    esm/models/parameters.d.ts                 
      [npmPack] npm notice 2.5kB   src/models/parameters.ts                   
      [npmPack] npm notice 9.9kB   esm/operations/service.d.ts                
      [npmPack] npm notice 19.3kB  src/operations/service.ts                  
      [npmPack] npm notice 1.6kB   esm/models/serviceMappers.d.ts             
      [npmPack] npm notice 1.9kB   src/models/serviceMappers.ts               
      [npmPack] npm notice 1.1kB   LICENSE.txt                                
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-databox                      
      [npmPack] npm notice version:       4.0.0                                   
      [npmPack] npm notice filename:      azure-arm-databox-4.0.0.tgz             
      [npmPack] npm notice package size:  132.6 kB                                
      [npmPack] npm notice unpacked size: 1.2 MB                                  
      [npmPack] npm notice shasum:        0ac73d4cef7d8fec9d13e5c0e96fdfbc50953a76
      [npmPack] npm notice integrity:     sha512-O+eZ/D94Nu3Qa[...]MLCFpmQKGbwTA==
      [npmPack] npm notice total files:   69                                      
      [npmPack] npm notice 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 11, 2020

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 11, 2020

    azure-sdk-for-net - Release

    failed [Logs] [Expand Details]
    • Generate from f97e160 with merge commit 507c0fe. SDK Automation 13.0.17.20200825.1
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • Microsoft.Azure.Management.DataBox [View full logs]  [Release SDK Changes]
        Failed to create the package Microsoft.Azure.Management.DataBox.
        Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=databox /v:n /p:SkipTests=true , {} 

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 11, 2020

      azure-sdk-for-python - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from f97e160 with merge commit 507c0fe. SDK Automation 13.0.17.20200825.1
        [azure-mgmt-databox][ChangeLog] WARNING: Failed to generate ChangeLog.
      • ⚠️azure-mgmt-databox [View full logs]  [Release SDK Changes]
        [build_conf] INFO:packaging_tools:Building template azure-mgmt-databox
        [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
        [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
        [build_conf] INFO:packaging_tools:Template done azure-mgmt-databox
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
        Not exact 2 reports found:
        code_reports/0.2.0/report.json
        code_reports/latest/merged_report.json
        code_reports/latest/v2018_01_01.json
        code_reports/latest/v2019_09_01.json
        code_reports/latest/v2020_04_01.json
        Not generating changelog.
        [ChangeLog] WARNING: Failed to generate ChangeLog.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 11, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 11, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 12, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @chiragg4u
      Copy link
      Contributor

      Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.
      Also please resolve the failures identified by the automated checks.

      @azure-pipelines
      Copy link

      Pull request contains merge conflicts.

      @azure-pipelines
      Copy link

      Pull request contains merge conflicts.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 16, 2020

      azure-resource-manager-schemas - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from f97e160 with merge commit 507c0fe. Schema Automation 13.0.17.20200825.1
      • ️✔️databox [View full logs]  [Release Schema Changes]
          [after_scripts|node] PostProcessor finished successfully.
          [after_scripts|node]   5645 passing (1m)
          AzureResourceSchema has no registered package commands.

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @pilor pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 26, 2020
        Copy link
        Contributor

        @pilor pilor left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        The diff is very hard to review because APIs were moved around in the file. Please avoid structural changes while making API changes unless necessary, those changes can be made in separate PRs (or a final iteration)

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2020
        @dhawal777
        Copy link
        Contributor Author

        dhawal777 commented Aug 28, 2020

        Hi @pilor, @erich-wang, If we are good to merge, Please merge.

        @erich-wang erich-wang merged commit 507c0fe into Azure:master Aug 31, 2020
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        5 participants