OperationalInsights: DataCollectorLogs new api support. #10365

dulikvor · 2020-08-06T18:19:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-06T18:19:43Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️❌LintDiff: 1 Errors, 2 Warnings [Detail] [Expand]

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' New: Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json#L76
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'gateways' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.OperationalInsights/preview/2020-03-01-preview/Tables.json#L180
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'operations' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.OperationalInsights/preview/2020-03-01-preview/Tables.json#L180

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-06T18:19:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-08-06T18:20:18Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-08-06T18:21:17Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ba891b7 with merge commit 8c7fcf4. SDK Automation 13.0.17.20200807.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.OperationalInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.OperationalInsights.0.21.0-preview.nupkg
- Microsoft.Azure.Management.OperationalInsights.0.21.0-preview.snupkg

openapi-sdkautomation · 2020-08-06T18:21:19Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-06T18:21:21Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-06T18:21:21Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ba891b7 with merge commit 8c7fcf4. SDK Automation 13.0.17.20200807.2

️✔️@azure/arm-operationalinsights [View full logs] [Release SDK Changes]

azure-arm-operationalinsights-3.0.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/operationalInsightsManagementClient.js → ./dist/arm-operationalinsights.js...
[npmPack] created ./dist/arm-operationalinsights.js in 580ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 194.0kB dist/arm-operationalinsights.js                        
[npmPack] npm notice 66.2kB  dist/arm-operationalinsights.min.js                    
[npmPack] npm notice 2.4kB   esm/operations/availableServiceTiers.js                
[npmPack] npm notice 438B    esm/models/availableServiceTiersMappers.js             
[npmPack] npm notice 10.4kB  esm/operations/clusters.js                             
[npmPack] npm notice 845B    esm/models/clustersMappers.js                          
[npmPack] npm notice 5.6kB   esm/operations/dataExports.js                          
[npmPack] npm notice 854B    esm/models/dataExportsMappers.js                       
[npmPack] npm notice 6.4kB   esm/operations/dataSources.js                          
[npmPack] npm notice 805B    esm/models/dataSourcesMappers.js                       
[npmPack] npm notice 2.7kB   esm/operations/deletedWorkspaces.js                    
[npmPack] npm notice 810B    esm/models/deletedWorkspacesMappers.js                 
[npmPack] npm notice 2.0kB   esm/operations/gateways.js                             
[npmPack] npm notice 403B    esm/models/gatewaysMappers.js                          
[npmPack] npm notice 345B    esm/models/index.js                                    
[npmPack] npm notice 1.0kB   esm/operations/index.js                                
[npmPack] npm notice 4.5kB   esm/operations/intelligencePacks.js                    
[npmPack] npm notice 430B    esm/models/intelligencePacksMappers.js                 
[npmPack] npm notice 8.0kB   esm/operations/linkedServices.js                       
[npmPack] npm notice 811B    esm/models/linkedServicesMappers.js                    
[npmPack] npm notice 5.7kB   esm/operations/linkedStorageAccounts.js                
[npmPack] npm notice 826B    esm/models/linkedStorageAccountsMappers.js             
[npmPack] npm notice 2.0kB   esm/operations/managementGroups.js                     
[npmPack] npm notice 465B    esm/models/managementGroupsMappers.js                  
[npmPack] npm notice 55.5kB  esm/models/mappers.js                                  
[npmPack] npm notice 3.0kB   esm/operationalInsightsManagementClient.js             
[npmPack] npm notice 2.6kB   esm/operationalInsightsManagementClientContext.js      
[npmPack] npm notice 2.3kB   esm/operations/operations.js                           
[npmPack] npm notice 455B    esm/models/operationsMappers.js                        
[npmPack] npm notice 1.9kB   esm/operations/operationStatuses.js                    
[npmPack] npm notice 465B    esm/models/operationStatusesMappers.js                 
[npmPack] npm notice 6.1kB   esm/models/parameters.js                               
[npmPack] npm notice 1.0kB   rollup.config.js                                       
[npmPack] npm notice 5.5kB   esm/operations/savedSearches.js                        
[npmPack] npm notice 810B    esm/models/savedSearchesMappers.js                     
[npmPack] npm notice 1.9kB   esm/operations/schema.js                               
[npmPack] npm notice 508B    esm/models/schemaMappers.js                            
[npmPack] npm notice 3.0kB   esm/operations/sharedKeysOperations.js                 
[npmPack] npm notice 427B    esm/models/sharedKeysOperationsMappers.js              
[npmPack] npm notice 6.5kB   esm/operations/storageInsightConfigs.js                
[npmPack] npm notice 819B    esm/models/storageInsightConfigsMappers.js             
[npmPack] npm notice 4.2kB   esm/operations/tables.js                               
[npmPack] npm notice 835B    esm/models/tablesMappers.js                            
[npmPack] npm notice 1.9kB   esm/operations/usages.js                               
[npmPack] npm notice 453B    esm/models/usagesMappers.js                            
[npmPack] npm notice 3.4kB   esm/operations/workspacePurge.js                       
[npmPack] npm notice 538B    esm/models/workspacePurgeMappers.js                    
[npmPack] npm notice 9.5kB   esm/operations/workspaces.js                           
[npmPack] npm notice 803B    esm/models/workspacesMappers.js                        
[npmPack] npm notice 1.8kB   package.json                                           
[npmPack] npm notice 457B    tsconfig.json                                          
[npmPack] npm notice 403.5kB dist/arm-operationalinsights.js.map                    
[npmPack] npm notice 53.7kB  dist/arm-operationalinsights.min.js.map                
[npmPack] npm notice 829B    esm/operations/availableServiceTiers.d.ts.map          
[npmPack] npm notice 1.2kB   esm/operations/availableServiceTiers.js.map            
[npmPack] npm notice 214B    esm/models/availableServiceTiersMappers.d.ts.map       
[npmPack] npm notice 227B    esm/models/availableServiceTiersMappers.js.map         
[npmPack] npm notice 3.4kB   esm/operations/clusters.d.ts.map                       
[npmPack] npm notice 5.6kB   esm/operations/clusters.js.map                         
[npmPack] npm notice 482B    esm/models/clustersMappers.d.ts.map                    
[npmPack] npm notice 495B    esm/models/clustersMappers.js.map                      
[npmPack] npm notice 2.4kB   esm/operations/dataExports.d.ts.map                    
[npmPack] npm notice 3.1kB   esm/operations/dataExports.js.map                      
[npmPack] npm notice 488B    esm/models/dataExportsMappers.d.ts.map                 
[npmPack] npm notice 501B    esm/models/dataExportsMappers.js.map                   
[npmPack] npm notice 2.8kB   esm/operations/dataSources.d.ts.map                    
[npmPack] npm notice 3.7kB   esm/operations/dataSources.js.map                      
[npmPack] npm notice 462B    esm/models/dataSourcesMappers.d.ts.map                 
[npmPack] npm notice 475B    esm/models/dataSourcesMappers.js.map                   
[npmPack] npm notice 1.1kB   esm/operations/deletedWorkspaces.d.ts.map              
[npmPack] npm notice 1.5kB   esm/operations/deletedWorkspaces.js.map                
[npmPack] npm notice 474B    esm/models/deletedWorkspacesMappers.d.ts.map           
[npmPack] npm notice 487B    esm/models/deletedWorkspacesMappers.js.map             
[npmPack] npm notice 792B    esm/operations/gateways.d.ts.map                       
[npmPack] npm notice 1.1kB   esm/operations/gateways.js.map                         
[npmPack] npm notice 175B    esm/models/gatewaysMappers.d.ts.map                    
[npmPack] npm notice 188B    esm/models/gatewaysMappers.js.map                      
[npmPack] npm notice 23.8kB  esm/models/index.d.ts.map                              
[npmPack] npm notice 558B    esm/operations/index.d.ts.map                          
[npmPack] npm notice 126B    esm/models/index.js.map                                
[npmPack] npm notice 573B    esm/operations/index.js.map                            
[npmPack] npm notice 1.8kB   esm/operations/intelligencePacks.d.ts.map              
[npmPack] npm notice 2.4kB   esm/operations/intelligencePacks.js.map                
[npmPack] npm notice 206B    esm/models/intelligencePacksMappers.d.ts.map           
[npmPack] npm notice 219B    esm/models/intelligencePacksMappers.js.map             
[npmPack] npm notice 2.1kB   esm/operations/linkedServices.d.ts.map                 
[npmPack] npm notice 3.7kB   esm/operations/linkedServices.js.map

openapi-sdkautomation · 2020-08-06T18:21:21Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ba891b7 with merge commit 8c7fcf4. SDK Automation 13.0.17.20200807.2

️✔️azure-mgmt-loganalytics [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-loganalytics
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-loganalytics
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.196% size of original (original: 48890 chars, delta: 96 chars)
[ChangeLog]

openapi-sdkautomation · 2020-08-06T18:21:23Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ba891b7 with merge commit 8c7fcf4. SDK Automation 13.0.17.20200807.2
️✔️sdk/loganalytics/mgmt-v2015_03_20 [View full logs] [Release SDK Changes]
```
Error: spawn bundle ENOENT
Error: spawn rake ENOENT
```
️✔️sdk/loganalytics/mgmt-v2015_11_01_preview [View full logs] [Release SDK Changes]
```
Error: spawn bundle ENOENT
Error: spawn rake ENOENT
```

⚠️sdk/loganalytics/mgmt-v2020_03_01_preview [View full logs] [Release SDK Changes]

Error: spawn bundle ENOENT
Error: spawn rake ENOENT
[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
[mvn]   symbol:   class DataSourceType
[mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
[mvn]   symbol:   class DataSourceType
[mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-loganalytics: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
[mvn] [ERROR]   symbol:   class DataSourceType
[mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_03_01_preview/src/main/java/com/microsoft/azure/management/loganalytics/v2020_03_01_preview/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
[mvn] [ERROR]   symbol:   class DataSourceType
[mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_03_01_preview.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/loganalytics/mgmt-v2020_08_01 [View full logs] [Release SDK Changes]

Error: spawn bundle ENOENT
Error: spawn rake ENOENT
[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
[mvn]   symbol:   class DataSourceType
[mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
[mvn]   symbol:   class DataSourceType
[mvn]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-loganalytics: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[64,111] cannot find symbol
[mvn] [ERROR]   symbol:   class DataSourceType
[mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/loganalytics/mgmt-v2020_08_01/src/main/java/com/microsoft/azure/management/loganalytics/v2020_08_01/implementation/LinkedStorageAccountsImpl.java:[80,84] cannot find symbol
[mvn] [ERROR]   symbol:   class DataSourceType
[mvn] [ERROR]   location: class com.microsoft.azure.management.loganalytics.v2020_08_01.implementation.LinkedStorageAccountsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-08-06T18:21:23Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ba891b7 with merge commit 8c7fcf4. SDK Automation 13.0.17.20200807.2
⚠️operationalinsights/mgmt/2015-03-20 [View full logs]
- operationalinsights.mgmt.2015-03-20.zip
```
No file is changed.
```
⚠️preview/operationalinsights/mgmt/2015-11-01-preview [View full logs]
- preview.operationalinsights.mgmt.2015-11-01-preview.zip
```
No file is changed.
```
️✔️preview/operationalinsights/mgmt/2020-03-01-preview [View full logs] [Release SDK Changes]
- preview.operationalinsights.mgmt.2020-03-01-preview.zip
️✔️preview/operationalinsights/mgmt/2020-08-01 [View full logs] [Release SDK Changes]
- preview.operationalinsights.mgmt.2020-08-01.zip

azure-pipelines · 2020-08-07T05:03:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-07T05:05:04Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-08-07T05:31:08Z

Azure Pipelines successfully started running 1 pipeline(s).

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

azure-pipelines · 2020-08-09T18:01:06Z

Azure Pipelines successfully started running 1 pipeline(s).

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

azure-pipelines · 2020-08-10T06:24:19Z

Azure Pipelines successfully started running 1 pipeline(s).

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

azure-pipelines · 2020-08-10T14:57:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T07:07:38Z

Azure Pipelines successfully started running 1 pipeline(s).

dulikvor · 2020-08-11T07:58:05Z

Hi @myronfanqiu,
error response have been added, all comments are resolved and all validations have passed.
feel free to review, thanks.

mmyyrroonn · 2020-08-12T02:44:56Z

@Dudi119 We need ARM's review as well.

ravbhatnagar

@Dudi119 few comments

ravbhatnagar · 2020-08-17T20:56:46Z

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

+          }
+        ],
+        "responses": {
+          "200": {


what is the response of this post action?

please add the response schema.

no schema, just 200 since its basically a delete.

ravbhatnagar · 2020-08-17T20:57:40Z

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

+          }
+        }
+      },
+      "get": {


how is the POST different from this GET? the API signature is same.

so the scenario is user lists the tables and then you want to give them the option to delete them. In that case, your POST should be changed to a DELETE, and they can provide the tableName that they want to delete. Much cleaner approach. POST for delete is ugly.

we do not support full CRUD, is it fine if i will supply delete and get and no put? this is why we used post instead.

yes, it will be ok to have GET and DELETE

ravbhatnagar · 2020-08-17T21:00:50Z

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json

+    }
+  },
+  "paths": {
+    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/dataCollectorLogs": {


From description it seems like this POST action is used to delete a log table. what is the need to expose deletion operation through the control plane on something (tables) which is not exposed on the control plane. Its wierd and can cause of sorts of issues like permission check, inconsistent state/confusion for customer where i am assuming same thing can be from the dataplane api as well etc.

and if we agree that this is the only way to go about it and its required, i will ask you, at the very least to change the name of this action. This POST action from the name seems very harmless but it ends up deleting something. So name should indicate what this operation does. may be call it deleteDataCollectorLogsTable. But lets answer the above question first.

it all derives from the fact this is not a typical CRUD, so post is multi purpose, in this case being used for delete.
i have no problem changing the post to delete, but there will be no put. is that sounds reasonable?

yes, better to switch to GET and DELETE

azure-pipelines · 2020-08-19T08:45:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-19T08:48:47Z

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ba891b7 with merge commit 8c7fcf4. Schema Automation 13.0.17.20200807.2

️✔️operationalinsights [View full logs] [Release Schema Changes]

[after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5634 passing (1m)
AzureResourceSchema has no registered package commands.

azure-pipelines · 2020-08-19T13:59:38Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar · 2020-08-19T15:14:33Z

please also add a GET "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/dataCollectorLogs/{tableName}

ravbhatnagar · 2020-08-19T15:14:55Z

SIgning off conditionally assuming the point GET will not be a big deal to add.

mmyyrroonn · 2020-08-20T02:53:18Z

@Dudi119 Hi. Could you please fix one lint error about the delete operation?

dulikvor · 2020-08-20T04:50:19Z

@myronfanqiu, sure, i will review it, i also need to add another point get so a few more things to add.

azure-pipelines · 2020-08-20T06:38:07Z

Azure Pipelines successfully started running 1 pipeline(s).

dulikvor · 2020-08-20T06:55:20Z

@myronfanqiu, our Delete only returns 200 with no content, we do not supply 204.

Dudi Likvornik added 6 commits March 25, 2020 21:17

Typo, upper case and other minor corrections.

91ed7bd

Lets make all prettier.

893d1f9

Removing redundant property, marking datasourcetype as readonly.

a90be91

Merge remote-tracking branch 'upstream/master'

b3e9da6

DataCollectors custom logs swagger support.

0fcbe21

Update DataCollectorLogs.json

ad1c14b

openapi-assignment-bot bot assigned mmyyrroonn Aug 6, 2020

openapi-sdkautomation bot mentioned this pull request Aug 6, 2020

[AutoPR @azure/arm-operationalinsights] OperationalInsights: DataCollectorLogs new api support. AzureSDKAutomation/azure-sdk-for-js#1637

Closed

Readme reference, prettier.

77fcfcd

Update DataCollectorLogs.json

22c1e5c

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2020

yoramsinger reviewed Aug 9, 2020

View reviewed changes

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json Outdated Show resolved Hide resolved

yoramsinger reviewed Aug 9, 2020

View reviewed changes

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json Outdated Show resolved Hide resolved

yoramsinger reviewed Aug 9, 2020

View reviewed changes

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json Outdated Show resolved Hide resolved

yoramsinger reviewed Aug 9, 2020

View reviewed changes

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json Outdated Show resolved Hide resolved

Segmenting Post request and List response.

e082399

yoramsinger reviewed Aug 9, 2020

View reviewed changes

...urce-manager/Microsoft.OperationalInsights/preview/2020-03-01-preview/DataCollectorLogs.json Outdated Show resolved Hide resolved

More name related changes.

bfd7663

mmyyrroonn reviewed Aug 10, 2020

View reviewed changes

Adding error response.

5fef998

Refining error contract.

a87bd3d

mmyyrroonn approved these changes Aug 12, 2020

View reviewed changes

ravbhatnagar reviewed Aug 17, 2020

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 18, 2020

Turning post into delete.

c7021ee

openapi-sdkautomation bot mentioned this pull request Aug 19, 2020

[AutoPR operationalinsights] OperationalInsights: DataCollectorLogs new api support. AzureSDKAutomation/azure-resource-manager-schemas#107

Closed

Correcting path.

cb67a6d

Adding a point get.

ba891b7

mmyyrroonn merged commit 8c7fcf4 into Azure:master Aug 24, 2020

OperationalInsights: DataCollectorLogs new api support. #10365

OperationalInsights: DataCollectorLogs new api support. #10365

Conversation

dulikvor commented Aug 6, 2020 • edited by mmyyrroonn Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 6, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 6, 2020

azuresdkci commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-go - Release

azure-pipelines bot commented Aug 7, 2020

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Aug 7, 2020

azure-pipelines bot commented Aug 9, 2020

azure-pipelines bot commented Aug 10, 2020

azure-pipelines bot commented Aug 10, 2020

azure-pipelines bot commented Aug 11, 2020

dulikvor commented Aug 11, 2020 • edited Loading

mmyyrroonn commented Aug 12, 2020

ravbhatnagar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 19, 2020

openapi-sdkautomation bot commented Aug 19, 2020 • edited Loading

azure-resource-manager-schemas - Release

azure-pipelines bot commented Aug 19, 2020

ravbhatnagar commented Aug 19, 2020

ravbhatnagar commented Aug 19, 2020

mmyyrroonn commented Aug 20, 2020

dulikvor commented Aug 20, 2020

azure-pipelines bot commented Aug 20, 2020

dulikvor commented Aug 20, 2020

dulikvor commented Aug 6, 2020 •

edited by mmyyrroonn

Loading

openapi-pipeline-app bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

dulikvor commented Aug 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 19, 2020 •

edited

Loading