-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev containerservice microsoft.container service 2020 07 01 #10348
Merged
PhoenixHe-NV
merged 6 commits into
master
from
dev-containerservice-Microsoft.ContainerService-2020-07-01
Aug 19, 2020
Merged
Dev containerservice microsoft.container service 2020 07 01 #10348
PhoenixHe-NV
merged 6 commits into
master
from
dev-containerservice-Microsoft.ContainerService-2020-07-01
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2020-06-01 to version 2020-07-01
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Aug 5, 2020
gtxistxgao
changed the title
Dev containerservice microsoft.container service 2020 07 01
[DO NOT MERGE] Dev containerservice microsoft.container service 2020 07 01
Aug 5, 2020
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
This was referenced Aug 5, 2020
This was referenced Aug 5, 2020
PhoenixHe-NV
added
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Aug 5, 2020
gtxistxgao
changed the title
[DO NOT MERGE] Dev containerservice microsoft.container service 2020 07 01
Dev containerservice microsoft.container service 2020 07 01
Aug 17, 2020
gtxistxgao
removed
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Aug 17, 2020
tilnl
approved these changes
Aug 17, 2020
@NullMDR could we have a review/merge of this PR? 🙏 |
azure-resource-manager-schemas - Release
|
FumingZhang
deleted the
dev-containerservice-Microsoft.ContainerService-2020-07-01
branch
February 26, 2024 05:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.