Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace_datetime #10335

Merged
merged 1 commit into from
Aug 6, 2020
Merged

replace_datetime #10335

merged 1 commit into from
Aug 6, 2020

Conversation

changlong-liu
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 4, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

  • Installation instruction for service desktopvirtualization [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10335/azure-cli-extensions/Azure/azure-cli-extensions/desktopvirtualization/desktopvirtualization-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 175978d with merge commit 4f3d54b. Azure CLI Automation 13.0.17.20200619.4 
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_List
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
[AutoRest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
[AutoRest]     - name: /HostPools/put/HostPool_Create
[AutoRest]     - name: /HostPools/get/HostPool_Get
[AutoRest]     - name: /HostPools/get/HostPool_List
[AutoRest]     - name: /HostPools/get/HostPool_ListByResourceGroup
[AutoRest]     - name: /HostPools/patch/HostPool_Update
[AutoRest]     - name: /Workspaces/put/Workspace_Create
[AutoRest]     - name: /Workspaces/get/Workspace_Get
[AutoRest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
[AutoRest]     - name: /Workspaces/get/Workspace_ListBySubscription
[AutoRest]     - name: /Workspaces/patch/Workspace_Update
[AutoRest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
[AutoRest]     - name: /HostPools/delete/HostPool_Delete
[AutoRest]     - name: /Workspaces/delete/Workspace_Delete
[AutoRest] --------------------------------------------------------
  • ️✔️desktopvirtualization [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 175978d with merge commit 4f3d54b. SDK Automation 13.0.17.20200619.4 
    [azure-mgmt-desktopvirtualization][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-desktopvirtualization [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools:Template done azure-mgmt-desktopvirtualization
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 4, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 175978d with merge commit 4f3d54b. SDK Automation 13.0.17.20200619.4 
    Failed to find any diff after autorest so no changed packages was found.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@fengzhou-msft fengzhou-msft merged commit 4f3d54b into Azure:master Aug 6, 2020
@changlong-liu
Copy link
Member Author

Thanks @fengzhou-msft !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@changlong-liu @azuresdkci @fengzhou-msft