Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Use POST operation for node image version #10294

Conversation

gtxistxgao
Copy link
Contributor

@gtxistxgao gtxistxgao commented Jul 29, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 29, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 920a122 with merge commit 20b08f935aa2cc46b238a8b1c3a95948e97cc8c3. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
    [npmPack] created ./dist/arm-containerservice.js in 372ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 10.9kB  esm/operations/agentPools.js                         
    [npmPack] npm notice 2.2kB   esm/models/agentPoolsMappers.js                      
    [npmPack] npm notice 209.1kB dist/arm-containerservice.js                         
    [npmPack] npm notice 75.6kB  dist/arm-containerservice.min.js                     
    [npmPack] npm notice 2.0kB   esm/containerServiceClient.js                        
    [npmPack] npm notice 2.6kB   esm/containerServiceClientContext.js                 
    [npmPack] npm notice 11.8kB  esm/operations/containerServices.js                  
    [npmPack] npm notice 2.2kB   esm/models/containerServicesMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 573B    esm/operations/index.js                              
    [npmPack] npm notice 26.9kB  esm/operations/managedClusters.js                    
    [npmPack] npm notice 2.3kB   esm/models/managedClustersMappers.js                 
    [npmPack] npm notice 83.4kB  esm/models/mappers.js                                
    [npmPack] npm notice 12.6kB  esm/operations/openShiftManagedClusters.js           
    [npmPack] npm notice 2.1kB   esm/models/openShiftManagedClustersMappers.js        
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                         
    [npmPack] npm notice 458B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 4.4kB   esm/models/parameters.js                             
    [npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 2.1kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 1.0kB   rollup.config.js                                     
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 3.4kB   esm/operations/agentPools.d.ts.map                   
    [npmPack] npm notice 5.4kB   esm/operations/agentPools.js.map                     
    [npmPack] npm notice 919B    esm/models/agentPoolsMappers.d.ts.map                
    [npmPack] npm notice 932B    esm/models/agentPoolsMappers.js.map                  
    [npmPack] npm notice 403.8kB dist/arm-containerservice.js.map                     
    [npmPack] npm notice 54.6kB  dist/arm-containerservice.min.js.map                 
    [npmPack] npm notice 811B    esm/containerServiceClient.d.ts.map                  
    [npmPack] npm notice 1.0kB   esm/containerServiceClient.js.map                    
    [npmPack] npm notice 480B    esm/containerServiceClientContext.d.ts.map           
    [npmPack] npm notice 1.3kB   esm/containerServiceClientContext.js.map             
    [npmPack] npm notice 3.4kB   esm/operations/containerServices.d.ts.map            
    [npmPack] npm notice 5.6kB   esm/operations/containerServices.js.map              
    [npmPack] npm notice 920B    esm/models/containerServicesMappers.d.ts.map         
    [npmPack] npm notice 933B    esm/models/containerServicesMappers.js.map           
    [npmPack] npm notice 28.9kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 250B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 265B    esm/operations/index.js.map                          
    [npmPack] npm notice 6.9kB   esm/operations/managedClusters.d.ts.map              
    [npmPack] npm notice 12.5kB  esm/operations/managedClusters.js.map                
    [npmPack] npm notice 952B    esm/models/managedClustersMappers.d.ts.map           
    [npmPack] npm notice 965B    esm/models/managedClustersMappers.js.map             
    [npmPack] npm notice 3.8kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 44.4kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 3.3kB   esm/operations/openShiftManagedClusters.d.ts.map     
    [npmPack] npm notice 5.9kB   esm/operations/openShiftManagedClusters.js.map       
    [npmPack] npm notice 905B    esm/models/openShiftManagedClustersMappers.d.ts.map  
    [npmPack] npm notice 918B    esm/models/openShiftManagedClustersMappers.js.map    
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 908B    esm/operations/operations.js.map                     
    [npmPack] npm notice 212B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 225B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 968B    esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 3.3kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 899B    esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 912B    esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 3.3kB   README.md                                            
    [npmPack] npm notice 9.9kB   esm/operations/agentPools.d.ts                       
    [npmPack] npm notice 18.0kB  src/operations/agentPools.ts                         
    [npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.d.ts                    
    [npmPack] npm notice 2.3kB   src/models/agentPoolsMappers.ts                      
    [npmPack] npm notice 1.4kB   esm/containerServiceClient.d.ts                      
    [npmPack] npm notice 2.2kB   src/containerServiceClient.ts                        
    [npmPack] npm notice 898B    esm/containerServiceClientContext.d.ts               
    [npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts                 
    [npmPack] npm notice 12.9kB  esm/operations/containerServices.d.ts                
    [npmPack] npm notice 21.3kB  src/operations/containerServices.ts                  
    [npmPack] npm notice 1.9kB   esm/models/containerServicesMappers.d.ts             
    [npmPack] npm notice 2.3kB   src/models/containerServicesMappers.ts               
    [npmPack] npm notice 101.0kB esm/models/index.d.ts                                
    [npmPack] npm notice 257B    esm/operations/index.d.ts                            
    [npmPack] npm notice 96.9kB  src/models/index.ts                                  
    [npmPack] npm notice 541B    src/operations/index.ts                              
    [npmPack] npm notice 22.6kB  esm/operations/managedClusters.d.ts                  
    [npmPack] npm notice 41.0kB  src/operations/managedClusters.ts                    
    [npmPack] npm notice 1.9kB   esm/models/managedClustersMappers.d.ts               
    [npmPack] npm notice 2.3kB   src/models/managedClustersMappers.ts                 
    [npmPack] npm notice 5.9kB   esm/models/mappers.d.ts                              
    [npmPack] npm notice 66.7kB  src/models/mappers.ts                                
    [npmPack] npm notice 10.5kB  esm/operations/openShiftManagedClusters.d.ts         
    [npmPack] npm notice 19.1kB  src/operations/openShiftManagedClusters.ts           
    [npmPack] npm notice 1.8kB   esm/models/openShiftManagedClustersMappers.d.ts      

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 920a122 with merge commit 20b08f935aa2cc46b238a8b1c3a95948e97cc8c3. SDK Automation 13.0.17.20200619.4
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
  • ️✔️azure-mgmt-containerservice [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 1.699% size of original (original: 61633 chars, delta: 1047 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ManagedClusterWindowsProfile has a new parameter license_type
    [ChangeLog]   - Added operation ManagedClustersOperations.upgrade_node_image_version

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@gtxistxgao gtxistxgao force-pushed the tigao/upgradenodeimageversion branch from 74e5d24 to cec4662 Compare July 29, 2020 20:48
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gtxistxgao gtxistxgao changed the title Use POST operation for node image version [AKS] Use POST operation for node image version Jul 29, 2020
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtxistxgao - few comments

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 31, 2020
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 5, 2020
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@fengzhou-msft fengzhou-msft merged commit ef362e1 into Azure:dev-containerservice-Microsoft.ContainerService-2020-07-01 Aug 5, 2020
PhoenixHe-NV pushed a commit that referenced this pull request Aug 19, 2020
* Adds base for updating Microsoft.ContainerService from version stable/2020-06-01 to version 2020-07-01

* Updates readme

* Updates API version in new specs and examples

* Add licenseType in WindowsProfile for AKS (#10050)

* Change podsecuritypolicy description from PREVIEW to DEPRECATING. (#10175)

* [AKS] Use POST operation for node image version (#10294)

Co-authored-by: Xiaofang Zhang <[email protected]>
Co-authored-by: Chou Hu <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants